From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: Xilinx SYSACE driver and 8-bit attachment Date: Wed, 7 Oct 2009 08:52:34 -0600 Message-ID: References: <1d3f23370910070013u6307bc42hf7ab243b52d007df@mail.gmail.com> <192797ad-5dd4-4ebe-8db3-d381bb949e1e@VA3EHSMHS029.ehs.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <192797ad-5dd4-4ebe-8db3-d381bb949e1e-+Ck8Kgl/v09YkiQOvaGFS7jjLBE8jN/0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: John Linn Cc: David DeBonis , Stephen Neuendorffer , devicetree-discuss , Linux Kernel list , Michal Simek , John Linn , John Williams List-Id: devicetree@vger.kernel.org On Wed, Oct 7, 2009 at 8:42 AM, John Linn wrote: >> -----Original Message----- >> From: John Linn >> Sent: Wednesday, October 07, 2009 8:24 AM >> To: 'Grant Likely'; John Williams >> Cc: Linux Kernel list; Michal Simek; David DeBonis; Stephen Neuendorffer= ; devicetree-discuss >> Subject: RE: Xilinx SYSACE driver and 8-bit attachment >> >> I'll look to see if something has changed. =A0It's not clear to me if it= has ever been right. >> >> It look like we normally use 16 bit mode as that's how BSB generates the= system by default. >> >> Thanks, >> John >> >> > -----Original Message----- >> > From: glikely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org [mailto:glikely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org] On Behalf Of = Grant Likely >> > Sent: Wednesday, October 07, 2009 7:35 AM >> > To: John Williams >> > Cc: Linux Kernel list; Michal Simek; John Linn; David DeBonis; Stephen= Neuendorffer; devicetree- >> > discuss >> > Subject: Re: Xilinx SYSACE driver and 8-bit attachment >> > >> > [Added devicetree-discuss to cc: list] >> > >> > On Wed, Oct 7, 2009 at 1:13 AM, John Williams >> > wrote: >> > > Hi Grant (it's your driver :) and David D ( and your DTS generator :) >> > [...] >> > > if (of_find_property(op->node, "8-bit", NULL)) >> > [...] >> > > doesn't match the properties generated by Xilinx's device tree gener= ator: >> > [...] >> > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0 xlnx,mem-width =3D <0x8>; > > Do you know if the 8 bit mode was ever tested with the "8-bit" property i= n the tree? > > I don't see anything in the device tree generator history to say we ever = did that "8-bit", but maybe I'm missing something. > > We are just generating the parameters from the h/w and the memory width i= s it. =A0We can always put something in there special, but it seems silly i= f it was never used anyway. Don't forget that Virtex and Microblaze are not the only users of this driver. There is a AMCC 440 board which uses the sysace as a CF adapter. 8-bit was definitely tested and is in use. g. -- = Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.