From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH v2 11/11] of: unify phandle name in struct device_node Date: Tue, 24 Nov 2009 18:33:33 -0700 Message-ID: References: <20091124215908.559.23998.stgit@angua> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: sparclinux-owner@vger.kernel.org To: Segher Boessenkool Cc: linuxppc-dev@lists.ozlabs.org, devicetree-discuss@lists.ozlabs.org, sparclinux@vger.kernel.org, microblaze-uclinux@itee.uq.edu.au, benh@kernel.crashing.org, sfr@canb.auug.org.au, davem@davemloft.net, monstr@monstr.eu List-Id: devicetree@vger.kernel.org On Tue, Nov 24, 2009 at 6:30 PM, Segher Boessenkool wrote: >> In struct device_node, the phandle is named 'linux_phandle' for Powe= rPC >> and MicroBlaze, and 'node' for SPARC. =A0There is no good reason for= the >> difference, it is just an artifact of the code diverging over a coup= le >> of years. =A0This patch renames both to simply .phandle. >> >> Note: the .node also existed in PowerPC/MicroBlaze, but the only use= r >> seems to be arch/powerpc/platforms/powermac/pfunc_core.c. =A0It does= n't >> look like the assignment between .linux_phandle and .node is >> significantly different enough to warrant the separate code paths >> unless ibm,phandle properties actually appear in Apple device trees. >> >> I think it is safe to eliminate the old .node property and use >> linux_phandle everywhere. > > =A0^^^^^^^^^^^^ =A0You forgot to update one :-) Heeheehee. oops. g. --=20 Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html