From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 06/11] of/flattree: merge early_init_devtree() and early_init_move_devtree() Date: Thu, 10 Dec 2009 23:20:09 -0700 Message-ID: References: <20091124081316.6216.66310.stgit@angua> <20091124081853.6216.68105.stgit@angua> <200912071508.25551.jeremy.kerr@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <200912071508.25551.jeremy.kerr@canonical.com> Sender: sparclinux-owner@vger.kernel.org To: Jeremy Kerr Cc: devicetree-discuss@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, microblaze-uclinux@itee.uq.edu.au, benh@kernel.crashing.org, sfr@canb.auug.org.au, davem@davemloft.net, monstr@monstr.eu List-Id: devicetree@vger.kernel.org On Mon, Dec 7, 2009 at 12:08 AM, Jeremy Kerr wrote: > Hi Grant, > >> + =A0 =A0 /* Scan memory nodes and rebuild LMBs */ >> + =A0 =A0 lmb_init(); >> + =A0 =A0 of_scan_flat_dt(early_init_dt_scan_root, NULL); >> + =A0 =A0 of_scan_flat_dt(early_init_dt_scan_memory, NULL); >> + >> + =A0 =A0 /* Save command line for /proc/cmdline and then parse para= meters */ >> + =A0 =A0 strlcpy(boot_command_line, cmd_line, COMMAND_LINE_SIZE); >> + =A0 =A0 parse_early_param(); >> + >> + =A0 =A0 /* This is in an arbitrary spot, but it is temporary. =A0A= fter all >> + =A0 =A0 =A0* the common code is merged, the structure of the early= init >> + =A0 =A0 =A0* code will be reevaluated and refactored */ >> + =A0 =A0 early_init_devtree_arch(); >> + >> + =A0 =A0 lmb_analyze(); >> + =A0 =A0 lmb_dump_all(); > > So we're assuming that the arch has lmb support, or should we make th= is > conditional on CONFIG_HAVE_LMB? I'm not making any assumptions yet. I'm just merging the code. A lot of it needs to be refactored after the merge. Feel free to send patches to rework want you need. g. --=20 Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html