From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [Power.org:parch] Re: RFC: proposal to extend the open-pic interrupt specifierdefinition Date: Wed, 13 Jan 2010 07:27:31 -0700 Message-ID: References: <9696D7A991D0824DBA8DFAC74A9C5FA30590506E@az33exm25.fsl.freescale.net> <20100107005036.GB23206@yookeroo> <9696D7A991D0824DBA8DFAC74A9C5FA305987E61@az33exm25.fsl.freescale.net> <20100107045514.GF2847@yookeroo> <4B46176F.2040600@freescale.com> <9696D7A991D0824DBA8DFAC74A9C5FA305988946@az33exm25.fsl.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <9696D7A991D0824DBA8DFAC74A9C5FA305988946-ofAVchDyotYzzZk0BCvKg5jmvxFtTJ+o0e7PPNI6Mm0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Yoder Stuart-B08248 Cc: Wood Scott-B07421 , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, parch-QRwYI7m9GJLYtjvyW6yDsg@public.gmane.org, Gala Kumar-B11780 , David Gibson List-Id: devicetree@vger.kernel.org On Wed, Jan 13, 2010 at 7:19 AM, Yoder Stuart-B08248 wrote: >> It does not sound sane or >> particularly parseable to stuff it into bitfields within the second >> cell. > > I think it is somewhat sane compared to the alternatives. =A0The > second cell encodes information about the interrupt source. =A0Allowing > some of those bits to encode information besides level/sense > doesn't seem that difficult. Not difficult. Ugly, unnecessary, and sounds like a premature optimization. >> Users have enough trouble parsing irq specifiers as is. =A0It makes me >> nervous to see even more complicated irq specifiers being devised. > > Yes, they become slightly more complicated, but the complexity needs to > go somewhere. Then at the very least do it as separate cells. Carving cells into multiple fields is pretty ugly when cells are cheap. g. -- = Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.