From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH] of: add bus-number specification to spi_mpc8xxx Date: Tue, 16 Feb 2010 07:28:39 -0700 Message-ID: References: <20100216150850.d966cd79.eschwab@online.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100216150850.d966cd79.eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Ernst Schwab Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Feb 16, 2010 at 7:08 AM, Ernst Schwab wrote: > From: Ernst Schwab > > Added devicetree parsing for SPI bus number. If no bus number is specified, > a dynamically assigned bus number will be used (typically 32766). > > Signed-off-by: Ernst Schwab No, unless you can provide a really compelling reason to do so, the goal is to *not* specify Linux implementation detail things like bus numbers in the device tree. Instead, your code should be using spi device child nodes from the bus, or finding the spi bus node and decoding the dynamically assigned bus number from there. Don't hard code spi bus numbers. g.