Re: [RFC] driver-core: Add device node pointer to struct device

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

On Wed, Feb 24, 2010 at 2:44 PM, Greg KH <gregkh-l3A5Bk7waGM@public.gmane.org> wrote:
> On Wed, Feb 24, 2010 at 02:10:30PM -0700, Grant Likely wrote:
>> Greg and Kay,
>>
>> This is a patch from a larger series of OF related cleanup patches.  This
>> one adds a new 'of_node' member to struct device, conditional upon
>> CONFIG_OF.  The goal is to move of_node out of archdata because all
>> arches using CONFIG_OF need it.
>>
>> Before I commit too much effort down this path, I want to get your
>> feedback.  Do you have any objections to this change to struct device?
>>
>> @@ -414,6 +415,9 @@ struct device {
>>                                            override */
>>       /* arch specific additions */
>>       struct dev_archdata     archdata;
>> +#ifdef CONFIG_OF
>> +     struct device_node      *of_node;
>> +#endif
>
> No objection from me, but do we really need the #ifdef here?

I added the #ifdef because it is complete dead weight when CONFIG_OF
is not set.  However, I'll defer to your preference here on what looks
cleaner w.r.t. maintenance.

>> Full patch follows...
>
> Do you want to take this patch through your tree?  If so, feel free to
> add:
>        Acked-by: Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org>

I'll take it through my tree.  I've got a lot of related patches that
it should be grouped with, and I'm going to defer it to the 2.6.35
merge window so that it can get some linux-next exposure.

> to the patch.
>
> If not, let me know and I'll take it through my tree.
>
> Glad to see this work coming along, nice job.

Thanks!

Cheers,
g.