Devicetree
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	kay.sievers-tD+1rO4QERM@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	gregkh-l3A5Bk7waGM@public.gmane.org
Subject: Re: [RFC] drivercore: Add of_match_table to the common device drivers
Date: Sun, 7 Mar 2010 00:19:47 -0700	[thread overview]
Message-ID: <fa686aa41003062319t33227670x1f0616cff887733b@mail.gmail.com> (raw)
In-Reply-To: <20100307180744.956998c5.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>

On Sun, Mar 7, 2010 at 12:07 AM, Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> wrote:
> Hi Grant,
>
> Just a quick note:
>
> On Sat, 06 Mar 2010 23:47:00 -0700 Grant Likely <grant.likely@secretlab.ca> wrote:
>>
>> diff --git a/drivers/macintosh/macio_asic.c b/drivers/macintosh/macio_asic.c
>> index 67fe13f..a5806ab 100644
>> --- a/drivers/macintosh/macio_asic.c
>> +++ b/drivers/macintosh/macio_asic.c
>> @@ -40,8 +40,7 @@ static struct macio_chip      *macio_on_hold;
>>  static int macio_bus_match(struct device *dev, struct device_driver *drv)
>>  {
>>       struct macio_dev * macio_dev = to_macio_device(dev);
>> -     struct macio_driver * macio_drv = to_macio_driver(drv);
>> -     const struct of_device_id * matches = macio_drv->match_table;
>> +     const struct of_device_id * matches = drv->match_table;
>                                                   ^^^^^^^^^^^
> of_match_table

Heh.  Oops.  I fixed that in my local directory when compile testing,
but neglected to refresh the patch.

Thanks,
g.

  parent reply	other threads:[~2010-03-07  7:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-07  6:47 [RFC] drivercore: Add of_match_table to the common device drivers Grant Likely
2010-03-07  7:07 ` Stephen Rothwell
     [not found]   ` <20100307180744.956998c5.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2010-03-07  7:19     ` Grant Likely [this message]
2010-03-07 18:05 ` Greg KH
2010-03-07 20:33   ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa686aa41003062319t33227670x1f0616cff887733b@mail.gmail.com \
    --to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=gregkh-l3A5Bk7waGM@public.gmane.org \
    --cc=kay.sievers-tD+1rO4QERM@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox