* [PATCH 1/2] dt-bindings: mfd: st,stpmic1: Add missing unevaluatedProperties for each regulator
@ 2023-07-25 12:37 Krzysztof Kozlowski
2023-07-25 12:37 ` [PATCH 2/2] dt-bindings: mfd: stericsson,db8500-prcmu: " Krzysztof Kozlowski
2023-07-25 14:45 ` [PATCH 1/2] dt-bindings: mfd: st,stpmic1: " Krzysztof Kozlowski
0 siblings, 2 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-25 12:37 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
pascal Paillet, Linus Walleij, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Each regulator node, which references common regulator.yaml schema,
should disallow additional or unevaluated properties. Otherwise
mistakes in properties will go unnoticed. unevaluatedProperties:false
requires listing existing properties (present in example and in other
regulators of this device).
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/mfd/st,stpmic1.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
index 97c61097f9e2..1a1ced489ef7 100644
--- a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
+++ b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
@@ -189,6 +189,16 @@ properties:
"^(buck[1-4]|ldo[1-6]|boost|vref_ddr|pwr_sw[1-2])$":
$ref: ../regulator/regulator.yaml
+ unevaluatedProperties: false
+
+ properties:
+ interrupts:
+ maxItems: 1
+
+ st,mask-reset:
+ description: mask reset for this regulator, the regulator configuration
+ is maintained during pmic reset.
+ $ref: /schemas/types.yaml#/definitions/flag
"^ldo[1-2,5-6]$":
type: object
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] dt-bindings: mfd: stericsson,db8500-prcmu: Add missing unevaluatedProperties for each regulator
2023-07-25 12:37 [PATCH 1/2] dt-bindings: mfd: st,stpmic1: Add missing unevaluatedProperties for each regulator Krzysztof Kozlowski
@ 2023-07-25 12:37 ` Krzysztof Kozlowski
2023-08-07 12:33 ` Linus Walleij
2023-07-25 14:45 ` [PATCH 1/2] dt-bindings: mfd: st,stpmic1: " Krzysztof Kozlowski
1 sibling, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-25 12:37 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
pascal Paillet, Linus Walleij, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Each regulator node, which references common regulator.yaml schema,
should disallow additional or unevaluated properties. Otherwise
mistakes in properties will go unnoticed.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/mfd/stericsson,db8500-prcmu.yaml | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/stericsson,db8500-prcmu.yaml b/Documentation/devicetree/bindings/mfd/stericsson,db8500-prcmu.yaml
index 1d4d88f7e82d..678a6c0fd7d6 100644
--- a/Documentation/devicetree/bindings/mfd/stericsson,db8500-prcmu.yaml
+++ b/Documentation/devicetree/bindings/mfd/stericsson,db8500-prcmu.yaml
@@ -72,44 +72,52 @@ properties:
main voltage domain for the chip.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
db8500_varm:
description: The voltage for the ARM Cortex A-9 CPU.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
db8500_vmodem:
description: The voltage for the modem subsystem.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
db8500_vpll:
description: The voltage for the phase locked loop clocks.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
db8500_vsmps1:
description: Also known as VIO12, is a step-down voltage regulator
for 1.2V I/O. SMPS means System Management Power Source.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
db8500_vsmps2:
description: Also known as VIO18, is a step-down voltage regulator
for 1.8V I/O. SMPS means System Management Power Source.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
db8500_vsmps3:
description: This is a step-down voltage regulator
for 0.87 thru 1.875V I/O. SMPS means System Management Power Source.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
db8500_vrf1:
description: RF transciever voltage regulator.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
db8500_sva_mmdsp:
description: Smart Video Accelerator (SVA) multimedia DSP (MMDSP)
@@ -117,18 +125,21 @@ properties:
for video encoding and decoding.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
db8500_sva_mmdsp_ret:
description: Smart Video Accelerator (SVA) multimedia DSP (MMDSP)
voltage regulator for retention mode.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
db8500_sva_pipe:
description: Smart Video Accelerator (SVA) multimedia DSP (MMDSP)
voltage regulator for the data pipe.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
db8500_sia_mmdsp:
description: Smart Image Accelerator (SIA) multimedia DSP (MMDSP)
@@ -136,18 +147,21 @@ properties:
for image encoding and decoding.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
db8500_sia_mmdsp_ret:
description: Smart Image Accelerator (SIA) multimedia DSP (MMDSP)
voltage regulator for retention mode.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
db8500_sia_pipe:
description: Smart Image Accelerator (SIA) multimedia DSP (MMDSP)
voltage regulator for the data pipe.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
db8500_sga:
description: Smart Graphics Accelerator (SGA) voltage regulator.
@@ -155,6 +169,7 @@ properties:
accelerator block.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
db8500_b2r2_mcde:
description: Blit Blend Rotate and Rescale (B2R2), and Multi-Channel
@@ -162,28 +177,33 @@ properties:
blocks.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
db8500_esram12:
description: Embedded Static RAM (ESRAM) 1 and 2 voltage regulator.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
db8500_esram12_ret:
description: Embedded Static RAM (ESRAM) 1 and 2 voltage regulator for
retention mode.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
db8500_esram34:
description: Embedded Static RAM (ESRAM) 3 and 4 voltage regulator.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
db8500_esram34_ret:
description: Embedded Static RAM (ESRAM) 3 and 4 voltage regulator for
retention mode.
type: object
$ref: ../regulator/regulator.yaml#
+ unevaluatedProperties: false
required:
- compatible
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mfd: st,stpmic1: Add missing unevaluatedProperties for each regulator
2023-07-25 12:37 [PATCH 1/2] dt-bindings: mfd: st,stpmic1: Add missing unevaluatedProperties for each regulator Krzysztof Kozlowski
2023-07-25 12:37 ` [PATCH 2/2] dt-bindings: mfd: stericsson,db8500-prcmu: " Krzysztof Kozlowski
@ 2023-07-25 14:45 ` Krzysztof Kozlowski
2023-08-17 11:52 ` Lee Jones
1 sibling, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-25 14:45 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
pascal Paillet, Linus Walleij, devicetree, linux-kernel
On 25/07/2023 14:37, Krzysztof Kozlowski wrote:
> Each regulator node, which references common regulator.yaml schema,
> should disallow additional or unevaluated properties. Otherwise
> mistakes in properties will go unnoticed. unevaluatedProperties:false
> requires listing existing properties (present in example and in other
> regulators of this device).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/mfd/st,stpmic1.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> index 97c61097f9e2..1a1ced489ef7 100644
> --- a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> +++ b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> @@ -189,6 +189,16 @@ properties:
>
> "^(buck[1-4]|ldo[1-6]|boost|vref_ddr|pwr_sw[1-2])$":
> $ref: ../regulator/regulator.yaml
> + unevaluatedProperties: false
> +
> + properties:
> + interrupts:
> + maxItems: 1
> +
> + st,mask-reset:
> + description: mask reset for this regulator, the regulator configuration
> + is maintained during pmic reset.
> + $ref: /schemas/types.yaml#/definitions/flag
After further testing I see this patch is wrong. There are already
buck[1-4] entries, so this is duplicating things. I will send v2.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt-bindings: mfd: stericsson,db8500-prcmu: Add missing unevaluatedProperties for each regulator
2023-07-25 12:37 ` [PATCH 2/2] dt-bindings: mfd: stericsson,db8500-prcmu: " Krzysztof Kozlowski
@ 2023-08-07 12:33 ` Linus Walleij
0 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2023-08-07 12:33 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
pascal Paillet, devicetree, linux-kernel
On Tue, Jul 25, 2023 at 2:37 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> Each regulator node, which references common regulator.yaml schema,
> should disallow additional or unevaluated properties. Otherwise
> mistakes in properties will go unnoticed.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thanks Krzysztof!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mfd: st,stpmic1: Add missing unevaluatedProperties for each regulator
2023-07-25 14:45 ` [PATCH 1/2] dt-bindings: mfd: st,stpmic1: " Krzysztof Kozlowski
@ 2023-08-17 11:52 ` Lee Jones
2023-08-18 9:00 ` Krzysztof Kozlowski
0 siblings, 1 reply; 7+ messages in thread
From: Lee Jones @ 2023-08-17 11:52 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, pascal Paillet,
Linus Walleij, devicetree, linux-kernel
On Tue, 25 Jul 2023, Krzysztof Kozlowski wrote:
> On 25/07/2023 14:37, Krzysztof Kozlowski wrote:
> > Each regulator node, which references common regulator.yaml schema,
> > should disallow additional or unevaluated properties. Otherwise
> > mistakes in properties will go unnoticed. unevaluatedProperties:false
> > requires listing existing properties (present in example and in other
> > regulators of this device).
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > Documentation/devicetree/bindings/mfd/st,stpmic1.yaml | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> > index 97c61097f9e2..1a1ced489ef7 100644
> > --- a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> > @@ -189,6 +189,16 @@ properties:
> >
> > "^(buck[1-4]|ldo[1-6]|boost|vref_ddr|pwr_sw[1-2])$":
> > $ref: ../regulator/regulator.yaml
> > + unevaluatedProperties: false
> > +
> > + properties:
> > + interrupts:
> > + maxItems: 1
> > +
> > + st,mask-reset:
> > + description: mask reset for this regulator, the regulator configuration
> > + is maintained during pmic reset.
> > + $ref: /schemas/types.yaml#/definitions/flag
>
> After further testing I see this patch is wrong. There are already
> buck[1-4] entries, so this is duplicating things. I will send v2.
Are you still planning on resending this set?
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mfd: st,stpmic1: Add missing unevaluatedProperties for each regulator
2023-08-17 11:52 ` Lee Jones
@ 2023-08-18 9:00 ` Krzysztof Kozlowski
2023-08-18 15:37 ` Lee Jones
0 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-08-18 9:00 UTC (permalink / raw)
To: Lee Jones
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, pascal Paillet,
Linus Walleij, devicetree, linux-kernel
On 17/08/2023 13:52, Lee Jones wrote:
> On Tue, 25 Jul 2023, Krzysztof Kozlowski wrote:
>
>> On 25/07/2023 14:37, Krzysztof Kozlowski wrote:
>>> Each regulator node, which references common regulator.yaml schema,
>>> should disallow additional or unevaluated properties. Otherwise
>>> mistakes in properties will go unnoticed. unevaluatedProperties:false
>>> requires listing existing properties (present in example and in other
>>> regulators of this device).
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>>> Documentation/devicetree/bindings/mfd/st,stpmic1.yaml | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
>>> index 97c61097f9e2..1a1ced489ef7 100644
>>> --- a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
>>> +++ b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
>>> @@ -189,6 +189,16 @@ properties:
>>>
>>> "^(buck[1-4]|ldo[1-6]|boost|vref_ddr|pwr_sw[1-2])$":
>>> $ref: ../regulator/regulator.yaml
>>> + unevaluatedProperties: false
>>> +
>>> + properties:
>>> + interrupts:
>>> + maxItems: 1
>>> +
>>> + st,mask-reset:
>>> + description: mask reset for this regulator, the regulator configuration
>>> + is maintained during pmic reset.
>>> + $ref: /schemas/types.yaml#/definitions/flag
>>
>> After further testing I see this patch is wrong. There are already
>> buck[1-4] entries, so this is duplicating things. I will send v2.
>
> Are you still planning on resending this set?
>
I already did and you took it. Email subject was different, though:
https://lore.kernel.org/all/20230726065633.74924-1-krzysztof.kozlowski@linaro.org/
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mfd: st,stpmic1: Add missing unevaluatedProperties for each regulator
2023-08-18 9:00 ` Krzysztof Kozlowski
@ 2023-08-18 15:37 ` Lee Jones
0 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2023-08-18 15:37 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, pascal Paillet,
Linus Walleij, devicetree, linux-kernel
On Fri, 18 Aug 2023, Krzysztof Kozlowski wrote:
> On 17/08/2023 13:52, Lee Jones wrote:
> > On Tue, 25 Jul 2023, Krzysztof Kozlowski wrote:
> >
> >> On 25/07/2023 14:37, Krzysztof Kozlowski wrote:
> >>> Each regulator node, which references common regulator.yaml schema,
> >>> should disallow additional or unevaluated properties. Otherwise
> >>> mistakes in properties will go unnoticed. unevaluatedProperties:false
> >>> requires listing existing properties (present in example and in other
> >>> regulators of this device).
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>> ---
> >>> Documentation/devicetree/bindings/mfd/st,stpmic1.yaml | 10 ++++++++++
> >>> 1 file changed, 10 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> >>> index 97c61097f9e2..1a1ced489ef7 100644
> >>> --- a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> >>> +++ b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> >>> @@ -189,6 +189,16 @@ properties:
> >>>
> >>> "^(buck[1-4]|ldo[1-6]|boost|vref_ddr|pwr_sw[1-2])$":
> >>> $ref: ../regulator/regulator.yaml
> >>> + unevaluatedProperties: false
> >>> +
> >>> + properties:
> >>> + interrupts:
> >>> + maxItems: 1
> >>> +
> >>> + st,mask-reset:
> >>> + description: mask reset for this regulator, the regulator configuration
> >>> + is maintained during pmic reset.
> >>> + $ref: /schemas/types.yaml#/definitions/flag
> >>
> >> After further testing I see this patch is wrong. There are already
> >> buck[1-4] entries, so this is duplicating things. I will send v2.
> >
> > Are you still planning on resending this set?
> >
>
> I already did and you took it. Email subject was different, though:
Understood, thanks for the clarification.
> https://lore.kernel.org/all/20230726065633.74924-1-krzysztof.kozlowski@linaro.org/
> Best regards,
> Krzysztof
>
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-08-18 15:38 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-25 12:37 [PATCH 1/2] dt-bindings: mfd: st,stpmic1: Add missing unevaluatedProperties for each regulator Krzysztof Kozlowski
2023-07-25 12:37 ` [PATCH 2/2] dt-bindings: mfd: stericsson,db8500-prcmu: " Krzysztof Kozlowski
2023-08-07 12:33 ` Linus Walleij
2023-07-25 14:45 ` [PATCH 1/2] dt-bindings: mfd: st,stpmic1: " Krzysztof Kozlowski
2023-08-17 11:52 ` Lee Jones
2023-08-18 9:00 ` Krzysztof Kozlowski
2023-08-18 15:37 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).