From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD85824676D; Wed, 24 Jun 2026 10:26:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782296774; cv=none; b=oMF6wnktG/7IZwzzwMQuAVpWoJSlK4vpK3MewDiyVfLvmFvWjfxa0WLXd36YXdRwbatRBqoG6oZZewOyTBWTuJcl4zOTd3kPaiTUiHlXvXdbcUPnb/GIzb4MM5PnSI7JUGmoYgWXS3t308uCe6b9oOV3jaZFjx1V+sMeXMMRXl8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782296774; c=relaxed/simple; bh=8rqPP+vIyOO1uVBM6GZxnLbtBV6xOwlVm/DmE3wv8j0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Tyx5JysLODxOerkNzQMNXZgY9i16YK4gTXVtxeNp5Z7Jxnge2B04nVTbhZFlZmydr3L+HsKWZeBaIyPTjWdNlks/R11aQN7FSP6yHQ8M4D3dyg5WjUnO8KYJ3umEy38k/fc4tXjyuFLFM0N8KFWZHm3rKS6Fs0gmAdmMJWgsmH0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nyrANdJr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nyrANdJr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C4761F000E9; Wed, 24 Jun 2026 10:26:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782296773; bh=d6dSqP7+9HfeftxoKwcSkOB2oFakt68S5OEzi8o7PlM=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=nyrANdJre0u1PhoITuQj0aNy6isibcCVRgiX7PcfwPwSHLZo+upMPk/BrtDawAW4T 2P2CecpBgejXZrQ2v1e6bXAkNY/Q8KDi1q+wq6+uLczz7kpoFwAJfRcIa2Y2hybTRZ ssVtIqlpBu2OAYDm6Zb/YmKetjgGWS5Hg++JDHRwBFAx/lsU+IJrNW1MPsyXQoGIWV KV5voB5L4Ho1yKm17HNbAP4tonWdcOVzESHQ6M/+y4zXc4vCnQNgo6dIb0gcbFb5yw sWCjj6CUfuBXN0AmCm2LoMdYYKGgxrj93BEPir3AR+eJLGK8uYDeRhUzUARME2GvDd MIxRmMDXAUG7g== Message-ID: Date: Wed, 24 Jun 2026 12:26:08 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: socfpga: agilex7-gen2: Add initial device tree To: "Nazle Asmade, Muhammad Nazim Amirul" Cc: "dinguyen@kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20260623111716.16690-1-muhammad.nazim.amirul.nazle.asmade@altera.com> <20260623111716.16690-3-muhammad.nazim.amirul.nazle.asmade@altera.com> <20260624-infallible-diligent-bulldog-bcbab2@quoll> <4acdd3ee-c7eb-4871-bb59-c2e3eeedda28@altera.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <4acdd3ee-c7eb-4871-bb59-c2e3eeedda28@altera.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 24/06/2026 12:17, Nazle Asmade, Muhammad Nazim Amirul wrote: >> SoC without any interface, serial or storage or network, is close to >> useless one. >> >> I don't see a point in having it in mainline. Serial is usually ABSOLUTE >> minimum. >> >> Best regards, >> Krzysztof >> > Hi Krzysztof, > > Thank you for the review and fast response! > > I ran both dt_binding_check and dtbs_check (with CHECK_DTBS=y) locally — > both passed without errors. Could you clarify which specific test you > believe is failing? I would expect simple-bus schema warning or W=1, because node is placed outside of soc@, but maybe there is no such. > > Regarding "MMIO goes to MMIO" — are you referring to the GIC Comments are placed in very specific and intentional place. Please read guides how mailing list in-line review works before posting patches. > (interrupt-controller@7000000) being placed at the root level instead of > under the soc bus node? > > Regarding the serial console — the platform clock driver is not yet > upstream, so the UART depends on clkmgr. Would adding the UART with > clock-frequency be acceptable as an interim solution? Add complete working serial. Why can't you use fixed placeholder clock? There are probably multiple ways to solve it, not necessary clock-frequency and I do not even remember if clock-frequency is allowed. But if you cannot bring serial, then my comment stays valid: this is unusable upstream thus is not ready to be posted and merged. Best regards, Krzysztof