From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [PATCH v3 1/3] arm64: dts: exynos5433: add DECON_TV node Date: Wed, 11 Jan 2017 09:07:52 +0100 Message-ID: References: <1484036664-15951-1-git-send-email-a.hajda@samsung.com> <20170110171114.unajua37bbosxuey@kozik-lap> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20170110171114.unajua37bbosxuey@kozik-lap> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Krzysztof Kozlowski Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Bartlomiej Zolnierkiewicz , Marek Szyprowski , Inki Dae , Rob Herring , Mark Rutland , Javier Martinez Canillas , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andi Shyti , Chanwoo Choi List-Id: devicetree@vger.kernel.org On 10.01.2017 18:11, Krzysztof Kozlowski wrote: > On Tue, Jan 10, 2017 at 09:24:22AM +0100, Andrzej Hajda wrote: >> DECON_TV is 2nd display controller on Exynos5433, used in HDMI path >> or 2nd DSI path. >> >> Signed-off-by: Andrzej Hajda >> Reviewed-by: Javier Martinez Canillas >> Reviewed-by: Chanwoo Choi >> Tested-by: Hoegeun Kwon >> --- >> >> Hi Krzysztof, >> >> These patches are based on latest patches separating tm2 and tm2e and >> touchscreen patches. I hope this is good base. >> Thanks all for quick response/review. >> > Thanks for fixing the issues. Also thank you for trying to fix the > subject. However this is not a full fix. Please run: > $ git log --oneline arch/arm64/boot/dts/exynos/ > > Why I am asking about this? I am trying to have it consistent so > going through history would be easier. Of course we might discuss what > prefix should be used. Some other platforms use "arm64: dts: > architecture:", some use "arm64: dts: specific_chip_family:". For exynos > we are trying to keep it just "exynos". Anyway regardless of the chosen > prefix itself, after choosing some pattern, the consistency helps. > > When people keep sending patches with wrong title, then after every > git-am I have to amend the commit and fix it. It is not difficult but > annoying. > > Actually before I did not complain about it... but recently (this cycle) > a lot of Samsung folks are sending wrong subjects. Weird. I agree that consistency is good, so next time maybe it would be better to just simply write which prefix to use, instead of advising to dig into samsung-soc for help :) > > So just use the command and look at history. Good point. Regards Andrzej -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html