From: Patrice CHOTARD <patrice.chotard@st.com>
To: Alexandre TORGUE <alexandre.torgue@st.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"lee.jones@linaro.org" <lee.jones@linaro.org>
Cc: "mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>
Subject: Re: [PATCH 1/6] ARM: dts: stm32: Add sdio pins definition for stm32f7
Date: Thu, 1 Mar 2018 10:17:39 +0000 [thread overview]
Message-ID: <fa85e4c1-c646-ae4d-bdb2-0a9b757f19d0@st.com> (raw)
In-Reply-To: <1e73394f-2410-1d2a-a450-d3f1c88d1ca2@st.com>
Hi Alex
On 03/01/2018 10:51 AM, Alexandre Torgue wrote:
> Hi Patrice
>
> On 03/01/2018 10:43 AM, patrice.chotard@st.com wrote:
>> From: Patrice Chotard <patrice.chotard@st.com>
>>
>> Add sdio pins definition for the 2 sdio instances embeds in stm32f746.
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
>> ---
>> arch/arm/boot/dts/stm32f7-pinctrl.dtsi | 62
>> ++++++++++++++++++++++++++++++++++
>> 1 file changed, 62 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
>> b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
>> index f518de184e52..fb40f0835dd4 100644
>> --- a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
>> +++ b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
>> @@ -222,6 +222,68 @@
>> slew-rate = <2>;
>> };
>> };
>> +
>> + sdio_pins: sdio_pins@0 {
>> + pins {
>> + pinmux = <STM32_PINMUX('C', 8, AF12)>, /* SDMMC1
>> D0 */
>> + <STM32_PINMUX('C', 9, AF12)>, /* SDMMC1 D1 */
>> + <STM32_PINMUX('C', 10, AF12)>, /* SDMMC1 D2 */
>> + <STM32_PINMUX('C', 11, AF12)>, /* SDMMC1 D3 */
>> + <STM32_PINMUX('C', 12, AF12)>, /* SDMMC1 CLK */
>> + <STM32_PINMUX('D', 2, AF12)>; /* SDMMC1 CMD */
>> + drive-push-pull;
>> + slew-rate = <2>;
>> + };
>> + };
>
> if you have 2 pins groups, please use '_a' for the first one. You could
> have something like:
>
> sdio_pins_a
> sdio_od_pins_a
>
> and
>
> sdio_pins_b
> sdio_od_pins_b
Ok, i prepare a v2
Thanks
Patrice
>
>> + sdio_pins_od: sdio_pins_od@0 {
>> + pins1 {
>> + pinmux = <STM32_PINMUX('C', 8, AF12)>, /* SDMMC1
>> D0 */
>> + <STM32_PINMUX('C', 9, AF12)>, /* SDMMC1 D1 */
>> + <STM32_PINMUX('C', 10, AF12)>, /* SDMMC1 D2 */
>> + <STM32_PINMUX('C', 11, AF12)>, /* SDMMC1 D3 */
>> + <STM32_PINMUX('C', 12, AF12)>; /* SDMMC1 CLK */
>> + drive-push-pull;
>> + slew-rate = <2>;
>> + };
>> +
>> + pins2 {
>> + pinmux = <STM32_PINMUX('D', 2, AF12)>; /* SDMMC1
>> CMD */
>> + drive-open-drain;
>> + slew-rate = <2>;
>> + };
>> + };
>> +
>> + sdio_pins_b: sdio_pins_b@0 {
>> + pins {
>> + pinmux = <STM32_PINMUX('G', 9, AF11)>, /* SDMMC2
>> D0 */
>> + <STM32_PINMUX('G', 10, AF11)>, /* SDMMC2 D1 */
>> + <STM32_PINMUX('B', 3, AF10)>, /* SDMMC2 D2 */
>> + <STM32_PINMUX('B', 4, AF10)>, /* SDMMC2 D3 */
>> + <STM32_PINMUX('D', 6, AF11)>, /* SDMMC2 CLK */
>> + <STM32_PINMUX('D', 7, AF11)>; /* SDMMC2 CMD */
>> + drive-push-pull;
>> + slew-rate = <2>;
>> + };
>> + };
>> +
>> + sdio_pins_od_b: sdio_pins_od_b@0 {
>> + pins1 {
>> + pinmux = <STM32_PINMUX('G', 9, AF11)>, /* SDMMC2
>> D0 */
>> + <STM32_PINMUX('G', 10, AF11)>, /* SDMMC2 D1 */
>> + <STM32_PINMUX('B', 3, AF10)>, /* SDMMC2 D2 */
>> + <STM32_PINMUX('B', 4, AF10)>, /* SDMMC2 D3 */
>> + <STM32_PINMUX('D', 6, AF11)>; /* SDMMC2 CLK */
>> + drive-push-pull;
>> + slew-rate = <2>;
>> + };
>> +
>> + pins2 {
>> + pinmux = <STM32_PINMUX('D', 7, AF11)>; /* SDMMC2
>> CMD */
>> + drive-open-drain;
>> + slew-rate = <2>;
>> + };
>> + };
>> };
>> };
>> };
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-03-01 10:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 9:43 [PATCH 0/6] Add mmc support for STM32F7 boards patrice.chotard
2018-03-01 9:43 ` [PATCH 1/6] ARM: dts: stm32: Add sdio pins definition for stm32f7 patrice.chotard
2018-03-01 9:51 ` Alexandre Torgue
2018-03-01 10:17 ` Patrice CHOTARD [this message]
2018-03-01 9:43 ` [PATCH 2/6] ARM: dts: stm32: Enable sdio1 for stm32f746-disco patrice.chotard
2018-03-01 9:43 ` [PATCH 3/6] ARM: dts: stm32: Enable sdio1 for stm32f746-eval patrice.chotard
2018-03-01 9:43 ` [PATCH 4/6] ARM: dts: stm32: Enable sdio1 for stm32f769-disco patrice.chotard
2018-03-01 9:43 ` [PATCH 5/6] dt-bindings: mfd: Add STM32F7 SDMMC2 rcc entry patrice.chotard
2018-03-01 9:43 ` [PATCH 6/6] ARM: dts: stm32: Fix sdio2 rcc hard coded value patrice.chotard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa85e4c1-c646-ae4d-bdb2-0a9b757f19d0@st.com \
--to=patrice.chotard@st.com \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).