From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Amit Kucheria <amitk@kernel.org>,
Thara Gopinath <thara.gopinath@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Zhang Rui <rui.zhang@intel.com>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 07/20] thermal/drivers/tsens: limit num_sensors to 9
Date: Wed, 21 Dec 2022 20:05:20 +0200 [thread overview]
Message-ID: <fa89bec4-0f44-74a5-4905-c1e03ad52749@linaro.org> (raw)
In-Reply-To: <ed4aafb9-c33e-6f24-1e9c-7c7efa0e58ae@linaro.org>
On 21/12/2022 17:45, Daniel Lezcano wrote:
> On 21/12/2022 03:05, Dmitry Baryshkov wrote:
>> According to the vendor kernels (msm-3.10, 3.14 and 3.18), msm8939
>> supports only 9 sensors. Remove the rogue sensor's hw_id.
>>
>> Fixes: 332bc8ebab2c ("thermal: qcom: tsens-v0_1: Add support for
>> MSM8939")
>> Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>> drivers/thermal/qcom/tsens-v0_1.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/thermal/qcom/tsens-v0_1.c
>> b/drivers/thermal/qcom/tsens-v0_1.c
>> index 0bc4e5cec184..57ac23f9d9b7 100644
>> --- a/drivers/thermal/qcom/tsens-v0_1.c
>> +++ b/drivers/thermal/qcom/tsens-v0_1.c
>> @@ -605,9 +605,9 @@ static const struct tsens_ops ops_8939 = {
>> };
>> struct tsens_plat_data data_8939 = {
>> - .num_sensors = 10,
>> + .num_sensors = 9,
>> .ops = &ops_8939,
>> - .hw_ids = (unsigned int []){ 0, 1, 2, 3, 5, 6, 7, 8, 9, 10 },
>> + .hw_ids = (unsigned int []){ 0, 1, 2, 3, 5, 6, 7, 8, 9 },
>
> Does not patch 4 says we can drop those hw_ids ?
No. In patch 4 we drop contiguous IDs. For the msm8939 sensor 4 is
omitted from hw_ids, so we can not drop the array.
>
>> .feat = &tsens_v0_1_feat,
>> .fields = tsens_v0_1_regfields,
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2022-12-21 18:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 2:05 [PATCH v4 00/15] thermal/drivers/tsens: specify nvmem cells in DT rather than parsing them manually Dmitry Baryshkov
2022-12-21 2:05 ` [PATCH v4 01/20] dt-bindings: thermal: tsens: add msm8956 compat Dmitry Baryshkov
2022-12-21 2:05 ` [PATCH v4 02/20] dt-bindings: thermal: tsens: support per-sensor calibration cells Dmitry Baryshkov
2022-12-21 2:05 ` [PATCH v4 03/20] dt-bindings: thermal: tsens: add per-sensor cells for msm8974 Dmitry Baryshkov
2022-12-21 2:05 ` [PATCH v4 04/20] thermal/drivers/tsens: Drop unnecessary hw_ids Dmitry Baryshkov
2022-12-21 2:05 ` [PATCH v4 05/20] thermal/drivers/tsens: Drop msm8976-specific defines Dmitry Baryshkov
2022-12-21 2:05 ` [PATCH v4 06/20] thermal/drivers/tsens: Sort out msm8976 vs msm8956 data Dmitry Baryshkov
2022-12-21 2:05 ` [PATCH v4 07/20] thermal/drivers/tsens: limit num_sensors to 9 Dmitry Baryshkov
2022-12-21 15:45 ` Daniel Lezcano
2022-12-21 18:05 ` Dmitry Baryshkov [this message]
2022-12-21 18:15 ` Daniel Lezcano
2022-12-21 19:42 ` Dmitry Baryshkov
2022-12-21 20:13 ` Konrad Dybcio
2022-12-21 2:05 ` [PATCH v4 08/20] thermal/drivers/tsens: fix slope values for msm8939 Dmitry Baryshkov
2022-12-21 20:14 ` Konrad Dybcio
2022-12-21 2:05 ` [PATCH v4 09/20] thermal/drivers/tsens: Support using nvmem cells for calibration data Dmitry Baryshkov
2022-12-21 2:05 ` [PATCH v4 10/20] thermal/drivers/tsens: Support using nvmem cells for msm8974 calibration Dmitry Baryshkov
2022-12-21 2:05 ` [PATCH v4 11/20] thermal/drivers/tsens: Rework legacy calibration data parsers Dmitry Baryshkov
2022-12-21 14:08 ` kernel test robot
2022-12-21 2:05 ` [PATCH v4 12/20] thermal/drivers/tsens: Drop single-cell code for mdm9607 Dmitry Baryshkov
2022-12-21 2:05 ` [PATCH v4 13/20] thermal/drivers/tsens: Drop single-cell code for msm8939 Dmitry Baryshkov
2022-12-21 2:05 ` [PATCH v4 14/20] thermal/drivers/tsens: Drop single-cell code for msm8976/msm8956 Dmitry Baryshkov
2022-12-21 2:05 ` [PATCH v4 15/20] arm64: dts: qcom: msm8956: use SoC-specific compat for tsens Dmitry Baryshkov
2022-12-21 20:15 ` Konrad Dybcio
2022-12-21 2:05 ` [PATCH v4 16/20] arm64: dts: qcom: msm8916: specify per-sensor calibration cells Dmitry Baryshkov
2022-12-21 2:05 ` [PATCH v4 17/20] arm64: dts: qcom: msm8976: " Dmitry Baryshkov
2022-12-21 2:05 ` [PATCH v4 18/20] arm64: dts: qcom: qcs404: " Dmitry Baryshkov
2022-12-21 2:05 ` [PATCH v4 19/20] ARM: dts: qcom-msm8974: " Dmitry Baryshkov
2022-12-21 2:05 ` [PATCH v4 20/20] ARM: dts: qcom-apq8084: " Dmitry Baryshkov
2022-12-21 15:37 ` [PATCH v4 00/15] thermal/drivers/tsens: specify nvmem cells in DT rather than parsing them manually Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa89bec4-0f44-74a5-4905-c1e03ad52749@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).