From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECA2EC4167B for ; Wed, 21 Dec 2022 18:05:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229491AbiLUSFb (ORCPT ); Wed, 21 Dec 2022 13:05:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234459AbiLUSF2 (ORCPT ); Wed, 21 Dec 2022 13:05:28 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C513A1013 for ; Wed, 21 Dec 2022 10:05:23 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id b3so24722352lfv.2 for ; Wed, 21 Dec 2022 10:05:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BdUKqQdUJ9BjsYRaWfnbLXsCaSmLmYgfTiT0Q4Ua3+E=; b=CUWV9mGuK791sSjb2COGW35hA9di7EVG+FUHGHXP4Esmfg2gW4e/gmlt6CskwMZ+VR KQEA9YsWxRZZ2JszDe7H3kLNkz16FvtfOJ2h9BdhVVYIHiIAn4gUnJgKEYW79umUyp15 HRnfirX/ZAfJuiXKw1Gq1T+/UPbljCrByj0vTwDbvNTP9EOpSOUV+ARNalBcZJG79a4A /odwo6HPpk8FjxXKL/s3+AEvbQ8SmOnjczQRLdesXpp++NGIu8ggDN54GnxbDWNDcYf7 pG5gcygw/fqmOTVyeg6dTZlwoSQ01mCEAQ+vMNXtG7eDA2MH8I1C3iniX0CJxZ0BtY2m Ryeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BdUKqQdUJ9BjsYRaWfnbLXsCaSmLmYgfTiT0Q4Ua3+E=; b=Jo2rJITTBMCVMNCj2uJdkze3uJTnCEgMwMk11jkM8OfytOCbbYYfrsV4Ek/FU/rs1M NrXXzfdFH1ViY4l26i1pG+3kuBXCt/goyRJdW2P1MqdRQMBFP5jANbeuQ4KxDPnrHI8Z 8F7UKwwAf7KQQY534jjFDchgBkZJXG5K86TVGRbrFezRaYFx7IGjSRF7DwiWUyNk1tsD EE3HedMdYjzryX35eevnDaQgbgC5nsUD49j4x9Zm222lUoP5mBkMYMW1kuxE57T93AMD FGDqciDMezneehATMsjWC9VbxriEYdq8jT2i+ALq7E6SpXzTqk0zTZWNjbU5+DJ1dTvB GivQ== X-Gm-Message-State: AFqh2krPFGsnw6BaWzIn+d5ZZ+SlpPiPYoJWdOMsmLLkm2jmCx1HbPgy Lo7ufOvEdKIBVCupYfnew7rSpg== X-Google-Smtp-Source: AMrXdXuKqHHQ6aeZ4qA8dLUxIScs9CMToBtEgctg0p94BmcwngeQYaUmp1MWoetE4bVhbI1psXJDrw== X-Received: by 2002:a05:6512:ba5:b0:4c0:91d0:e7b7 with SMTP id b37-20020a0565120ba500b004c091d0e7b7mr1286237lfv.27.1671645922080; Wed, 21 Dec 2022 10:05:22 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id b19-20020ac25633000000b004b551505c29sm1907221lff.218.2022.12.21.10.05.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Dec 2022 10:05:21 -0800 (PST) Message-ID: Date: Wed, 21 Dec 2022 20:05:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v4 07/20] thermal/drivers/tsens: limit num_sensors to 9 Content-Language: en-GB To: Daniel Lezcano , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Zhang Rui Cc: Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org References: <20221221020520.1326964-1-dmitry.baryshkov@linaro.org> <20221221020520.1326964-8-dmitry.baryshkov@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/12/2022 17:45, Daniel Lezcano wrote: > On 21/12/2022 03:05, Dmitry Baryshkov wrote: >> According to the vendor kernels (msm-3.10, 3.14 and 3.18), msm8939 >> supports only 9 sensors. Remove the rogue sensor's hw_id. >> >> Fixes: 332bc8ebab2c ("thermal: qcom: tsens-v0_1: Add support for >> MSM8939") >> Cc: Bryan O'Donoghue >> Signed-off-by: Dmitry Baryshkov >> --- >>   drivers/thermal/qcom/tsens-v0_1.c | 4 ++-- >>   1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/thermal/qcom/tsens-v0_1.c >> b/drivers/thermal/qcom/tsens-v0_1.c >> index 0bc4e5cec184..57ac23f9d9b7 100644 >> --- a/drivers/thermal/qcom/tsens-v0_1.c >> +++ b/drivers/thermal/qcom/tsens-v0_1.c >> @@ -605,9 +605,9 @@ static const struct tsens_ops ops_8939 = { >>   }; >>   struct tsens_plat_data data_8939 = { >> -    .num_sensors    = 10, >> +    .num_sensors    = 9, >>       .ops        = &ops_8939, >> -    .hw_ids        = (unsigned int []){ 0, 1, 2, 3, 5, 6, 7, 8, 9, 10 }, >> +    .hw_ids        = (unsigned int []){ 0, 1, 2, 3, 5, 6, 7, 8, 9 }, > > Does not patch 4 says we can drop those hw_ids ? No. In patch 4 we drop contiguous IDs. For the msm8939 sensor 4 is omitted from hw_ids, so we can not drop the array. > >>       .feat        = &tsens_v0_1_feat, >>       .fields    = tsens_v0_1_regfields, > -- With best wishes Dmitry