From: Andrew Lunn <andrew@lunn.ch>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: Sander Vanheule <sander@svanheule.net>,
lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
tsbogend@alpha.franken.de, hkallweit1@gmail.com,
linux@armlinux.org.uk, markus.stockhausen@gmx.de,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH v4 4/4] net: mdio: Add RTL9300 MDIO driver
Date: Wed, 22 Jan 2025 22:47:38 +0100 [thread overview]
Message-ID: <faa4cf6e-40eb-4509-b3f0-198a9a45ccbd@lunn.ch> (raw)
In-Reply-To: <63d6cf16-9581-4736-8592-bc5836fa51af@alliedtelesis.co.nz>
> I believe the POLL_SEL configuration actually affects an internal port
> polling unit. From the datasheets I have it seems pretty configurable, you
> can tell it which phy registers to poll and what values indicate link
> up/down (the defaults are conveniently setup to match the Realtek PHYs).
You need to disable this. The linux PHY driver is driving the PHY, and
the hardware has no idea what Linux is doing. Say the driver has
changed the page to read a temperature sensor, when the switch does a
poll. Rather than reading the link status, it gets some random value
from the page containing the temperature sensor.
Andrew
next prev parent reply other threads:[~2025-01-22 21:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 4:02 [PATCH v4 0/4] RTL9300 MDIO driver Chris Packham
2025-01-20 4:02 ` [PATCH v4 1/4] dt-bindings: net: Add Realtek MDIO controller Chris Packham
2025-01-22 8:12 ` Krzysztof Kozlowski
2025-01-23 20:45 ` Chris Packham
2025-01-23 22:08 ` Andrew Lunn
2025-01-23 23:40 ` Chris Packham
2025-01-20 4:02 ` [PATCH v4 2/4] dt-bindings: mfd: Add MDIO interface to rtl9301-switch Chris Packham
2025-01-22 8:14 ` Krzysztof Kozlowski
2025-01-22 20:53 ` Chris Packham
2025-01-31 7:26 ` Krzysztof Kozlowski
2025-01-20 4:02 ` [PATCH v4 3/4] mips: dts: realtek: Add MDIO controller Chris Packham
2025-01-20 4:02 ` [PATCH v4 4/4] net: mdio: Add RTL9300 MDIO driver Chris Packham
2025-01-20 10:28 ` Sander Vanheule
2025-01-20 20:32 ` Chris Packham
2025-01-22 21:47 ` Andrew Lunn [this message]
2025-01-22 23:02 ` Chris Packham
2025-01-23 3:41 ` Andrew Lunn
2025-01-23 3:47 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faa4cf6e-40eb-4509-b3f0-198a9a45ccbd@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=markus.stockhausen@gmx.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sander@svanheule.net \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox