From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22F9FC77B75 for ; Mon, 8 May 2023 08:38:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232416AbjEHIiy (ORCPT ); Mon, 8 May 2023 04:38:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232273AbjEHIix (ORCPT ); Mon, 8 May 2023 04:38:53 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F33CF1162B for ; Mon, 8 May 2023 01:38:51 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-4f14468ef54so4822615e87.0 for ; Mon, 08 May 2023 01:38:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683535130; x=1686127130; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7M+LYvpo0uL6DRxOtraYhuPAgoiRvl+qFGnzZSo79f4=; b=w3GXeMtyzwuRY7sysKSaMD++ZLTRpHQQAxAhiRO+cBGtPVZwBPcfj+CVxdPugtuHtj e0jGozykIPHw5c9oZwVLX8uwlyUdbj2k8HVOcEaKtDonm73JFiFk0vOZ5QpvC/lbEJjZ gNw9+uexlJCgR0LjtLiJy4hcGh2PNmrb91VcwpuP4LKMNMiJTjIdEVIOKJMm7Ah7Vdva UZ0Ukpm0CB3oJ9RMa82eQ8RCq4FLpyjPIy6iF6bXapEF92JcVGEFZY9jpyX5pJVij2h1 bwcvGE7KevjjBG1wbaIWnL4K4Hh7bdXdH499QfbJ0qKzJFa/P2oOJye7I9Y1IMX46t/m 3GCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683535130; x=1686127130; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7M+LYvpo0uL6DRxOtraYhuPAgoiRvl+qFGnzZSo79f4=; b=bCuMO0rVIQUDgwYA1AYD4eGB0V0vKPy+osIb45XzCYHMDYBcV94AFJ0kUgIwOkkFOX OWdKqY4zlz6vdfSPtVecj9Q3Xe6lRtLyuB9OK1XRsF/JzNaOqEFtdfjWQ3fMCupAn5kc bYo3QGbodUEDFvqQ5TmZ+y3RxzF6ABR5bU1ZNmboPbRFo3toYTb1EAEaijYCPenopBVT rbIazAlKOISxUDAZDrrfQSUHgTrgsfH1t54mtoT5Q/sieqp4tSy0TfV5JM5XjszMLY4c 8e51ZpxjKLEsqlFw2tGxIJ49Eqm2odOZJ0nybeOKhnOTU4Zp1xdGd7MdlY6EuQqzfbq1 TDBA== X-Gm-Message-State: AC+VfDzS5/E/4RSBMgGPe3DPOgtzKJ1436Eugl8UHZ+IBdcX3EMK/EUt VkSYxm8iHQWUowxQe014bP9i4Q== X-Google-Smtp-Source: ACHHUZ7BOe90sL4z+719tAJbqmfFOlSnY6F/doGifg/JqPAqaNHcSKmqP/u6JkByUE0L1pZ0R1Ag1g== X-Received: by 2002:ac2:52a9:0:b0:4f1:4602:fb63 with SMTP id r9-20020ac252a9000000b004f14602fb63mr2201009lfm.41.1683535130246; Mon, 08 May 2023 01:38:50 -0700 (PDT) Received: from [192.168.1.101] (abyl248.neoplus.adsl.tpnet.pl. [83.9.31.248]) by smtp.gmail.com with ESMTPSA id c5-20020a05651221a500b004f143c11cbcsm1227074lft.51.2023.05.08.01.38.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 May 2023 01:38:49 -0700 (PDT) Message-ID: Date: Mon, 8 May 2023 10:38:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 03/12] dt-bindings: display/msm: sc7180-dpu: Describe SM6350 and SM6375 Content-Language: en-US To: Krzysztof Kozlowski , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Krishna Manikandan , Will Deacon , Robin Murphy , Joerg Roedel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev References: <20230411-topic-straitlagoon_mdss-v3-0-9837d6b3516d@linaro.org> <20230411-topic-straitlagoon_mdss-v3-3-9837d6b3516d@linaro.org> <31147c6d-e77a-8abd-0b55-73ead2385bb9@linaro.org> From: Konrad Dybcio In-Reply-To: <31147c6d-e77a-8abd-0b55-73ead2385bb9@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 7.05.2023 10:14, Krzysztof Kozlowski wrote: > On 05/05/2023 23:40, Konrad Dybcio wrote: >> SC7180, SM6350 and SM6375 use a rather similar hw setup for DPU, with >> the main exception being that the last one requires an additional >> throttle clock. >> >> It is not well understood yet, but failing to toggle it on makes the >> display hardware stall and not output any frames. >> >> Document SM6350 and SM6375 DPU. >> >> Signed-off-by: Konrad Dybcio >> --- >> .../bindings/display/msm/qcom,sc7180-dpu.yaml | 23 +++++++++++++++++++++- >> 1 file changed, 22 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-dpu.yaml >> index 1fb8321d9ee8..630b11480496 100644 >> --- a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-dpu.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-dpu.yaml >> @@ -13,7 +13,10 @@ $ref: /schemas/display/msm/dpu-common.yaml# >> >> properties: >> compatible: >> - const: qcom,sc7180-dpu >> + enum: >> + - qcom,sc7180-dpu >> + - qcom,sm6350-dpu >> + - qcom,sm6375-dpu >> >> reg: >> items: >> @@ -26,6 +29,7 @@ properties: >> - const: vbif >> >> clocks: >> + minItems: 6 >> items: >> - description: Display hf axi clock >> - description: Display ahb clock >> @@ -33,8 +37,10 @@ properties: >> - description: Display lut clock >> - description: Display core clock >> - description: Display vsync clock >> + - description: Display core throttle clock >> >> clock-names: >> + minItems: 6 >> items: >> - const: bus >> - const: iface >> @@ -42,6 +48,7 @@ properties: >> - const: lut >> - const: core >> - const: vsync >> + - const: throttle >> >> required: >> - compatible >> @@ -52,6 +59,20 @@ required: >> >> unevaluatedProperties: false >> >> +allOf: >> + - if: >> + properties: >> + compatible: >> + const: qcom,sm6375-dpu > > And the two other variants? Is the clock valid there or not? If not > really, then you should have else: with maxItems: 6. Oh right! > >> + >> + then: >> + properties: >> + clocks: >> + minItems: 7 >> + >> + clock-names: >> + minItems: 7 > > If there is going new version - put allOf: before > unevaluatedProperties:. Otherwise it is fine. Thanks! Konrad > >> + >> examples: >> - | >> #include >> > > Best regards, > Krzysztof >