From: Andrew Lunn <andrew@lunn.ch>
To: Gatien Chevallier <gatien.chevallier@foss.st.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: st: enable ethernet1 controller on stm32mp257f-ev1
Date: Wed, 3 Sep 2025 14:24:17 +0200 [thread overview]
Message-ID: <faa673a3-d68c-4b7f-a2b6-1f5bf40aabfb@lunn.ch> (raw)
In-Reply-To: <20250903-mp2_ethernet-v1-3-4105b0ad2344@foss.st.com>
> + phy1_eth1: ethernet-phy@4 {
> + compatible = "ethernet-phy-id001c.c916";
> + reset-gpios = <&gpioj 9 GPIO_ACTIVE_LOW>;
> + reset-assert-us = <10000>;
> + reset-deassert-us = <80000>;
> + reg = <4>;
The DT coding style would suggest reg comes after compatible.
Andrew
next prev parent reply other threads:[~2025-09-03 12:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 9:53 [PATCH 0/4] arm64: dts: st: add ethernet1 controller support on stm32mp23/25 boards Gatien Chevallier
2025-09-03 9:53 ` [PATCH 1/4] arm64: dts: st: add eth1 pins for stm32mp2x platforms Gatien Chevallier
2025-09-03 9:53 ` [PATCH 2/4] arm64: dts: st: enable ethernet1 controller on stm32mp257f-dk Gatien Chevallier
2025-09-03 12:21 ` Andrew Lunn
2025-09-03 13:35 ` Gatien CHEVALLIER
2025-09-03 9:53 ` [PATCH 3/4] arm64: dts: st: enable ethernet1 controller on stm32mp257f-ev1 Gatien Chevallier
2025-09-03 12:24 ` Andrew Lunn [this message]
2025-09-03 12:46 ` Gatien CHEVALLIER
2025-09-03 9:53 ` [PATCH 4/4] arm64: dts: st: enable ethernet1 controller on stm32mp235f-dk Gatien Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faa673a3-d68c-4b7f-a2b6-1f5bf40aabfb@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gatien.chevallier@foss.st.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).