Re: [PATCH v3 1/2] dt-bindings: mmc: Add YAML schemas for the generic MMC options

Maxime Ripard
2019-05-28T17:26:49Z

Hi Ulf,

On Tue, May 28, 2019 at 10:40:16AM +0200, Ulf Hansson wrote:
> > +patternProperties:
> > + "^.*@[0-9]+$":
> > + properties:
> > + reg:
> > + items:
> > + - minimum: 0
> > + maximum: 7
> > + description:
> > + Must contain the SDIO function number of the function this
> > + subnode describes. A value of 0 denotes the memory SD
> > + function, values from 1 to 7 denote the SDIO functions.
> > +
> > + broken-hpi:
> > + $ref: /schemas/types.yaml#/definitions/flag
> > + description:
> > + Use this to indicate that the mmc-card has a broken hpi
> > + implementation, and that hpi should not be used.
> > +
> > + required:
> > + - reg
> > +
>
> [...]
>
> > -Use of Function subnodes
> > -------------------------
> > -
> > -On embedded systems the cards connected to a host may need additional
> > -properties. These can be specified in subnodes to the host controller node.
> > -The subnodes are identified by the standard 'reg' property.
> > -Which information exactly can be specified depends on the bindings for the
> > -SDIO function driver for the subnode, as specified by the compatible string.
> > -
> > -Required host node properties when using function subnodes:
> > -- #address-cells: should be one. The cell is the slot id.
> > -- #size-cells: should be zero.
> > -
> > -Required function subnode properties:
> > -- reg: Must contain the SDIO function number of the function this subnode
> > - describes. A value of 0 denotes the memory SD function, values from
> > - 1 to 7 denote the SDIO functions.
> > -
> > -Optional function subnode properties:
> > -- compatible: name of SDIO function following generic names recommended practice
> > -
>
> I think most of the information of how we use sub(child) nodes
> disappeared in this conversion - or at least gets harder to
> understand. Could we perhaps keep some of this?

Sure, what would you like to keep in particular?

Thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering