From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.mainlining.org (mail.mainlining.org [5.75.144.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B6083A7580; Tue, 10 Mar 2026 12:57:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=5.75.144.95 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773147460; cv=none; b=QF4jygOQMOzS+770hq7KVcg1XbKsWRUeLtJImYFBlbgbe95xQciNDa3k3nvkqBtFj/9Hc8fo6Kibuq/emxOEj61is47DDxQa37qk+pff252OESwjqYeDc0qd8UDEDRmjCgWAOrq4Iklyr3LU4sDQSDDLcZOJRm1WH9pWNFyyqIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773147460; c=relaxed/simple; bh=7B1yL4NXUbSrk9RavCHgDv8l+QllyzHuM2LtcNkdcqM=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=VDCNrplIjZQnzjqehw5QGJ5MPeTxYM5VJ51ZKMJpgykcNeg12TfMdwBqSHyZQn7HOYd+zwDpygK3XJhqANejMMRxISKdjkcpCvkXuus5PiApzPpAMJ1ovY5xhJnVUKHEfjlHi2nPbGb54VH15H0EUm781rkwNf0IPpIEDA4bHkQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mainlining.org; spf=pass smtp.mailfrom=mainlining.org; dkim=pass (2048-bit key) header.d=mainlining.org header.i=@mainlining.org header.b=YqhqqXn/; dkim=permerror (0-bit key) header.d=mainlining.org header.i=@mainlining.org header.b=qcj2U8WT; arc=none smtp.client-ip=5.75.144.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mainlining.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mainlining.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mainlining.org header.i=@mainlining.org header.b="YqhqqXn/"; dkim=permerror (0-bit key) header.d=mainlining.org header.i=@mainlining.org header.b="qcj2U8WT" DKIM-Signature: v=1; a=rsa-sha256; s=202507r; d=mainlining.org; c=relaxed/relaxed; h=Message-ID:Subject:To:From:Date; t=1773147455; bh=AgluKCXDjtXXarLidShHy0Q ZPjPkfIfpD3Xwdip+tb0=; b=YqhqqXn/zNSwmjWn+bZkLj7k2kuIvRlkvvzL7jd9KGJVYnsJD6 8CKLknSSPq2pkQzhzwqfqeabhU+vfZXkUm43aX3XDzdRdpZYRNN6iR+y26UxnHQqIJ4pfiGoJvL o/gIzNwVA0IJnc9EtwUpG6v3e+4ex1z5GO76OVs5XSA7vIhYLr94KI+/o1xV7Arfa0po9QvsZzy 0xgW7I+BIfVHmHuNJS2fLM6IxGoLWrDiavv8Oy77AuiBZAtMnI/YrmqRb1TTa/soSYJKpEVEXgY TYFaIVM0Y7Cdfgw0c/sq/TztAPPtA/JpAA+0wQiIea7cuQ+3+480pYqwrkyNIUZTgAA==; DKIM-Signature: v=1; a=ed25519-sha256; s=202507e; d=mainlining.org; c=relaxed/relaxed; h=Message-ID:Subject:To:From:Date; t=1773147455; bh=AgluKCXDjtXXarLidShHy0Q ZPjPkfIfpD3Xwdip+tb0=; b=qcj2U8WTBiAiqZ+wQUEuw39D+Ylai2HEHwGx2zIxI5HxrVHAzE OfjbrQ4ncl6qJq8RaGskiP7D3uo6snoQ/AAQ==; Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 10 Mar 2026 13:57:35 +0100 From: barnabas.czeman@mainlining.org To: Konrad Dybcio Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org, phone-devel@vger.kernel.org Subject: Re: [PATCH 1/5] arm64: dts: qcom: msm8917-xiaomi-riva: Commonize for Redmi 4A and GO In-Reply-To: References: <20260305-riva-common-v1-0-436f1f4b7399@mainlining.org> <20260305-riva-common-v1-1-436f1f4b7399@mainlining.org> Message-ID: X-Sender: barnabas.czeman@mainlining.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2026-03-09 13:55, Konrad Dybcio wrote: > On 3/5/26 6:28 PM, Barnabás Czémán wrote: >> Redmi 5A is very similar for Redmi 4A (rolex) and Redmi GO (tiare), >> it can be commonized for avoid unnecessary code duplications. >> >> Signed-off-by: Barnabás Czémán >> --- > > Could you please try adding the following to your gitconfig: > > [diff] > renameLimit = 999999 > algorithm = histogram # or 'copies' > renames = copies > > and see if this generates a shorter diff? > > Konrad One more question should i rename msm8917-xiaomi-riva-common to msm8917-wingtech-common, they are wingtech devices. Which naming is preferred? They have wingtech name also: S88503 - Redmi 4A (rolex) S88505 - Redmi 5A (riva) S88508 - Redmi Go (tiare)