From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FF6FEB64DA for ; Wed, 28 Jun 2023 19:33:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231926AbjF1TdX (ORCPT ); Wed, 28 Jun 2023 15:33:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231944AbjF1TdU (ORCPT ); Wed, 28 Jun 2023 15:33:20 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7F3D194 for ; Wed, 28 Jun 2023 12:33:18 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4fb7b2e3dacso20729e87.0 for ; Wed, 28 Jun 2023 12:33:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687980797; x=1690572797; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8luJOwdXXfNeGMdyQDRfNqFP6j7QRvwX8K5JggFfHh4=; b=OFojlgb6qOIm4BRwHjuEJRu21xeqeV1LKW39dulUm0vJglosAJKjZTlgW3/cLlgfU8 sPI1lmD/lzuYgpDV9HQafdKnia9WgUg3ps4kGh906wC3CQM3CUftthUwZpdg7TBFzX3b 9IKQRCdmv2yazcc8DILLCL5930i2OlChyeDr4t8roHHZ/8D5Pg3L6dzeUbrwd+FnfPJP DP6qRBRkRtoeC5tx0hOHsHdiNUcEQtnRemfIlpTpqqZ9vtZXAlhmrS8UpwMjvoRSIX/i jxGG/T63PLW80jwq8IRznHCsNQ9kM6G9jYkhNVr3xenUyn7YyYoQknQ5JwtTAu3ecF4b Yjjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687980797; x=1690572797; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8luJOwdXXfNeGMdyQDRfNqFP6j7QRvwX8K5JggFfHh4=; b=NUWrwCkmuh92zOPvT6REbebjyUsykeJnyvlaeP/8LLnuP4tIjDC2KpKB2mjkLjBVym 7d8GNhWk671LxhJbNDvOPTFtB51HV1V9rNOjiXVOS8HC2knqBcwRl56KaCgb23yfVccn HlA5D/bkt61w2S5oC2f4uHA8NvbyOiB+1s7d9Y6JoVazJtuu6TmX31snicgAwSucP6a/ c+SYk+UwbyJivwtIvv3Tfgq0HSFlGt93wUsir3Xmxr/ztMXdfCN7bWqvOCpPWFFgZi8N HAOfnRCvkyAHLxnlPyUORs60i0/IIu/ebJTKQFf1fhFx7ISEjdtMosvjsxnnlDL2hvxB JC7A== X-Gm-Message-State: AC+VfDwMrWZ+yJYqLkuAB5G6JIVu4HfsdFovqDGLovKxLuemwZCuvdz4 pKUFEMUgt7JJkuFjbaYEHnDhPA== X-Google-Smtp-Source: ACHHUZ4tzZacjhlbNXcdymGFQQEzjZFRE+pRBdGohWQU6TmdwqnDkuI66k6/rbtFjpxqb2SbajrvVQ== X-Received: by 2002:a19:674d:0:b0:4f8:6ea5:104b with SMTP id e13-20020a19674d000000b004f86ea5104bmr16247327lfj.30.1687980797180; Wed, 28 Jun 2023 12:33:17 -0700 (PDT) Received: from [10.10.15.130] ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id r22-20020ac24d16000000b004fb757bd429sm1385852lfi.96.2023.06.28.12.33.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jun 2023 12:33:16 -0700 (PDT) Message-ID: Date: Wed, 28 Jun 2023 22:33:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/3] ASoC: qcom: q6apm: add support for reading firmware name from DT Content-Language: en-GB To: Mark Brown Cc: Srinivas Kandagatla , krzysztof.kozlowski+dt@linaro.org, andersson@kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, johan+linaro@kernel.org, perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com, ckeepax@opensource.cirrus.com, kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org References: <20230628102621.15016-1-srinivas.kandagatla@linaro.org> <20230628102621.15016-3-srinivas.kandagatla@linaro.org> <73dce263-bee6-554f-9eb6-af4aa7badab1@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/06/2023 21:10, Mark Brown wrote: > On Wed, Jun 28, 2023 at 07:57:38PM +0300, Dmitry Baryshkov wrote: >> On 28/06/2023 14:53, Mark Brown wrote: > >>> Why not try a series of firmware names/locations generated using the >>> identifying information for the card/system? That way we don't have to >>> put a filename in the ABI which has fun scaling issues. > >> This is what was done by Srini in the initial (currently committed) version. >> Unfortunately this easily results in the audio topology being separated from >> the rest of the platform-specific firmware. For example, for the mentioned >> X13s we already have a subdir under /lib/firmware/qcom and several >> firmware-name DT properties pointing to the files in that subdir: > >> $ grep firmware-name >> arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts >> firmware-name = "qcom/sc8280xp/LENOVO/21BX/qcdxkmsuc8280.mbn"; >> firmware-name = "qcom/sc8280xp/LENOVO/21BX/qcadsp8280.mbn"; >> firmware-name = "qcom/sc8280xp/LENOVO/21BX/qccdsp8280.mbn"; > >> This is not unique to the X13s, other Qualcomm boards also use full paths. > > If the goal here is to put all the firmwares for a given board in a > single place surely it would be better to factor this all out of the > individual drivers so that they ask some helper for a directory to use > for firmware? Adding these device specific firmware node properties > doesn't seem to follow. This quickly becomes overcomplicated. Some platforms use different firmware naming structure. Some firmware goes into a generic location and other files go into device-specific location. So having a generic helper doesn't really help. -- With best wishes Dmitry