From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91CE51CA83 for ; Mon, 18 Sep 2023 12:00:17 +0000 (UTC) Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1EDD19A for ; Mon, 18 Sep 2023 04:59:27 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-9ada6b0649fso590058666b.1 for ; Mon, 18 Sep 2023 04:59:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695038366; x=1695643166; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Mx+1LEKjG08mHXdWiW0HFl/U3LRaOvUzyjCNt5ITLZc=; b=Fw4HkzC7pcvppLJYx2wITGv2sEElnkg7QPGY7lPh7ux1OM1cE15GesUPD7c2aSD7gd gq8V1nqYbytebM71PrH3/4Szgg8SpC/kOjXkxNN8twzIwSPvUwjPXNmQiYnvuDXEoo0w PveSKvaKppysaMOdITgl9uIfGINmxR6DeI0XZCp0wyLwU1i5H6MGcRjKDK+U5FSF3/Kf upMkjHEnlhjg7qOnu8PH5WGGjwRi2WTZ4xp6C25gS/f9X7Eg5LsVNJVAsMdXmzRxewVM KbEoeB9B5nilqxDXOGyk96GtBPx9SVgIjrwBc1/5XmvExhasUQXRIlI/TraaCXHatyQN jeZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695038366; x=1695643166; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Mx+1LEKjG08mHXdWiW0HFl/U3LRaOvUzyjCNt5ITLZc=; b=pGOJ5MEC2R3hrvT5FdW5J6gcFPb+r8Rvx1pagr7a+0ulLgMCVVS4l5xmTmtOXUBZeB y5qN9n/78vGbhwI4b9hH5Np+A2OsrN7WyiHhT9enI78VgVrJC4gaCC4UBpMKMQ3/Ty8W 0kedZ4ujBSyiuKuX6q9/KyaRBGLHL4nk65VtxOdkGF1UOZD5oE3H2Kpm/UKRCEfdmvjx kGV7S1RpmH2YKXZO2eUTFlqsbETmsYxut/2wEzS0XojdMhRbMzky357rG9Uu/+856ujD 4y5OWBeTWTlMJVvT1MtvmFchz+cQReAK34S+MPGVla3WqjiupjcYTa/rWdgoiujKtf2W AQgg== X-Gm-Message-State: AOJu0Yw/5o/lFwEK0sDoj9YZ1vF3CQ2LLxsEd4ZL66gvE6C1lLCXQHZy bZrmp0X80XjvAr4bERGXcLS05Q== X-Google-Smtp-Source: AGHT+IEQU5aP9n0ZpbF9FIWm05VurFH/Lgko0yhluHa5UJmuOfDQoNjoIOALZWR4TY4wUZ0dcYYJAQ== X-Received: by 2002:a17:906:5188:b0:9a1:db97:62a1 with SMTP id y8-20020a170906518800b009a1db9762a1mr7333228ejk.46.1695038366283; Mon, 18 Sep 2023 04:59:26 -0700 (PDT) Received: from [172.25.80.114] ([217.67.225.27]) by smtp.gmail.com with ESMTPSA id j9-20020a170906410900b0099cc3c7ace2sm6466812ejk.140.2023.09.18.04.59.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Sep 2023 04:59:25 -0700 (PDT) Message-ID: Date: Mon, 18 Sep 2023 13:59:24 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 3/3] dt-bindings: hwinfo: Add mtk-socinfo driver Content-Language: en-US To: AngeloGioacchino Del Regno , William-tw Lin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Kevin Hilman Cc: Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20230915152607.18116-1-william-tw.lin@mediatek.com> <20230915152607.18116-4-william-tw.lin@mediatek.com> <3e7bc476-ffc7-fb07-8e64-246427da736c@linaro.org> <9acc8d99-e3db-3df8-4051-21d95450b28d@collabora.com> From: Krzysztof Kozlowski In-Reply-To: <9acc8d99-e3db-3df8-4051-21d95450b28d@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 18/09/2023 10:47, AngeloGioacchino Del Regno wrote: > Il 17/09/23 10:26, Krzysztof Kozlowski ha scritto: >> On 15/09/2023 17:26, William-tw Lin wrote: >>> dt-binding documentation for mtk-socinfo driver. >> >> Here and in subject, drop driver and instead descrbe hardware. >> >>> mtk-socinfo driver provides SoC-related information. >>> Such information includes manufacturer information, SoC name, >>> SoC segment name, and SoC marketing name. >>> >>> Signed-off-by: William-tw Lin >>> --- >>> .../bindings/hwinfo/mtk-socinfo.yaml | 48 +++++++++++++++++++ >>> 1 file changed, 48 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/hwinfo/mtk-socinfo.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/hwinfo/mtk-socinfo.yaml b/Documentation/devicetree/bindings/hwinfo/mtk-socinfo.yaml >>> new file mode 100644 >>> index 000000000000..74f03f1dc404 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/hwinfo/mtk-socinfo.yaml >> >> Nothing improved. >> >> This is a friendly reminder during the review process. >> >> It seems my previous comments were not fully addressed. Maybe my >> feedback got lost between the quotes, maybe you just forgot to apply it. >> Please go back to the previous discussion and either implement all >> requested changes or keep discussing them. >> >> Thank you. >> >>> @@ -0,0 +1,48 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/hwinfo/mtk-socinfo.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: MediaTek SoC ChipID >>> + >>> +maintainers: >>> + - William Lin >>> + - Matthias Brugger >>> + - Kevin Hilman >>> + - AngeloGioacchino Del Regno >>> + >>> +description: >>> + MediaTek SoCs store various product information in eFuses, including >>> + Chip ID and Revision fields, usable to identify the manufacturer, >>> + SoC version, plus segment and marketing names. >>> + >>> +properties: >>> + compatible: >>> + const: mediatek,socinfo >> >> What happened to compatibles? No, this is just wrong and no explained. >> You ignored other comments as well. Really, that's not the way to go. >> > > Practically, having different compatibles for each SoC is not needed, as > the only thing that changes between SoCs is the eFuse(s) that you read to > get the information - and that's all. And how do you guarantee that no future SoC will have any difference? How can you even predict it? > > So ... we either use this driver with devicetree, giving it the right eFuses I am talking about bindings, no driver. > to read from, or we duplicate the mtk-efuse driver, or we statically assign > the eFuses in the driver itself and we set compatibles like > "mediatek,mt8195-socinfo" to select that... ideas? Device specific compatibles followed by fallback, just like for every other review coming from me. Best regards, Krzysztof