From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Keguang Zhang <keguang.zhang@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Serge Semin <Sergey.Semin@baikalelectronics.ru>
Subject: Re: [PATCH 2/5] dt-bindings: mfd: syscon: Add compatibles for Loongson-1 syscon
Date: Mon, 14 Aug 2023 21:06:24 +0200 [thread overview]
Message-ID: <fae2d136-28e3-d3a1-c789-8552e8f59a15@linaro.org> (raw)
In-Reply-To: <20230812151135.1028780-3-keguang.zhang@gmail.com>
On 12/08/2023 17:11, Keguang Zhang wrote:
> Add Loongson LS1B and LS1C compatibles for system controller.
>
> Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
> ---
> Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 8103154bbb52..c77d7b155a4c 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -49,6 +49,8 @@ properties:
> - hisilicon,peri-subctrl
> - hpe,gxp-sysreg
> - intel,lgm-syscon
> + - loongson,ls1b-syscon
> + - loongson,ls1c-syscon
It seems each SoC has multiple syscons so using the same compatible is
wrong. Different devices should have different compatibles.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-14 19:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 15:11 [PATCH 0/5] Move Loongson1 MAC arch-code to the driver dir Keguang Zhang
2023-08-12 15:11 ` [PATCH 1/5] MIPS: loongson32: Remove Loongson1 MAC arch-code Keguang Zhang
2023-08-12 15:11 ` [PATCH 2/5] dt-bindings: mfd: syscon: Add compatibles for Loongson-1 syscon Keguang Zhang
2023-08-14 19:06 ` Krzysztof Kozlowski [this message]
2023-08-12 15:11 ` [PATCH 3/5] dt-bindings: net: Add Loongson-1 DWMAC glue layer Keguang Zhang
2023-08-14 19:11 ` Krzysztof Kozlowski
2023-08-16 12:54 ` Serge Semin
2023-08-18 10:42 ` Keguang Zhang
2023-08-18 13:48 ` Serge Semin
2023-08-21 13:13 ` Keguang Zhang
2023-08-12 15:11 ` [PATCH 4/5] net: stmmac: Add glue layer for Loongson-1 SoC Keguang Zhang
2023-08-12 21:30 ` kernel test robot
2023-08-13 8:28 ` kernel test robot
2023-08-13 18:24 ` Simon Horman
2023-08-14 10:50 ` Keguang Zhang
2023-08-16 13:30 ` Serge Semin
2023-08-18 12:37 ` Keguang Zhang
2023-08-18 16:19 ` Serge Semin
2023-08-21 13:24 ` Keguang Zhang
2023-08-21 14:16 ` Serge Semin
2023-08-22 7:58 ` Keguang Zhang
2023-08-22 10:53 ` Serge Semin
2023-08-22 12:09 ` Keguang Zhang
2023-08-22 14:20 ` Serge Semin
2023-08-12 15:11 ` [PATCH 5/5] MAINTAINERS: Add entry for Loongson-1 DWMAC Keguang Zhang
2023-08-14 19:16 ` Krzysztof Kozlowski
2023-08-13 15:24 ` [PATCH 0/5] Move Loongson1 MAC arch-code to the driver dir Andrew Lunn
2023-08-14 2:39 ` Keguang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fae2d136-28e3-d3a1-c789-8552e8f59a15@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=keguang.zhang@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).