From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-phy@lists.infradead.org
Cc: agross@kernel.org, linux-kernel@vger.kernel.org,
andersson@kernel.org, bhupesh.linux@gmail.com,
robh+dt@kernel.org, konrad.dybcio@linaro.org, kishon@kernel.org,
vkoul@kernel.org, krzysztof.kozlowski+dt@linaro.org,
dmitry.baryshkov@linaro.org
Subject: Re: [PATCH v10 1/4] dt-bindings: phy: qcom,qmp-usb: Drop legacy bindings and move to newer one (SM6115 & QCM2290)
Date: Wed, 3 May 2023 18:24:57 +0200 [thread overview]
Message-ID: <faefbbed-0f62-e569-455d-0d21b363f8f3@linaro.org> (raw)
In-Reply-To: <20230502053534.1240553-2-bhupesh.sharma@linaro.org>
On 02/05/2023 07:35, Bhupesh Sharma wrote:
> 'qcom,msm8996-qmp-usb3-phy.yaml' defines bindings for several PHYs
> which predate USB -> USB+DP migration. Since SM6115 and QCM2290
> nodes for USB QMP phy are being added to dtsi files by followup patches,
> move these bindings instead to the newer style
> 'qcom,sc8280xp-qmp-usb3-uni-phy.yaml' file.
>
> clock-names:
> - items:
> - - const: aux
> - - const: ref
> - - const: com_aux
> - - const: pipe
> + maxItems: 4
>
> power-domains:
> maxItems: 1
> @@ -71,6 +69,42 @@ required:
>
> additionalProperties: false
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,qcm2290-qmp-usb3-phy
> + - qcom,sm6115-qmp-usb3-phy
> + then:
> + properties:
> + clocks:
> + maxItems: 4
> + clock-names:
> + items:
> + - const: cfg_ahb
> + - const: ref
> + - const: com_aux
> + - const: pipe
I am pretty sure I acked it and there were no changes here... but since
you did not include it, then lets keep the clock order the same as
sc8280xp. ABI is anyway affected, right?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-03 16:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 5:35 [PATCH v10 0/4] Enable USB SS qmp phy for Qualcomm SM6115 SoC Bhupesh Sharma
2023-05-02 5:35 ` [PATCH v10 1/4] dt-bindings: phy: qcom,qmp-usb: Drop legacy bindings and move to newer one (SM6115 & QCM2290) Bhupesh Sharma
2023-05-03 16:24 ` Krzysztof Kozlowski [this message]
2023-05-04 17:12 ` Bhupesh Sharma
2023-05-05 7:23 ` Bhupesh Sharma
2023-05-02 5:35 ` [PATCH v10 2/4] phy: qcom-qmp-usb: add support for updated qcm2290 / sm6115 binding Bhupesh Sharma
2023-05-02 8:30 ` Dmitry Baryshkov
2023-05-02 5:35 ` [PATCH v10 3/4] arm64: dts: qcom: sm6115: Add USB SS qmp phy node Bhupesh Sharma
2023-05-02 10:35 ` Konrad Dybcio
2023-05-02 11:12 ` Caleb Connolly
2023-05-02 5:35 ` [PATCH v10 4/4] arm64: dts: qcom: qrb4210-rb2: Enable USB node Bhupesh Sharma
2023-05-02 10:36 ` Konrad Dybcio
2023-05-02 11:16 ` Caleb Connolly
2023-05-16 14:23 ` [PATCH v10 0/4] Enable USB SS qmp phy for Qualcomm SM6115 SoC Vinod Koul
2023-05-16 15:06 ` Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faefbbed-0f62-e569-455d-0d21b363f8f3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=bhupesh.sharma@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).