From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 898F3C433FE for ; Mon, 30 May 2022 07:42:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233759AbiE3Hmt (ORCPT ); Mon, 30 May 2022 03:42:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233734AbiE3Hmd (ORCPT ); Mon, 30 May 2022 03:42:33 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C57D53B6F for ; Mon, 30 May 2022 00:42:30 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id n124-20020a1c2782000000b003972dfca96cso5905298wmn.4 for ; Mon, 30 May 2022 00:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=tDRiL7T1D2xh8IqjQ4J9GQ/82u6rcAgsmar4+giEo/c=; b=DyT3t+1nyG9y4HN64kgP299uQMuwvYQw3UXLpbawcwaWR/Jqerrg29FeN0CWFMCYbo wYFK+RTScfJC11jD7p12SBCHM6cnrVn02ZhrexSayH9QhoKjl2Fki9rOWgd4xZEPrdKW FAsewudhQ2ax1Og0wls9gcytEW/VAX4IZe534jNFQORswYITHyoUjmlqAURly9zdzHRC swS5xuL9QRfIpzLsOkyIdTkIgzHaIrsc2BdcHDRVSj7MXk3v4dQKr/VuBNGhpnRtifDJ dicKc83acHjeI51wuiYAKK2AwU7sn0qjvC8PnR1L+d9/YmVy0Nj7Pvpd+13OkuHk7uw2 pA8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=tDRiL7T1D2xh8IqjQ4J9GQ/82u6rcAgsmar4+giEo/c=; b=FsEyfTpUpTO91Bem/sYFTDgP0OgBVVTmJqdgOrw5ahQB8kMpabmJUBpYLuNuYpF0eB gVAgHqkw8yDODYtJC14iFe6UiUKTUnh3ezJSF7t//OyZffDDooE9aEwsba3a/qlP8+hK EjafGJlmPIDHFESo0G6/u4qOyINUHN4Z2A9tlIIIub/wrsZt4Pva9zdmqdSI8r7sGJ33 hF5T34ISSlWJdA+LYBRn4vXo2UuaviSt/gNx+EQD2eHOjhtliIW4jQC6oVdhtYI1OSFH DA9Dg0e/BfWiq2eo0mGWULZwBRJ9O+nxT/eBdaQJCHHILWzyHUIbUskfdx/Qgj1RpetF mG6w== X-Gm-Message-State: AOAM531bQg0EjVL+waF8kb2i7l8yay3KtdOHE7yFT+jE+T9OdZv6lLBh RyIjnhTo1snJgEe9Q6Hlby/K1A== X-Google-Smtp-Source: ABdhPJwoeX8AFnrofXaPRVEbqd1WcQ2GzDw7JV+PLebAOLW2qA5bkbyquUytImzShJhd5/S7esV1wA== X-Received: by 2002:a05:600c:2305:b0:397:44a4:d3cb with SMTP id 5-20020a05600c230500b0039744a4d3cbmr17393978wmo.115.1653896549076; Mon, 30 May 2022 00:42:29 -0700 (PDT) Received: from [192.168.0.179] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id h19-20020a05600c351300b0039456fb80b3sm9966481wmq.43.2022.05.30.00.42.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 May 2022 00:42:28 -0700 (PDT) Message-ID: Date: Mon, 30 May 2022 09:42:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 4/7] arm64: dts: qcom: sdm845: control RPMHPD performance states with UFS Content-Language: en-US To: Viresh Kumar Cc: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Viresh Kumar , Nishanth Menon , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , "Rafael J. Wysocki" , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-scsi@vger.kernel.org, Manivannan Sadhasivam References: <20220513061347.46480-1-krzysztof.kozlowski@linaro.org> <20220513061347.46480-5-krzysztof.kozlowski@linaro.org> <20220525071630.irrz24rs73l3ke4o@vireshk-i7> From: Krzysztof Kozlowski In-Reply-To: <20220525071630.irrz24rs73l3ke4o@vireshk-i7> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/05/2022 09:16, Viresh Kumar wrote: > On 13-05-22, 08:13, Krzysztof Kozlowski wrote: >> + ufs_opp_table: opp-table { >> + compatible = "operating-points-v2"; >> + >> + opp-50000000 { >> + opp-hz = /bits/ 64 <50000000 >> + 0 >> + 0 >> + 37500000 >> + 0 >> + 0 >> + 0 >> + 0 >> + // FIXME: value 0 copied from freq-table-hz >> + 0>; > > One general comment, I think this should follow how we specify > multiple voltages or other fields and so each frequency should be part > of a different < > braces. Like: opp-hz = /bits/ 64 <5000000>, <0>, .... > > Whatever is there between < > seems to be connected, like > min/max/target for voltage. > > The code will process both in a similar way though eventually. OK, I can change to such format. Best regards, Krzysztof