From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D83623CE for ; Sat, 24 Feb 2024 10:36:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708771000; cv=none; b=KYA37ynHGy4HZxJj3O2/Fu1hIUau9ZIc/9ph65PHrzQcktA6UCDcpp7sZSRTO7ORKNRJNfaAOvAWcB4HH647SGe08ttI3nQvNM55tAaD6pu85Q/qXBCbGPVnAu1Vlsfk8qXCpPlQQzkOAFEm/ZXekTUOxLHITygqSty8zQKPoHk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708771000; c=relaxed/simple; bh=58adu5hvmmb2LOEQiDHsQjLazEwZVBt1UbSh0UkM2No=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Gvot2LTm6dJ2dyr3pa64w9IDJ9L7kSl83XOlNQ96plcTqstC2ga6fJgH4TUfN1+PLdY1C9mujC8hVEwQju5TgAJgRJ+5IBPcz94yCn5h7KJWNQcuh8txAOJQmcmRslcaBh5kOEAzYTMS7h3+KIGgr2iu1WOJ3IPZ89BnAprFaCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cvM4iiLn; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cvM4iiLn" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-564fc495d83so1812919a12.0 for ; Sat, 24 Feb 2024 02:36:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708770996; x=1709375796; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oywdlN7ttlpIa6C90/nFZJ1AJJorSsP7MnjdUxAPcfI=; b=cvM4iiLnm2HJ0QXVBt+rbbaaMsgYa7UE3KCX4pcLsgfVGBpD0colpOaaObMzlUkX5q uQ8SnEQYbp8A0LjXDcIzFPzd71A3W4Eo8QlpsnwMv85mxvsupKsu3dtlKCKcuhqlATNz uBrF0es1hsYVK2zxUfSXLxyFM+3Lq7xC3uFNTyd0yBxn4wBUG0+LL3WB6SfiCayH7FfM YeH41UezyadaqvhXAz45JPqWXmVgin5D48I6HCYdr2PqOZ28oYs/2H+gg7Y+6gtmzbz5 l9fumB1urr0uxKldon25rf1AARbSLY6AOnRgRqNTFxXzEO7d/4f5SIWglqIjORLV4SLJ 1Mgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708770996; x=1709375796; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oywdlN7ttlpIa6C90/nFZJ1AJJorSsP7MnjdUxAPcfI=; b=D7xWLtv2Kfb+jM91h6GZu05NhIXdrFV/odTkv0zNA6QfdYXTOg2uTmjF/dKoWXXFR7 xrV+gW9ldZrxeI2o3YnfaxOf/H+sju6pRztyCsSLJSakxGpmlHbIIxNuy+HuLUJcbJCs MS/0OEVerbC18cmUiY442hmyVG3E2YErl/vw0Sf8R3ITPH+8XCFfUrwmjVsTvTbZSLXP jtrLWqKFcyH+LeHPzf/crBAlpxMR1EJgOBA5L/vZHn3fp+/2EkbxmaicsEw413x97Zg6 YBO8MzUsAyi2e+MPOXCFNckc344oPDV2uXpMnEXLAt5Wd0B8r3iYBmxoU+DdOQNUSVk3 V+6Q== X-Forwarded-Encrypted: i=1; AJvYcCVXqx9rkmtuDNVtvyf+MBd74YfPIFkevRTBhLyBQ3TvgkfFDevHQffs/4tVwrgVJ32lBDkM0rVZf+PePUiM7+vUHKHP6NiMK71ztg== X-Gm-Message-State: AOJu0YyNGdSbhoYWoqIdq4/kHLrxpVGWCTNbXALJhJdihkZ14N3WkI2v LQxcb59iGihK+oRN3hgcK0JTJWTiFCKbbnEbehoy/EajJd1SDqc2noGih9aQY34= X-Google-Smtp-Source: AGHT+IFQ1CTLhVHev3X3ZsNIvWOvLmOq9DnNPyZNr2LsttwMkZxgcML6EMs7YR3aM8ssnQ0Gl1q6og== X-Received: by 2002:a05:6402:5201:b0:565:a5e1:3a12 with SMTP id s1-20020a056402520100b00565a5e13a12mr740380edd.3.1708770996394; Sat, 24 Feb 2024 02:36:36 -0800 (PST) Received: from [192.168.1.20] ([178.197.222.116]) by smtp.gmail.com with ESMTPSA id k1-20020a05640212c100b005653fe3f180sm416424edx.70.2024.02.24.02.36.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Feb 2024 02:36:35 -0800 (PST) Message-ID: Date: Sat, 24 Feb 2024 11:36:33 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: add TP-Link Archer AX55 v1 Content-Language: en-US To: Gabor Juhos , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240223-archer-ax55-v1-v1-0-99f8fa2c3858@gmail.com> <20240223-archer-ax55-v1-v1-2-99f8fa2c3858@gmail.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240223-archer-ax55-v1-v1-2-99f8fa2c3858@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 23/02/2024 09:17, Gabor Juhos wrote: > Add device tree source for the TP-Link Archer AX55 v1 [1] > which is a dual-band WiFi router based on the IPQ5018 SoC. > > At the moment, only the UART, the GPIO LEDs and buttons > are usable, but it makes it possible to boot an initramfs > image on the device. > > The device tree can be extended in the future, once support > for other periherals will be available for the platform. > > 1. https://www.tp-link.com/en/home-networking/wifi-router/archer-ax55/v1/ > > Signed-off-by: Gabor Juhos > --- > Note: running 'make CHECK_DTBS=y qcom/ipq5018-tplink-archer-ax55-v1.dtb' > shows the following: > > DTC_CHK arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb > <...>/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupts: [[0, 62, 4]] is too short > from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# > <...>/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short > from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# > <...>/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupts: [[0, 62, 4]] is too short > from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# > <...>/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names:0: 'pwr_event' was expected > from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# > <...>/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short > from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# > > This is not caused by the new device tree per se but comes from > the usb@8af8800 node defined in ipq5018.dtsi. Running the check > on 'qcom/ipq5018-rdp432-c2.dtb' shows the same. Thanks for noticing and describing. Appreciated! > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../dts/qcom/ipq5018-tplink-archer-ax55-v1.dts | 133 +++++++++++++++++++++ > 2 files changed, 134 insertions(+) ... > + > + button-wps { > + debounce-interval = <60>; > + gpios = <&tlmm 31 GPIO_ACTIVE_LOW>; > + label = "wps"; > + linux,code = ; > + }; > + }; > +}; > + > +&blsp1_uart1 { > + pinctrl-0 = <&uart1_pins>; > + pinctrl-names = "default"; > + status = "okay"; > +}; > + > +&sleep_clk { > + clock-frequency = <32000>; > +}; > + > +&tlmm { > + button_pins: button-pins-state { > + pins = "gpio25", "gpio31"; > + bias-pull-up; > + drive-strength = <8>; > + function = "gpio"; Usually we keep 'function' as second property, after 'pins', but there is no need to send new version just for that. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof