From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0AEDC5479D for ; Fri, 6 Jan 2023 12:58:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234417AbjAFM5g (ORCPT ); Fri, 6 Jan 2023 07:57:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234740AbjAFM5A (ORCPT ); Fri, 6 Jan 2023 07:57:00 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 554F475D37 for ; Fri, 6 Jan 2023 04:56:49 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id m7so1181156wrn.10 for ; Fri, 06 Jan 2023 04:56:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=74dZ6pX8Hzz0wsD+Rsd26TBqQcFBKeyHe2CX60hOkAw=; b=QvgwMKcl770gVhG3ElVmYe9D+yX6RxX07iUym3DL4v75V+bUiMIk6d1XN30kz72hkD guv87kWgeuYsJ5q+YAPrxHZf7JrtCAqn6vcKzvy7y+YaiCHOf3AC2Cq5RZIhqXX+q6SQ ue/VYGO1uOIk8WHNuzC6w112PN5Mtpl5kohZBkoKEVph/daoBycoFGJEf55BHMMMskZj MvoTGP0uJV8caK2M/a9mfD69LRwOl5TgAJ5zK7pwRxtwr8L/vtCBGP7GTqsBE825gmcq Dsul/1R2zcqmm3O3Ff8NqBS5lwXnuC4oKBQZF2ESgqniIa70YpdraMXTWUgCSwRbvFwi Gmgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=74dZ6pX8Hzz0wsD+Rsd26TBqQcFBKeyHe2CX60hOkAw=; b=kEicdw63tGjxdrGxRMXz7z+Mz30v0AgAYfOh8L7vBBmPOoxqUh4PmfM14xkaTmZff9 Mhz+p5gQ1V2z9jXYz+aENukcMqeFRfnTMxsr5xyDqzWAk0Lx4e/m5iSv/5wPWMIHrv/L cwPJ7UgOLg1JsqAU4sSf0dy7ssGiljl0IpwyWCoHFz/yFtq/41y9mcEZdHmrCUapbdUG gQuVOW9cdsv1Npkfxjw9mn3BsQ2F0D9nZEdQTx59WfgtI9bLcnOtCvKjnYmXdV7kITGz k2TrvorF2TxAZGZEWZHmhwE5EawM2NCcob/iK62rruOilR0RJscb76xgfSXQvGqpxqGX fB4Q== X-Gm-Message-State: AFqh2kpOxnwY+m/485hci2mVdc+DqCK3bT4Y44QNa9wN1o6JXkDjLGVH ykR64BHCOUEdE60smCfDpmRa2i7jg2aV5TVj X-Google-Smtp-Source: AMrXdXuiv7CJBvtiOg0LAC+AjzfIEkruZ3G21KfoSikp3a4fKbahEWvyGwVK+J0sGjtgBgZgW/5o6g== X-Received: by 2002:a05:6000:1109:b0:28d:b028:b16 with SMTP id z9-20020a056000110900b0028db0280b16mr17595490wrw.32.1673009807929; Fri, 06 Jan 2023 04:56:47 -0800 (PST) Received: from [192.168.1.102] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id l13-20020adfe58d000000b00296730b5c3esm1106814wrm.102.2023.01.06.04.56.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jan 2023 04:56:47 -0800 (PST) Message-ID: Date: Fri, 6 Jan 2023 13:56:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 3/3] arm64: dts: mediatek: enable USB device port for mt8195-demo board Content-Language: en-US To: Macpaul Lin , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org Cc: Bear Wang , Pablo Sun , Macpaul Lin , Miles Chen , linux-usb@vger.kernel.org, Chunfeng Yun , Tinghan Shen , Rex-BC Chen , Chen-Yu Tsai References: <20230105092809.14214-1-macpaul.lin@mediatek.com> <20230105092809.14214-3-macpaul.lin@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20230105092809.14214-3-macpaul.lin@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/01/2023 10:28, Macpaul Lin wrote: > 1. Enable USB device port (USB port0). > 2. Enable u2 speed for other USB HOST (USB port1/2/3). > 3. Configure mt6360 (TYPEC) related pinctrls. > > Note: Full dual-role switch capability requires TYPEC MUX driver and dts > update will be send in separate patches. > > Signed-off-by: Macpaul Lin > --- > arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 51 ++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts > index 07a864cb8b54..207bb5f4c58f 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > > / { > model = "MediaTek MT8195 demo board"; > @@ -380,6 +381,22 @@ > }; > }; > > + mt6360_pins: mt6360-pins { > + pins { > + pinmux = , > + ; > + input-enable; > + bias-pull-up; > + }; > + }; > + > + u3_p0_vbus: u3_p0vbusdefault { No underscores in node names. Also does not look correct naming. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). > + pins_cmd_dat { Same problem. Best regards, Krzysztof