devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nuno Sá" <noname.nuno@gmail.com>
To: kernel test robot <lkp@intel.com>,
	Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@kernel.org>,
	linux-hwmon@vger.kernel.org,  devicetree@vger.kernel.org,
	linux-doc@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH v2 2/2] hwmon: ltc4282: add support for the LTC4282 chip
Date: Mon, 27 Nov 2023 08:53:27 +0100	[thread overview]
Message-ID: <fb2aaa4c69c88738499dfbf46ef93e3b81ca93cb.camel@gmail.com> (raw)
In-Reply-To: <202311250548.lUn3bm1A-lkp@intel.com>

On Sat, 2023-11-25 at 07:39 +0800, kernel test robot wrote:
> Hi Nuno,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on groeck-staging/hwmon-next]
> [also build test WARNING on linus/master v6.7-rc2 next-20231124]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:   
> https://github.com/intel-lab-lkp/linux/commits/Nuno-Sa-via-B4-Relay/hwmon-ltc4282-add-support-for-the-LTC4282-chip/20231124-231842
> base:  
> https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
> patch link:   
> https://lore.kernel.org/r/20231124-ltc4282-support-v2-2-952bf926f83c%40analog.com
> patch subject: [PATCH v2 2/2] hwmon: ltc4282: add support for the LTC4282 chip
> config: x86_64-randconfig-161-20231125
> (https://download.01.org/0day-ci/archive/20231125/202311250548.lUn3bm1A-lkp@intel.c
> om/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build):
> (https://download.01.org/0day-ci/archive/20231125/202311250548.lUn3bm1A-lkp@intel.c
> om/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes:
> > https://lore.kernel.org/oe-kbuild-all/202311250548.lUn3bm1A-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> > > drivers/hwmon/ltc4282.c:347:6: warning: no previous prototype for
> > > 'ltc4282_round_rate' [-Wmissing-prototypes]
>      347 | long ltc4282_round_rate(struct clk_hw *hw, unsigned long rate,
>          |      ^~~~~~~~~~~~~~~~~~
> > > drivers/hwmon/ltc4282.c:356:15: warning: no previous prototype for
> > > 'ltc4282_recalc_rate' [-Wmissing-prototypes]
>      356 | unsigned long ltc4282_recalc_rate(struct clk_hw *hw, unsigned long
> parent)
>          |               ^~~~~~~~~~~~~~~~~~~
> 
> 
> vim +/ltc4282_round_rate +347 drivers/hwmon/ltc4282.c
> 
>    346  
>  > 347  long ltc4282_round_rate(struct clk_hw *hw, unsigned long rate,
>    348                          unsigned long *parent_rate)
>    349  {
>    350          int idx = find_closest(rate, ltc4282_out_rates,
>    351                                 ARRAY_SIZE(ltc4282_out_rates));
>    352  
>    353          return ltc4282_out_rates[idx];
>    354  }
>    355  
>  > 356  unsigned long ltc4282_recalc_rate(struct clk_hw *hw, unsigned long parent)
>    357  {
>    358          struct ltc4282_state *st = container_of(hw, struct ltc4282_state,
>    359                                                  clk_hw);
>    360          u32 clkdiv;
>    361          int ret;
>    362  
>    363          ret = regmap_read(st->map, LTC4282_CLK_DIV, &clkdiv);
>    364          if (ret)
>    365                  return 0;
>    366  
>    367          clkdiv = FIELD_GET(LTC4282_CLKOUT_MASK, clkdiv);
>    368          if (!clkdiv)
>    369                  return 0;
>    370          if (clkdiv == LTC4282_CLKOUT_INT)
>    371                  return LTC4282_CLKOUT_SYSTEM;
>    372  
>    373          return LTC4282_CLKOUT_CNV;
>    374  }
>    375  
> 

Arghh, I do need to see if I can add some test branch of my own to the test robot :/.
Anyways, will wait for some more reviewing before sending v3 to address this.

- Nuno Sá

  reply	other threads:[~2023-11-27  7:53 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-24 14:18 [PATCH v2 0/2] Add support for LTC4282 Nuno Sa via B4 Relay
2023-11-24 14:18 ` [PATCH v2 1/2] dt-bindings: hwmon: Add LTC4282 bindings Nuno Sa via B4 Relay
2023-11-25 11:56   ` Conor Dooley
2023-11-27  7:56     ` Nuno Sá
2023-11-27 17:33       ` Conor Dooley
2023-11-28 15:37   ` Rob Herring
2023-11-28 15:49     ` Nuno Sá
2023-11-24 14:18 ` [PATCH v2 2/2] hwmon: ltc4282: add support for the LTC4282 chip Nuno Sa via B4 Relay
2023-11-24 21:54   ` kernel test robot
2023-11-24 23:39   ` kernel test robot
2023-11-27  7:53     ` Nuno Sá [this message]
2023-11-27  8:10       ` Krzysztof Kozlowski
2023-11-27  8:12         ` Krzysztof Kozlowski
2023-11-27  8:44           ` Nuno Sá
2023-11-27 16:03           ` Andy Shevchenko
2023-11-28 16:50             ` Krzysztof Kozlowski
2023-11-28 17:01               ` Andy Shevchenko
2023-11-28 18:03               ` Guenter Roeck
2023-11-29  8:35                 ` Nuno Sá
2023-11-29  8:45                   ` Krzysztof Kozlowski
2023-11-29  8:56                     ` Nuno Sá
2023-11-29 14:10                     ` Linus Walleij
2023-11-29 14:13                       ` Krzysztof Kozlowski
2023-11-29 14:29                       ` Nuno Sá
2023-11-29 14:47                   ` Guenter Roeck
2023-11-29 16:09                     ` Nuno Sá
2023-11-27 10:20   ` kernel test robot
2023-11-29 14:49   ` Linus Walleij
2023-11-29 16:08     ` Nuno Sá
2023-11-29 16:18       ` Andy Shevchenko
2023-11-29 16:21         ` Nuno Sá
2023-11-29 17:07           ` Andy Shevchenko
2023-11-29 20:55       ` Linus Walleij
2023-11-30 10:20         ` Nuno Sá
2023-11-30 13:36           ` Andy Shevchenko
2023-11-30 14:39             ` Guenter Roeck
2023-11-30 15:20             ` Nuno Sá
2023-11-30 16:28               ` Guenter Roeck
2023-11-30 20:15               ` Linus Walleij
2023-12-01 12:34                 ` Nuno Sá
2023-12-01 13:40                   ` Linus Walleij
2023-12-01 15:24                     ` Nuno Sá
2023-12-01 15:47                       ` Andy Shevchenko
2023-12-01 16:04                         ` Guenter Roeck
2023-12-01 16:24                           ` Andy Shevchenko
2023-12-01 16:36                             ` Guenter Roeck
2023-12-01 16:29                           ` Nuno Sá
2023-12-01 16:46                             ` Guenter Roeck
2023-12-02  9:42                               ` Nuno Sá
2023-12-03 23:08                                 ` Linus Walleij
2023-12-04  8:20                                   ` Bartosz Golaszewski
2023-12-01 16:19                         ` Nuno Sá
2023-12-01 16:23                           ` Andy Shevchenko
2023-12-03 23:03                       ` Linus Walleij
2023-12-04  8:53                         ` Nuno Sá

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb2aaa4c69c88738499dfbf46ef93e3b81ca93cb.camel@gmail.com \
    --to=noname.nuno@gmail.com \
    --cc=andy@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=devnull+nuno.sa.analog.com@kernel.org \
    --cc=jdelvare@suse.com \
    --cc=krzk@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).