From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA514C7EE45 for ; Thu, 8 Jun 2023 08:40:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234678AbjFHIkP (ORCPT ); Thu, 8 Jun 2023 04:40:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235518AbjFHIjr (ORCPT ); Thu, 8 Jun 2023 04:39:47 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC3A4272B for ; Thu, 8 Jun 2023 01:39:45 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-514953b3aa6so440442a12.1 for ; Thu, 08 Jun 2023 01:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686213584; x=1688805584; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=T60h+W0DC18nxsqz7trELMiyE2WR3VGoPPEa5hHXx+Q=; b=iyAq0hoQryh8EvDralt4E7z318BYMnia1f7pBiPyvP4AF+SIcXMPpSRzvhVbxF1JUH zLxoD7Z/W1y3YSrJ3d8QsupMO4uBHea6A3IJoYsc1TCmiMPwTTn9EcowtqzR5BS3t8+X PtHWFRxR2ljn4Qh94PXTURZW7oabLNX41piHq2O4284la+7jYsDq6S/ll0SKqrA7Ook3 rqMg7w4WzEZZI3KX2DPDiQEPiFrvs09O7xsWFP+sbYSa7nLnusOd7HJyMkwBhxDOhCxz aQu1jVMiUskjy5c60nGo5TNqaNmBBd0NgP96Vm7fk4KFb0HAndFnWgmuYef6ZTMOPHS2 3wEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686213584; x=1688805584; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T60h+W0DC18nxsqz7trELMiyE2WR3VGoPPEa5hHXx+Q=; b=DR/yKT4CEG6SB1xpchWsCM5eu7ZjWS7qvhIruqDdYtCWlBA9nS4xkjYMOAwiwVsRWM 80jSAHV2ihpGHD0ZqafER+VxyD7glObRWhzTmM8M4uN5kDYukE5RfR2zkLZ1TlDXLKXI VXHy1S4zlKrDz22ziNXtoHeS/ZwvQH7zvOpFMl2SsMTtErVrJAl2yLTODeIa9hUUxL7j LFhgj+vPbjmchJC6FzV3WOBUBY/TOpB01Fv8+fwlnRqxPt84QA6ufcFks0IL0NbP+5Q/ rAqa9DbW2MyC0Ei41Ofi7qNPgRbru8x2dqWe4ujR1RT09n/6pPKuJNNrFVDn7mlUOEXE Se+w== X-Gm-Message-State: AC+VfDxgV/oI+YUtrfDK0rj96GyEm/C9R/GqkyWZtUumvm8v+J9jmcIT EPOCgwUXPGBEr/bZn8BOID3qkg== X-Google-Smtp-Source: ACHHUZ6+DFaOWxwBnwwn5BBCqCuWBnfpxcMfTyfrJlrYZN4vwswZ9T70B750ae6ffwKKz5XAccdyTg== X-Received: by 2002:a17:907:7e84:b0:978:6489:f9f with SMTP id qb4-20020a1709077e8400b0097864890f9fmr9130565ejc.52.1686213584247; Thu, 08 Jun 2023 01:39:44 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id k22-20020a1709065fd600b0096f830337e3sm384465ejv.129.2023.06.08.01.39.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jun 2023 01:39:43 -0700 (PDT) Message-ID: Date: Thu, 8 Jun 2023 10:39:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [v6 1/4] dt-bindings: pwm: Add ASPEED PWM Control documentation Content-Language: en-US To: Billy Tsai , "jdelvare@suse.com" , "linux@roeck-us.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "thierry.reding@gmail.com" , "u.kleine-koenig@pengutronix.de" , "corbet@lwn.net" , "p.zabel@pengutronix.de" , "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "patrick@stwcx.xyz" References: <20230608021839.12769-1-billy_tsai@aspeedtech.com> <20230608021839.12769-2-billy_tsai@aspeedtech.com> <4dffd320-8e30-fb30-6ded-79519afddc21@linaro.org> <61278e12-ba39-4503-ca74-a7118b0f6e99@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/06/2023 10:21, Billy Tsai wrote: > On 08/06/2023 09:47, Billy Tsai wrote: > >> > >> >> + > >> >> +allOf: > >> >> + - $ref: pwm.yaml# > >> >> + > >> >> +properties: > >> >> + compatible: > >> >> + enum: > >> >> + - aspeed,ast2600-pwm > >> >> + > >> >> + "#pwm-cells": > >> >> + const: 3 > >> > >> > 3 cells? For one PWM? What are they? > >> > >> channel, period and polarity. > > > Don't cut my responses. You wrote you have one PWM output, so only one > > channel. What do you put then in the channel? > > You need to put 0 in the cell of the channel, the example of the dts usage will like following: > > pwm0: pwm0@1e610000 { > compatible = "aspeed,ast2600-pwm"; > reg = <0x1e610000 0x8>; > #pwm-cells = <3>; > #address-cells = <1>; > #size-cells = <0>; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_pwm0_default>; > clocks = <&syscon ASPEED_CLK_AHB>; > resets = <&syscon ASPEED_RESET_PWM>; > status = "okay"; > }; > > pwm1: pwm1@1e610010 { > compatible = "aspeed,ast2600-pwm"; > reg = <0x1e610010 0x8>; > #pwm-cells = <3>; > #address-cells = <1>; > #size-cells = <0>; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_pwm1_default>; > clocks = <&syscon ASPEED_CLK_AHB>; > resets = <&syscon ASPEED_RESET_PWM>; > status = "okay"; BTW, these are not two PWM devices but one. I don't understand why you changed previous design into something like this, but this is not representing your hardware. Best regards, Krzysztof