From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shenhar, Talel" Subject: Re: [PATCH v2 2/2] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver Date: Wed, 5 Jun 2019 17:51:08 +0300 Message-ID: References: <1559731921-14023-1-git-send-email-talel@amazon.com> <1559731921-14023-3-git-send-email-talel@amazon.com> <20190605125055.GA3184@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190605125055.GA3184@kroah.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Greg KH Cc: nicolas.ferre@microchip.com, jason@lakedaemon.net, marc.zyngier@arm.com, mark.rutland@arm.com, mchehab+samsung@kernel.org, robh+dt@kernel.org, davem@davemloft.net, shawn.lin@rock-chips.com, tglx@linutronix.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dwmw@amazon.co.uk, benh@kernel.crashing.org, jonnyc@amazon.com, hhhawa@amazon.com, ronenk@amazon.com, hanochu@amazon.com, barakw@amazon.com, talel@amazon.com List-Id: devicetree@vger.kernel.org On 6/5/2019 3:50 PM, Greg KH wrote: > On Wed, Jun 05, 2019 at 01:52:01PM +0300, Talel Shenhar wrote: >> --- /dev/null >> +++ b/drivers/irqchip/irq-al-fic.c >> @@ -0,0 +1,289 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/** > No need for kernel-doc format style here. done > >> + * Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. > "or its affiliates"? You know the answer to this, don't keep us in > suspense. Put the proper copyright holder here please, otherwise this > is totally useless. > > Well, copyright notices are technically useless anyway, but lawyers like > to cargo-cult with the best of them, so it should be correct at the > least. This is the format we were asked to use and have been using. I am pinging them with your comment but I am likely not to get immediate response so I'm publishing v3 without changing the "affiliates" for now. > > thanks, > > greg k-h