From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Paweł Owoc" <frut3k7@gmail.com>, "Rob Herring" <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Naresh Solanki <Naresh.Solanki@9elements.com>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
Peter Yin <peteryin.openbmc@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Michal Simek <michal.simek@amd.com>,
Lakshmi Yadlapati <lakshmiy@us.ibm.com>,
Lukas Wunner <lukas@wunner.de>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Fabio Estevam <festevam@denx.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: trivial-devices: Add qca,spidev
Date: Tue, 6 Feb 2024 08:44:36 +0100 [thread overview]
Message-ID: <fb9767e0-c5a8-448f-b3f7-e6f81ef008e6@linaro.org> (raw)
In-Reply-To: <20240205191828.998783-1-frut3k7@gmail.com>
On 05/02/2024 20:18, Paweł Owoc wrote:
> Add Qualcomm QCA4024 to trivial devices.
>
> Signed-off-by: Paweł Owoc <frut3k7@gmail.com>
> ---
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 79dcd92c4a43..50efbdf2a735 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -309,6 +309,8 @@ properties:
> - plx,pex8648
> # Pulsedlight LIDAR range-finding sensor
> - pulsedlight,lidar-lite-v2
> + # Qualcomm QCA4024 Multi-mode Bluetooth and 802.15.4 SoC
> + - qca,spidev
There is no such hardware as spidev and you even mentioned it is called
QCA4024, not spidev. Please don't use that name but a real name.
Also, I have doubts that Bluetooth is a trivial device. Such devices
need supplies, have reset/powerdown GPIOs.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-06 7:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 19:18 [PATCH 2/2] dt-bindings: trivial-devices: Add qca,spidev Paweł Owoc
2024-02-06 7:44 ` Krzysztof Kozlowski [this message]
2024-02-06 16:11 ` frut3k7
2024-02-06 16:18 ` Krzysztof Kozlowski
2024-02-06 16:34 ` frut3k7
2024-02-06 16:53 ` Krzysztof Kozlowski
2024-02-06 17:20 ` frut3k7
-- strict thread matches above, loose matches on Subject: below --
2024-02-06 13:21 Paweł Owoc
2024-02-06 13:22 ` Krzysztof Kozlowski
2024-02-06 13:55 ` frut3k7
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb9767e0-c5a8-448f-b3f7-e6f81ef008e6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Naresh.Solanki@9elements.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=frut3k7@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lakshmiy@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lukas@wunner.de \
--cc=michal.simek@amd.com \
--cc=patrick.rudolph@9elements.com \
--cc=peteryin.openbmc@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox