From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0713B2F549F; Mon, 20 Oct 2025 09:59:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760954394; cv=none; b=Bw4cZ5CD/h/B48N3cqr+GlWP1ovatE2dfLMdZi1TeXq0fDl+CJCX4kiV8CG33UIk6mboIkM4S+9WdFxFk2jMvlHyzykGWaTbXpMMyXPSZBUMk3oVXAgERIv2ejGKNOprrsKeCBSDVi2d4h3Khs1tRMYzXsKsWpd4XWvsf/ZUWBY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760954394; c=relaxed/simple; bh=ceTjqZxROGT4tCOsh4a1HC9zi9dJeNYU0qKQYBS6T/Y=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=KlV4A6etT93Najk3CKLNBPpAPtHBRILTd/1UD0jGMJcDFSrVsTA7+AmRF0qdajoz1On/0rAGytmmSG5xdSJ7OtYjx9RUGy5Osj8dYSs+zcrneFXRp8efYgFVOBMgosKBREqKY962ic30PfkgY4Qlq586AcAzC3NFMxOBQRHC1oY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ezqf3hMo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ezqf3hMo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13B2DC113D0; Mon, 20 Oct 2025 09:59:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760954393; bh=ceTjqZxROGT4tCOsh4a1HC9zi9dJeNYU0qKQYBS6T/Y=; h=Date:Subject:To:References:From:In-Reply-To:From; b=ezqf3hMoB5jnKPS4DJHG/Pg0w0CBMBhQb1Vb9ShbsVCoiTO85JRDSaCiHmsDHy5Ay NpGG3pw/yqf3mEdbDn5x11ApurZUrQsRLExKcjhaEF+A685wwdCqtav1OKMnh/85jc UbTXDmCBUO8b1Eb8il8CyLFeNWJp8cSMslkoatW3ODyl0xiYeosKW4XN1y+dEIoBpG x9HSbhjU5W40P08avbwa3N9w7rDsGXA6os01LIa9Vcf+g1mbRLFwcBNLkCOVaqbGQi ZM9rqGN8nNnQ6YepAZLoHI05hIPSp/bwIW6u2ByfBJRg3rocNyGBhwk3X18FoDIhrG 6/mJFOTxZ/G8w== Message-ID: Date: Mon, 20 Oct 2025 11:59:49 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dt-bindings: mfd: aspeed,ast2x00-scu: allow #size-cells range To: Ryan Chen , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" References: <20251020020745.2004916-1-ryan_chen@aspeedtech.com> <6b30c646-cc52-4552-8311-86974c1459e7@kernel.org> <6cf7f86d-00f1-4939-aed0-4f97c1e0fd69@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 20/10/2025 10:50, Ryan Chen wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Monday, October 20, 2025 4:47 PM >> To: Ryan Chen ; Lee Jones ; >> Rob Herring ; Krzysztof Kozlowski ; >> Conor Dooley ; Joel Stanley ; Andrew >> Jeffery ; devicetree@vger.kernel.org; >> linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; >> linux-kernel@vger.kernel.org >> Subject: Re: [PATCH] dt-bindings: mfd: aspeed,ast2x00-scu: allow #size-cells >> range >> >> On 20/10/2025 10:18, Ryan Chen wrote: >>>> Subject: RE: [PATCH] dt-bindings: mfd: aspeed,ast2x00-scu: allow >>>> #size-cells range >>>> >>>>> Subject: Re: [PATCH] dt-bindings: mfd: aspeed,ast2x00-scu: allow >>>>> #size-cells range >>>>> >>>>> On 20/10/2025 08:39, Krzysztof Kozlowski wrote: >>>>>> On 20/10/2025 08:31, Ryan Chen wrote: >>>>>>>> Subject: Re: [PATCH] dt-bindings: mfd: aspeed,ast2x00-scu: allow >>>>>>>> #size-cells range >>>>>>>> >>>>>>>> On 20/10/2025 04:07, Ryan Chen wrote: >>>>>>>>> The #size-cells property in the Aspeed SCU binding is currently >>>>>>>>> fixed to a constant value of 1. However, newer SoCs (ex. >>>>>>>>> AST2700) may require two size cells to describe certain >>>>>>>>> subregions or >>>>>>>> >>>>>>>> "may"? So there is no issue yet? >>>>>>> >>>>>>> while I submit ast2700 platform, >>>>>> >>>>>> So there is no warning currently? Then don't mention. You cannot >>>>>> use argument of possible future warning as there is a warning >>>>>> needing to be fixed. This makes no sense. Like you add bug in your >>>>>> patchset and then send *different* patch claiming you are fixing a bug. >>>>>> >>>>>> >>>>>>> These warnings appear when validating the AST2700 EVB device tree. >>>>>>> The SCU nodes on AST2700 have subdevices (such as clock and reset >>>>>>> controllers) that require two address cells, which is not allowed >>>>>>> by the current `const: 1` constraint in the schema. >>>>>>> >>>>>>> Here is the related report: >>>>>>> https://lkml.org/lkml/2025/9/2/1165 >>>>>> >>>>>> This must be together, so we can review entire picture, not pieces >>>>>> by pieces. Organize your work correctly, so reviewing will be easy. >>>>>> >>>>> Anyway, I managed to find your original work and there is no need >>>>> for this patch at all. You don't have 64-bit sizes there. >>>> Thanks, I will keep #size-cells = <1>; for my next step. >>> >>> Hello Krzysztof, >>> Sory bothers you again. >>> After checking the AST2700 platform memory configuration, it supports >>> up to 8GB of DRAM. This requires using `#size-cells = <2>` for the >>> memory node, for >>> example: >>> >>> memory@400000000 { >>> device_type = "memory"; >>> reg = <0x4 0x00000000 0x0 0x40000000>; >>> }; >>> >>> Given this, what would be the proper way to proceed? >> >> >> I did not comment on memory node. Maybe I looked at wrong node, not sure, >> that's why this should not be discussed here but in that DTS patchset really. > > Understood, thanks for the clarification. > I'll move this discussion to the AST2700 DTS patchset and ensure that the > binding and DTS changes are reviewed together there. > The problem is that you refer to some very old patchset which is long gone from our mailboxes. Sending a necessary change month after the DTS patch is not making the discussion easy. Please always think how your patchset is supposed to be reviewed. Best regards, Krzysztof