From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42AAEC64EC4 for ; Fri, 17 Feb 2023 08:38:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229724AbjBQIin (ORCPT ); Fri, 17 Feb 2023 03:38:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229619AbjBQIim (ORCPT ); Fri, 17 Feb 2023 03:38:42 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6099A1BF0 for ; Fri, 17 Feb 2023 00:38:41 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id ez12so1487077edb.1 for ; Fri, 17 Feb 2023 00:38:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aotVjKdB3w06esRBunGunh97EJ04YUQLCEZCyWhQd9k=; b=df6K4Ks6N85m4BeBsuetyvq5ED9kxeN+MXWQ6tWrvqcrayBDZOQvLUZq+PatnBKOx6 Hou9Zny1NgQ7aOulocFLMA5Ol7oI+a3qZhLwVUzEBFlzsiw6ATSD0rtEeTcvl6HlC3Iu Z/jXrI9UDvDmcOLT/XgSbzRbihv1WOWC5Rfx/7SoXAznNUeovsYE9a/bdTOyMeLK2wng SgWVhhQT6d0NpDxHH1Z14rA72CsgdPP9kxWIgfV+lAfMkG+49sypbkF3plDhXvztVTxd 6lDVMWUb+Cauezs/fjktq/kyaIXB94cG83EEb3Bis8A5QclisLYdAV9gSvflVChF804F njGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aotVjKdB3w06esRBunGunh97EJ04YUQLCEZCyWhQd9k=; b=Ui7w0vwwUS3f++7p+habk872+oW+Cqp8ZPtXgp38HOCmTfq+VzAQG6dF03kD3wIvgj yun56AHEA0SDNMo4/sp7DX/LfLd1LLaCAhX6SMTHOnJdH1SkwYHLI5+QqImWdwTQlNXP JB5IDYnOBh9Kej4bBBgH5xKsHf2MgGOK4YvklUINxlkbxTCEyGM4VQmLPSth0E3mVK3Q 1+kU1XAgqEKayBBTOuziUhzV6sPrgaMyXG83dvN7TgJu+FbOX00PkYRzyVdUm8Q+xgZP 8xWYkwOUTDm0qeF1SGsgvv+6BwmOdJoZR0sLxmKlQLBsknNCHirkiSHt6brIm4BMT2dJ r9xw== X-Gm-Message-State: AO0yUKWfDVYRJuZta/SubiyEsVacN080HWoEVSjiMPaXvrU737axzEzU +8PRKmaMXBChNAMtUCwe2alzZBZoWrJw+08J X-Google-Smtp-Source: AK7set+/MdUcpE4Maq2Ti97rOUOiH4YBI2R73rUdx7sI33PB3L/2q6FL13Hu1VFrtA7SlI4oLARTpw== X-Received: by 2002:a17:907:2b11:b0:8ae:b008:9b5a with SMTP id gc17-20020a1709072b1100b008aeb0089b5amr6579929ejc.69.1676623119785; Fri, 17 Feb 2023 00:38:39 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id g23-20020a170906539700b008b128106fc7sm1850796ejo.46.2023.02.17.00.38.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Feb 2023 00:38:39 -0800 (PST) Message-ID: Date: Fri, 17 Feb 2023 09:38:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] ARM: dts: mvebu: Add support for Thecus N2350 board Content-Language: en-US To: Tony Dinh Cc: Andrew Lunn , Gregory Clement , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Krzysztof Kozlowski , Olof Johansson , Rob Herring , Sebastian Hesselbarth , linux-kernel@vger.kernel.org, soc@kernel.org References: <20230216011046.3306-1-mibodhi@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/02/2023 22:25, Tony Dinh wrote: > Hi Andrew, > Hi Krzysztof, > > On Thu, Feb 16, 2023 at 12:31 AM Krzysztof Kozlowski > wrote: >> >> On 16/02/2023 02:10, Tony Dinh wrote: >>> Thecus N2350 is a NAS based on Marvell Armada 385 SoC. >>> >>> Board Specification: >>> >>> - Marvel MV88F6820 Dual Core at 1GHz >>> - 1 GiB DDR4 RAM >>> - 4MB Macronix mx25l3205d SPI flash >>> - 512MB Hynix H27U4G8F2DTR-BC NAND flash >>> - I2C >>> - 2x USB 3.0 >>> - 1x GBE LAN port (PHY: Marvell 88E1510) >>> - 2x SATA (hot swap slots) >>> - 3x buttons >>> - 10x LEDS >>> - serial console >>> >>> Signed-off-by: Tony Dinh >>> --- >>> >>> arch/arm/boot/dts/Makefile | 1 + >>> arch/arm/boot/dts/armada-385-thecus-n2350.dts | 432 ++++++++++++++++++ >>> 2 files changed, 433 insertions(+) >>> create mode 100644 arch/arm/boot/dts/armada-385-thecus-n2350.dts >>> >>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >>> index d08a3c450..749790e6e 100644 >>> --- a/arch/arm/boot/dts/Makefile >>> +++ b/arch/arm/boot/dts/Makefile >>> @@ -1528,6 +1528,7 @@ dtb-$(CONFIG_MACH_ARMADA_38X) += \ >>> armada-385-linksys-rango.dtb \ >>> armada-385-linksys-shelby.dtb \ >>> armada-385-synology-ds116.dtb \ >>> + armada-385-thecus-n2350.dtb \ >>> armada-385-turris-omnia.dtb \ >>> armada-388-clearfog.dtb \ >>> armada-388-clearfog-base.dtb \ >>> diff --git a/arch/arm/boot/dts/armada-385-thecus-n2350.dts b/arch/arm/boot/dts/armada-385-thecus-n2350.dts >>> new file mode 100644 >>> index 000000000..38114d842 >>> --- /dev/null >>> +++ b/arch/arm/boot/dts/armada-385-thecus-n2350.dts >>> @@ -0,0 +1,432 @@ >>> +// SPDX-License-Identifier: (GPL-2.0 OR MIT) >>> +/* >>> + * Device Tree file for Thecus N2350 board >>> + * >>> + * Copyright (C) 2018-2023 Tony Dinh >>> + * Copyright (C) 2018 Manuel Jung >>> + */ >>> + >>> +/dts-v1/; >>> +#include >>> +#include >>> +#include "armada-385.dtsi" >>> + >>> +/ { >>> + model = "Thecus N2350"; >>> + compatible = "thecus,n2350", "marvell,armada385"; >> >> Missing vendor prefix documentation. I wanted to say: "missing new >> compatible documentation", but seems Marvell is missing these. Let's >> start documenting at least new compatibles in YAML? Like Rob proposed >> here for OMAP: >> https://lore.kernel.org/all/20230209173534.GA539622-robh@kernel.org/ > > I was under the impression that the Documentation patch has to be a > separate patch, as stated in > Documentation/devicetree/bindings/submitting-patches.rst. Should I > include documentation in this add-support patch? Yes, it must be separate patch and must be first in the patchset using new compatibles. Otherwise when we apply this, we get warnings of undocumented compatibles. Best regards, Krzysztof