From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5132E41D4FC; Mon, 14 Sep 2026 21:46:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789422372; cv=none; b=Tg8GZrIFaJGr+xn4gjr2x77LMfytaopUnkVlkgML3t7h1Nq6ikAcCblVXm4GjH0K3dzpelmHhNj0YB26PavYhGWQ38ZtJ0wwFnVwkUv8djNR/nWkZBeAuIkoeS5OSY583Z8NJCfVKsFVt9in2sHNcf1o0isvwmB9Cuwn/O0Bq0s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789422372; c=relaxed/simple; bh=L1uKDPAQWBAFiDYHRE0BwxVy5Q+AW/n7JQlS46VkzMc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=hjftDhNNbS38V/08K7pdhCxpq2M80gcmK3XtdW+zwL0PQgVBowxWItJ4sSKibaqqoVoMI+/k3TIER98bpnnjU0gIOvdizG+pCfDuWzsiMec0xKzc0r5ys1wsyh1Rm4kdYc4NEVDKZ1eSUkL3tSGF7+9MOzqmjsS5f++CsAxUuAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=DBTeMmmW; arc=none smtp.client-ip=210.118.77.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="DBTeMmmW" Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20260914214607euoutp0298349186b776b9ecf42a4bf0e7f739a9~VTims6U5X2157721577euoutp02a; Mon, 14 Sep 2026 21:46:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20260914214607euoutp0298349186b776b9ecf42a4bf0e7f739a9~VTims6U5X2157721577euoutp02a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1789422367; bh=Y4xIEcssZKWWAvbTH7TLXmgPRORXbepFbz/dh0noRbo=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=DBTeMmmWwRxbmdVpM20Nu8zuMdEAEFE+/dOsYDxgSS9crjm3ehe9Ra2pMO1CTwjkp LJzCe4yelf/KotZpTT/jbdq07pxfM6l3YcTDY3WqQJztYNMva+VobG8k87ffGM52eZ grgKhMAQmYnyS8kpgMxdkRkZ5nwuLdFZGx2RVOI4= Received: from eusmtip2.samsung.com (unknown [203.254.199.222]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20260914214607eucas1p2a107876f411b6812cdcc505d99eb9022~VTimB3gp42703627036eucas1p2x; Mon, 14 Sep 2026 21:46:07 +0000 (GMT) Received: from [192.168.1.44] (unknown [106.210.136.40]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20260914214605eusmtip2f9720a98b374ac418c59f98ea4b5c125~VTikOVkOp2978529785eusmtip2r; Mon, 14 Sep 2026 21:46:05 +0000 (GMT) Message-ID: Date: Mon, 14 Sep 2026 23:46:04 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 11/19] soc: starfive: Add jh7110-hdmi-subsystem driver To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lee Jones , Andy Yan , Philipp Zabel , Emil Renner Berthing , Hal Feng , Michael Turquette , Stephen Boyd , Brian Masney , Heiko Stuebner , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Dominique Belhachemi , Brian Masney , Jerome Brunet , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, mfd@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, Andy Yan , Marek Szyprowski , Maud Spierings , Graham Markall , Icenowy Zheng Content-Language: en-US From: Michal Wilczynski In-Reply-To: Content-Transfer-Encoding: 8bit X-CMS-MailID: 20260914214607eucas1p2a107876f411b6812cdcc505d99eb9022 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20260904132729eucas1p1bd78eb90feaf90b6265c13fc7bf43ada X-EPHeader: CA X-CMS-RootMailID: 20260904132729eucas1p1bd78eb90feaf90b6265c13fc7bf43ada References: <20260904-jh7110-clean-send-v3-0-484f9ae72715@samsung.com> <20260904-jh7110-clean-send-v3-11-484f9ae72715@samsung.com> On 9/7/26 10:23, Uwe Kleine-König wrote: > Hello Michael, > > On Fri, Sep 04, 2026 at 03:27:12PM +0200, Michal Wilczynski wrote: >> +#include >> [...] >> +#include > > Please don't add includes for as it introduces > many unneeded build dependencies. Either rely on > providing of_device_id (IMHO preferred), or > include directly. > > The same applies to two more patches in this series. > > Best regards > Uwe Thank you for your review. This will be fixed for v4. Best regards, -- Michal Wilczynski