From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A52B134D3 for ; Tue, 19 Dec 2023 08:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gtMjDmmK" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2cc3f5e7451so50159781fa.2 for ; Tue, 19 Dec 2023 00:48:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702975690; x=1703580490; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=J2mdxIH6SwaV5wLRowQyUYSmtGsRKst3D4PQbdAQRMU=; b=gtMjDmmKu1GSGnwdnwRbP35m7tDSMLG631tYhyZtRsjHGSmjaKxE3vYYDipQGmX9oV QbzfzsEVj7kUPGl0e3gK/NDqoKKDj58LYTfS/Wm8ayssNE/pi0KsMUxbNnIca/F9Eat4 85ohSnGFaoo4gVlbjHH2GEu0FCSHXaDKnEdnwLjbR7Z+xNDompLVziVRtetDz+mUkoD9 UBe1+jFk21mfnMnNMznInrUxk1UF0coftvWNqSEIsP4vlGfTt7w0TXgIgtuMCOvO28uj 2rdShvhxyeG5g00IzMsGUE8wzqz6DgJZ2kmM1tVoAlb9jXIYM/C8XyR3p84XnQBo9yey g+/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702975690; x=1703580490; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J2mdxIH6SwaV5wLRowQyUYSmtGsRKst3D4PQbdAQRMU=; b=KTWgzgUfN2n/9qPgOHvKgfF8OsWtGAs0c7fnirlVviPGrQzkCOZ9P7tWZZ474YAwtW EZO56+eJ23IJRrAyfp08XRd7NEVsOPGMUzStPAH5E6EmzxrHFbUA+refl5ZP05WJLWBl oZFXafYiJm/YOeH8lneZk8ho8YqOjdJprXE/EJT795HPCL+s+Jgkk+VDc24QrZ24yrOD 05XCeOn0h8zCcLf42c4GKTYgPAYxsvPIk+9X6XchpQb75A+F6K1g6pFWMDCuUnh3W9p3 8gZsbr8ANHF1kEimUVqeVPtJUbjlP1lJdpWaGKXMOOX8Sb41J1xwNai2afbwOLk11ggW B6Kw== X-Gm-Message-State: AOJu0YzPqzPqhUJCCpDTyu7XqD1rZiUt/yDCo9lb6oOP5/f1M+JfYOBB TRV8OogcBIw1+dZBaNhHGNvqFQ== X-Google-Smtp-Source: AGHT+IGjRRMHapmH8gfgShQO1nVf+WcloM6VGWz3/o4tsIMaS47VADmRI2ZtV9Cauacsb/q1gZz6GA== X-Received: by 2002:ac2:5ed0:0:b0:50e:274e:b880 with SMTP id d16-20020ac25ed0000000b0050e274eb880mr2027683lfq.72.1702975690535; Tue, 19 Dec 2023 00:48:10 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id ll9-20020a170907190900b00a1cbb289a7csm15014494ejc.183.2023.12.19.00.48.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Dec 2023 00:48:09 -0800 (PST) Message-ID: Date: Tue, 19 Dec 2023 09:48:07 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] dts: iot2050: Support IOT2050-SM variant Content-Language: en-US To: Jan Kiszka , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bao Cheng Su , Chao Zeng Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Li Hua Qian References: <11e0b0c8b828254567a8ff89820c067cacad2150.1702917360.git.jan.kiszka@siemens.com> <8b3daa3c-dbf8-4286-b04e-011cd9b0efa5@linaro.org> <4c31adc5-3fc5-47bc-9766-6d3d1eeddb65@siemens.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <4c31adc5-3fc5-47bc-9766-6d3d1eeddb65@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/12/2023 09:22, Jan Kiszka wrote: >> >>> + gpios = <&wkup_gpio0 53 GPIO_ACTIVE_HIGH>; >> >> Ditto >> > > This is adjusting the existing LED nodes in k3-am65-iot2050-common.dtsi, > not introducing new ones. We can add the color properties in a separate Then why aren't you overriding by phandle/label? > patch, but the node names are now part of the kernel ABI. Changing them > would break existing userland. You mean label. Why node names became the ABI? Which interface exposes them? > >> >>> + >>> +&dwc3_0 { >>> + assigned-clock-parents = <&k3_clks 151 4>, /* set REF_CLK to 20MHz i.e. PER0_PLL/48 */ >>> + <&k3_clks 151 9>; /* set PIPE3_TXB_CLK to CLK_12M_RC/256 (for HS only) */ >>> + /delete-property/ phys; >>> + /delete-property/ phy-names; >> >> If your board need to remove phys from the SoC node, something is wrong. >> Either your board or SoC. >> >> Any removal of properties in DTS is weird and unexpected. It deserves >> comments. > > This goes along disabling USB3 which is by default enabled via > k3-am65-iot2050-common-pg2.dtsi Isn't this mistake? Common part enables only these pieces which are working in common hardware SoM. If your common part of hardware, which DTSI should represent, has USB3 then why is it being disabled here? If common hardware design does not have USB3, then why is it being enabled in DTSI? > Best regards, Krzysztof