From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Biju Das <biju.das.jz@bp.renesas.com>,
Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Fabrizio Castro" <fabrizio.castro.jz@renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/5] dt-bindings: pwm: Add RZ/V2M PWM binding
Date: Tue, 22 Nov 2022 12:46:35 +0100 [thread overview]
Message-ID: <fbc13bdd-68f7-cc78-57a0-4efe62431cc4@linaro.org> (raw)
In-Reply-To: <20221118131641.469238-3-biju.das.jz@bp.renesas.com>
On 18/11/2022 14:16, Biju Das wrote:
> Add device tree bindings for the RZ/V2{M, MA} PWM Timer (PWM).
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Thank you for your patch. There is something to discuss/improve.
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - power-domains
> +
> +if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,r9a09g055-pwm
> +then:
> + required:
> + - resets
> +
> +allOf:
> + - $ref: pwm.yaml#
Put the if under allOf:
allOf:
- $ref...
- if:
then:
This allows easier growth.
With above:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-22 11:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 13:16 [PATCH 0/5] Add RZ/V2{M, MA} driver support Biju Das
2022-11-18 13:16 ` [PATCH 2/5] dt-bindings: pwm: Add RZ/V2M PWM binding Biju Das
2022-11-22 11:46 ` Krzysztof Kozlowski [this message]
2022-11-22 11:53 ` Biju Das
2022-11-24 8:43 ` Geert Uytterhoeven
2022-11-24 9:45 ` Biju Das
2022-11-18 13:16 ` [PATCH 4/5] arm64: dts: renesas: r9a09g011: Add pwm nodes Biju Das
2022-11-18 13:16 ` [PATCH 5/5] arm64: dts: renesas: rzv2m evk: Enable pwm Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbc13bdd-68f7-cc78-57a0-4efe62431cc4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox