Devicetree
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Markus Stockhausen <markus.stockhausen@gmx.de>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	netdev@vger.kernel.org, chris.packham@alliedtelesis.co.nz,
	daniel@makrotopia.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v13 09/11] net: mdio: realtek-rtl9300: Add support for RTL838x
Date: Mon, 10 Aug 2026 00:15:56 +0200	[thread overview]
Message-ID: <fbc693a0-37f8-4816-a655-ab7578aada02@lunn.ch> (raw)
In-Reply-To: <20260807171058.522833-10-markus.stockhausen@gmx.de>

On Fri, Aug 07, 2026 at 07:10:56PM +0200, Markus Stockhausen wrote:
> The MDIO driver has been prepared for multiple device support. Add all
> required bits for the RTL838x (aka maple) series. This is straightforward
> but some things are worth mentioning.
> 
> - The device has a lot in common with the RTL930x series. It has 28 ports,
>   4096 (Realtek) pages and 4 MMIO registers. With this a lot of the
>   existing RTL9300 defines could be reused. But to avoid confusion and
>   for better readability duplicate the defines with a proper prefix.
> - The MDIO engine has no fail bit. Thus the mask is set to zero.
> - There is only one SMI bus for 1G PHYs. No bus_map_base register exists.
> - The setup_controller() function needs no C45 setup but must activate
>   the PHY access.
> 
> As per the SDK the PHYs on a RTl83xx bus are mainly C22 driven. The
> polling unit works in C22 mode and the devicetree usually does not
> make use of the ethernet-phy-ieee802.3-c45 flag. Nevertheless there are
> some PHY MMD registers (e.g. EEE) that might be of interest for the
> future development of the hardware. Until that is really needed keep
> the C45 read/write helpers out of the driver.
> 
> Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

  parent reply	other threads:[~2026-08-09 22:16 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07 17:10 [PATCH net-next v13 00/11] net: mdio: realtek-rtl9300: Add RTL83xx support Markus Stockhausen
2026-08-07 17:10 ` [PATCH net-next v13 01/11] dt-bindings: net: realtek,rtl9301-mdio: Add RTL83xx series Markus Stockhausen
2026-08-07 17:10 ` [PATCH net-next v13 02/11] net: mdio: realtek-rtl9300: Add polling documentation Markus Stockhausen
2026-08-09 21:37   ` Andrew Lunn
2026-08-07 17:10 ` [PATCH net-next v13 03/11] net: phy: add (*notify_phy_attach/detach)() hooks to struct mii_bus Markus Stockhausen
2026-08-08 17:12   ` sashiko-bot
2026-08-09 21:44   ` Andrew Lunn
2026-08-07 17:10 ` [PATCH net-next v13 04/11] net: mdio: realtek-rtl9300: suppress sysfs bind/unbind attributes Markus Stockhausen
2026-08-08 17:12   ` sashiko-bot
2026-08-07 17:10 ` [PATCH net-next v13 05/11] net: mdio: realtek-rtl9300: Configure hardware polling during probing Markus Stockhausen
2026-08-09 21:51   ` Andrew Lunn
2026-08-07 17:10 ` [PATCH net-next v13 06/11] net: mdio: realtek-rtl9300: Add page tracking Markus Stockhausen
2026-08-09 21:58   ` Andrew Lunn
2026-08-07 17:10 ` [PATCH net-next v13 07/11] net: mdio: realtek-rtl9300: Increase MDIO timeout Markus Stockhausen
2026-08-07 17:10 ` [PATCH net-next v13 08/11] net: mdio: realtek-rtl9300: Check for C45 support during setup Markus Stockhausen
2026-08-08 17:12   ` sashiko-bot
2026-08-09 22:13   ` Andrew Lunn
2026-08-07 17:10 ` [PATCH net-next v13 09/11] net: mdio: realtek-rtl9300: Add support for RTL838x Markus Stockhausen
2026-08-08 17:12   ` sashiko-bot
2026-08-09 22:15   ` Andrew Lunn [this message]
2026-08-07 17:10 ` [PATCH net-next v13 10/11] net: mdio: realtek-rtl9300: Add support for RTL839x Markus Stockhausen
2026-08-09 22:19   ` Andrew Lunn
2026-08-07 17:10 ` [PATCH net-next v13 11/11] net: mdio: realtek-rtl9300: reword Kconfig and module description Markus Stockhausen
2026-08-09 22:19   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbc693a0-37f8-4816-a655-ab7578aada02@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=conor+dt@kernel.org \
    --cc=daniel@makrotopia.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=markus.stockhausen@gmx.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox