Re: [PATCH v4 07/10] dt-bindings: clock: qcom: Add NSS clock controller for IPQ5424 SoC

[Luo Jie <quic_luoj@quicinc.com>]

On 8/29/2025 3:38 PM, Krzysztof Kozlowski wrote:
> On Thu, Aug 28, 2025 at 06:32:20PM +0800, Luo Jie wrote:
>> NSS clock controller provides the clocks and resets to the networking
>> blocks such as PPE (Packet Process Engine) and UNIPHY (PCS) on IPQ5424
>> devices.
>>
>> Add support for the compatible string "qcom,ipq5424-nsscc" based on the
>> existing IPQ9574 NSS clock controller Device Tree binding. Additionally,
>> update the clock names for PPE and NSS for newer SoC additions like
>> IPQ5424 to use generic and reusable identifiers "nss" and "ppe" without
>> the clock rate suffix.
>>
>> Also add master/slave ids for IPQ5424 networking interfaces, which is
>> used by nss-ipq5424 driver for providing interconnect services using
>> icc-clk framework.
>>
>> Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
>> ---
>>   .../bindings/clock/qcom,ipq9574-nsscc.yaml         | 62 ++++++++++++++++++---
>>   include/dt-bindings/clock/qcom,ipq5424-nsscc.h     | 65 ++++++++++++++++++++++
>>   include/dt-bindings/interconnect/qcom,ipq5424.h    | 13 +++++
>>   include/dt-bindings/reset/qcom,ipq5424-nsscc.h     | 46 +++++++++++++++
>>   4 files changed, 178 insertions(+), 8 deletions(-)
> 
> 
> Are you going to change the binding in next version?
> 

As discussed in response to the comments in IPQ9574 bindings file, I am
not planning to change the binding itself in the next version.

> Best regards,
> Krzysztof
>