From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suzuki K Poulose Subject: Re: [PATCH 11/11] dts: tc2: Update coresight bindings for hardware ports Date: Tue, 11 Sep 2018 18:15:27 +0100 Message-ID: References: <1536661032-30481-1-git-send-email-suzuki.poulose@arm.com> <1536661032-30481-12-git-send-email-suzuki.poulose@arm.com> <20180911170113.GA27663@e107155-lin> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180911170113.GA27663@e107155-lin> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Sudeep Holla Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robh@kernel.org, frowand.list@gmail.com, devicetree@vger.kernel.org, mathieu.poirier@linaro.org, arm@kernel.org, Liviu Dudau , Lorenzo Pieralisi List-Id: devicetree@vger.kernel.org On 09/11/2018 06:01 PM, Sudeep Holla wrote: > On Tue, Sep 11, 2018 at 11:17:12AM +0100, Suzuki K Poulose wrote: >> Switch to the new coresight bindings >> > > I still see the below warnings: > > vexpress-v2p-ca15_a7.dtb: Warning (graph_child_address): > /replicator/in-ports: graph node has single child node 'port@0', > #address-cells/#size-cells are not necessary > vexpress-v2p-ca15_a7.dtb: Warning (graph_child_address): > /funnel@20040000/out-ports: graph node has single child node 'port@0', > #address-cells/#size-cells are not necessary > > I need the below patch to fix them, let me know if it looks OK, I can > amend and apply. Thanks for reporting. I purposefully added the "address-cells" and followed the format everywhere in the series thinking that, that is indeed the formal way of doing it, rather than having implicit port numbers. I can send an updated series fixing it everywhere. Regards Suzuki > > Regards, > Sudeep > > -->8 > > diff --git a/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts b/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts > index 3a5090616bc6..8b926c30ccd1 100644 > --- a/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts > +++ b/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts > @@ -443,11 +443,7 @@ > }; > > in-ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@0 { > - reg = <0>; > + port { > replicator_in_port0: endpoint { > remote-endpoint = <&funnel_out_port0>; > }; > @@ -462,11 +458,7 @@ > clocks = <&oscclk6a>; > clock-names = "apb_pclk"; > out-ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@0 { > - reg = <0>; > + port { > funnel_out_port0: endpoint { > remote-endpoint = > <&replicator_in_port0>; >