From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2519AC61DA4 for ; Sat, 18 Feb 2023 11:23:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229624AbjBRLXV (ORCPT ); Sat, 18 Feb 2023 06:23:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbjBRLXU (ORCPT ); Sat, 18 Feb 2023 06:23:20 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21F471420D for ; Sat, 18 Feb 2023 03:23:19 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id s7so579131lfc.11 for ; Sat, 18 Feb 2023 03:23:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zXrmfYPtbD+a4mYWOw7gzX5blmN63cfug46pUteyx84=; b=kzgT7ub+8SeOW/sL4cVFBuzPnNqoM6WqL8uiNYdBNlvtGlgd5lAOwrqaThKyUtzI6q hZPQ++Wa9Bdv294jRq4J9JThEpkCGjTVN/gjjmPdJBTIlwxde9hPV4HU3+iL4zJCiRh7 s2aJ0gekWlA7msRBLxF/MznErWfBfNzq/Mz3p8dssISUc70jYCJU1FcC0v5ctD+0KdUX ++eferbxRB4BEpZRn/gvHYPjkeUD88GbtQW7C8PS2zo8EOMuAgDxFCi4rluIgPqPVepn V7+Vrj2qW7APxl6KjZnwP03e9dmotmyN2gGqQn1nuUphnePzLuUcY9T2RSG8YvhrdKSj hEDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zXrmfYPtbD+a4mYWOw7gzX5blmN63cfug46pUteyx84=; b=plVcBflM5WuqwHOTx33l3PoZLbZ4sqX6Mx99m5gqfrr91CtXXQZgi7r7WH4F0Dmnhf 1nnw653op7G0cQZZUCWZ54qURIrL+U9h8lp30F71vsJVTk8Cveu+fLxIPOYxSjIkYihE jzYb1yJRf5MYlDTSh/Bi3mBkcS7OvTJxyMFDo4xrPMQT/I5RWVChjEkuBu478E/oPxUH ll11A2sqQiNGIlwPThSQW+UDYDiAE3RuELOt2ROrUobY+ntFfqRBKuL1qQNzu/KEMLmW qYWxagMMbvGhd34qKDzHcmtSBXqBooPWYFfEXYk/WhREl+allrIOjKUnuFwpOBBetXwa oW1w== X-Gm-Message-State: AO0yUKWyom5aeOXiO1XY9R+efwHJBy2S9J3iL7qtKMX1WCPmQgbP1YUf 4QbRAax9mcsaqlSnzGoT5g/BEQ== X-Google-Smtp-Source: AK7set/2Ym3B0dnJtwcPI9O9DneEz9RDbQ+ZtBmCZopQM4AHFgi7uc2wVb/PGBW+WJcbmcklTCJHtA== X-Received: by 2002:a19:a40e:0:b0:4d1:7923:3b92 with SMTP id q14-20020a19a40e000000b004d179233b92mr781116lfc.50.1676719397408; Sat, 18 Feb 2023 03:23:17 -0800 (PST) Received: from [192.168.1.101] (abxh184.neoplus.adsl.tpnet.pl. [83.9.1.184]) by smtp.gmail.com with ESMTPSA id m17-20020ac24ad1000000b004cb1e2f8f4dsm950902lfp.152.2023.02.18.03.23.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Feb 2023 03:23:17 -0800 (PST) Message-ID: Date: Sat, 18 Feb 2023 12:23:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible Content-Language: en-US To: Krzysztof Kozlowski , Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org Cc: marijn.suijten@somainline.org, Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Krishna Manikandan , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230217111316.306241-1-konrad.dybcio@linaro.org> <48cb00cd-961c-b72f-fba8-1842d658e289@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18.02.2023 11:14, Krzysztof Kozlowski wrote: > On 17/02/2023 22:13, Bryan O'Donoghue wrote: >> On 17/02/2023 12:24, Krzysztof Kozlowski wrote: >>> First, it would be nice to know what was the intention of Bryan's commit? >> >> Sorry I've been grazing this thread but, not responding. >> >> - qcom,dsi-ctrl-6g-qcm2290 >> >> is non-compliant with qcom,socid-dsi-ctrl which is our desired naming >> convention, so that's what the deprecation is about i.e. moving this >> compat to "qcom,qcm2290-dsi-ctrl" > > OK, then there was no intention to deprecate qcom,mdss-dsi-ctrl and it > should be left as allowed compatible. Not sure if we're on the same page. It wasn't intended to deprecate [1] "qcom,qcm2290-dsi-ctrl", "qcom-mdss-dsi-ctrl"; (newly-introduced in Bryan's cleanup patchset) but it was intended to deprecate [2] "qcom,dsi-ctrl-6g-qcm2290"; which was introduced long before that *and* used in the 6115 dt (and it still is in linux-next today, as my cleanup hasn't landed yet). [3] "qcom,dsi-ctrl-6g-qcm2290", "qcom,mdss-dsi-ctrl" was never used (and should never be, considering there's a proper compatible [1] now) so adding it to bindings didn't solve the undocumented-ness issue. Plus the fallback would have never worked back then, as the DSI hw revision check would spit out 2.4.1 or 2.4. which is SC7180 or SDM845 and then it would never match the base register, as they're waay different. Konrad > > Best regards, > Krzysztof >