RE: [PATCH 1/3] dt-bindings: gpio: realtek: Add realtek,rtd1625-gpio

Yu-Chun Lin [林祐君]
2026-04-01T11:13:20Z

> On Tue, Mar 31, 2026 at 07:38:33PM +0800, Yu-Chun Lin wrote:
> > + reg:
> > + items:
> > + - description: GPIO controller registers
> > + - description: GPIO interrupt registers
> > +
> > + interrupts:
> > + items:
> > + - description: Interrupt number of the assert GPIO interrupt, which
> is
> > + triggered when there is a rising edge.
> > + - description: Interrupt number of the deassert GPIO interrupt,
> which is
> > + triggered when there is a falling edge.
> > + - description: Interrupt number of the level-sensitive GPIO interrupt,
> > + triggered by a configured logic level.
> > +
> > + interrupt-controller: true
> > +
> > + "#interrupt-cells":
> > + const: 2
> > +
> > + gpio-ranges: true
> > +
> > + gpio-controller: true
> > +
> > + "#gpio-cells":
> > + const: 2
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - gpio-ranges
> > + - gpio-controller
> > + - "#gpio-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + gpio@89120 {
> > + compatible = "realtek,rtd1625-isom-gpio";
> > + reg = <0x89120 0x10>,
>
> 0x10 feels very short range.
>
> > + <0x89100 0x20>;
>
> And this means it's continuous. Are you sure these are two separate address
> spaces?
>
> Best regards,
> Krzysztof

Agreed, they are continuous. I will merge them into a single region in v2.

Best regards,
Yu-Chun