From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Naresh Solanki <naresh.solanki@9elements.com>,
Guenter Roeck <linux@roeck-us.net>,
krzysztof.kozlowski+dt@linaro.org,
Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Marcello Sylvester Bauer <sylv@sylv.io>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: Add MAX6639
Date: Sat, 5 Aug 2023 22:24:48 +0200 [thread overview]
Message-ID: <fbf6f9b0-dafe-8a4e-f3fe-f4a99c421abb@linaro.org> (raw)
In-Reply-To: <20230803144401.1151065-1-Naresh.Solanki@9elements.com>
On 03/08/2023 16:43, Naresh Solanki wrote:
> From: Marcello Sylvester Bauer <sylv@sylv.io>
>
> Add binding documentation for Maxim MAX6639 fan-speed controller.
>
> Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
> ---
...
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + fan-controller@10 {
> + compatible = "maxim,max6639";
> + reg = <0x10>;
I wished the examples were a bit more complete (not only 40% of your
properties). Well, that's not a stopper, so:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-05 20:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 14:43 [PATCH v3 1/2] dt-bindings: hwmon: Add MAX6639 Naresh Solanki
2023-08-04 15:48 ` Conor Dooley
2023-08-04 16:10 ` Guenter Roeck
2023-08-05 20:26 ` Krzysztof Kozlowski
2023-08-10 23:11 ` Rob Herring
2023-08-10 23:54 ` Guenter Roeck
2023-08-11 10:42 ` Naresh Solanki
2023-08-05 20:24 ` Krzysztof Kozlowski [this message]
2023-08-10 4:01 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbf6f9b0-dafe-8a4e-f3fe-f4a99c421abb@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=naresh.solanki@9elements.com \
--cc=robh+dt@kernel.org \
--cc=sylv@sylv.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).