From: "Andy-ld Lu (卢东)" <Andy-ld.Lu@mediatek.com>
To: "krzk@kernel.org" <krzk@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Wenbin Mei (梅文彬)" <Wenbin.Mei@mediatek.com>,
"robh@kernel.org" <robh@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v2 2/2] dt-bindings: mmc: mtk-sd: Add support for MT8196
Date: Wed, 9 Oct 2024 05:49:05 +0000 [thread overview]
Message-ID: <fbf8987f6b9428637342e73454ceb57ef0151b09.camel@mediatek.com> (raw)
In-Reply-To: <wuhrl54ojj4sjbk3qbm5jjgeupznbs4uhfedogmucjhvnbjbeh@vwvpeuiwgwli>
On Sun, 2024-09-29 at 21:43 +0200, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On Sun, Sep 29, 2024 at 03:44:06PM +0800, Andy-ld Lu wrote:
> > Extend the devicetree bindings to include the MT8196 mmc controller
> > by adding the compatible string 'mediatek,mt8196-mmc'.
>
> Your entire two-line sentence, says the same as commit msg and is
> pretty
> obvious from the diff. Say something useful instead, like describe
> the
> hardware differences.
>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Best regards,
> Krzysztof
Thanks for your suggestion, I would update in next change.
>
prev parent reply other threads:[~2024-10-09 5:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-29 7:44 [PATCH v2 0/2] Add mtk-sd support for MT8196 Andy-ld Lu
2024-09-29 7:44 ` [PATCH v2 1/2] mmc: mtk-sd: Add " Andy-ld Lu
2024-09-30 9:13 ` AngeloGioacchino Del Regno
2024-10-09 6:14 ` Andy-ld Lu (卢东)
2024-09-29 7:44 ` [PATCH v2 2/2] dt-bindings: " Andy-ld Lu
2024-09-29 19:43 ` Krzysztof Kozlowski
2024-10-09 5:49 ` Andy-ld Lu (卢东) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbf8987f6b9428637342e73454ceb57ef0151b09.camel@mediatek.com \
--to=andy-ld.lu@mediatek.com \
--cc=Wenbin.Mei@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).