From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 426A9C7EE2A for ; Thu, 11 May 2023 09:29:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237458AbjEKJ3Y (ORCPT ); Thu, 11 May 2023 05:29:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237579AbjEKJ24 (ORCPT ); Thu, 11 May 2023 05:28:56 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EAC67D88 for ; Thu, 11 May 2023 02:28:54 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-50bd875398dso12639392a12.1 for ; Thu, 11 May 2023 02:28:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683797332; x=1686389332; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4cHA3LraFcmGDTaIqGBRmZ93pU3RzjaRHQjlm2jCEjo=; b=JXsAiFr6M63ygBIRwO4p+SZCq+xy3AGLgKBO7UA59TEBVF4aWxdjr0p4qxNeUEGjpS H81i4v/xaK46iIye8Xmpu01rg7lYSiheY3PIB+CCDzt5YzJjFhlVGK6cDzMN5OFfbk6Y qKV2WIFlFJp7jQ7lDDIFe2H3uDkrFFpqGnljGuXHPaEJmYvNepbTQgYnJgxvDYmfyfYd 3+uXm+JJ+GXraAs9LbTUIlft65Y5QMEqEbbojSftk96J3vMHi21VsTEyqW+RljPYrk8v r2Bo7QkGIWN2r2S7i2awUnVRAZU4z/EwTYQqEqAL59gKoQXskq6/gkjUNaET3qd8WgDV JkrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683797332; x=1686389332; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4cHA3LraFcmGDTaIqGBRmZ93pU3RzjaRHQjlm2jCEjo=; b=aXzPMAg0WjI99VSsZnh6uzIqL9JSy65pzqCS5ANc9t21Z5GgxOkH2HGNM9Ms8PAkI8 GZOsnt3X3oAVBIIH4vrSXamVgJimnNTwFIgeRiyQboRNWeERPdTIzWuYxfn5ypebIRAe KMJzhGsNIIlHMm85DS5GX2byOHIpjuKoua/GOR8/o4MSLsISiUx8mIQtAAC+v3qwnxrx EiKfdP72DBr016EFGTmJtgqverQyOb04x8ch3o2pX7w6QWZ7Io0dtJJSAaXSZ5TAc6Al 1NiEXgjWdSacRcmUHwoUl+JOGbOdlgKgVJ9b0iEgBBt8/BH1Su3FdbQ6/25qiMYdpiko YHVA== X-Gm-Message-State: AC+VfDxGDrkiAoRH9vH5IUE3PhhQd2/Vu7dEoFlB0Xv4z/nktkMc0gpS 8JYHDXHoA5F0NNhGFda5QGwPtA== X-Google-Smtp-Source: ACHHUZ75ta179hLwDGK7JWKKo/Z4TJGh6O9B4U9ZlcNk2gja0S38wokx5miC8QiJ02RLTkBXBTk2LA== X-Received: by 2002:aa7:d659:0:b0:508:14f2:399c with SMTP id v25-20020aa7d659000000b0050814f2399cmr19284560edr.10.1683797332595; Thu, 11 May 2023 02:28:52 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:7e61:f14a:c3a4:809e? ([2a02:810d:15c0:828:7e61:f14a:c3a4:809e]) by smtp.gmail.com with ESMTPSA id l14-20020a056402028e00b00506addaaab0sm2709963edv.32.2023.05.11.02.28.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 May 2023 02:28:52 -0700 (PDT) Message-ID: Date: Thu, 11 May 2023 11:28:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] dt-bindings: iio: temperature: Add DT bindings for TMP006 Content-Language: en-US To: Anup Sharma , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald , broonie@kernel.org Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/05/2023 20:56, Anup Sharma wrote: > Add devicetree binding document for TMP006, IR thermopile sensor. Why? Where is any user of this? DTS? Driver? Subject: drop second/last, redundant "DT bindings for". The "dt-bindings" prefix is already stating that these are bindings. > > Signed-off-by: Anup Sharma > --- > .../bindings/iio/temperature/ti,tmp006.yaml | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/temperature/ti,tmp006.yaml > > diff --git a/Documentation/devicetree/bindings/iio/temperature/ti,tmp006.yaml b/Documentation/devicetree/bindings/iio/temperature/ti,tmp006.yaml > new file mode 100644 > index 000000000000..c6c5a4d10898 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/temperature/ti,tmp006.yaml > @@ -0,0 +1,38 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/temperature/ti,tmp006.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TI TMP006 IR thermopile sensor > + > +maintainers: > + - Peter Meerwald > + > +description: | > + TI TMP006 - Infrared Thermopile Sensor in Chip-Scale Package. > + https://cdn.sparkfun.com/datasheets/Sensors/Temp/tmp006.pdf > + > +properties: > + compatible: > + const: ti,tmp006 > + > + reg: > + maxItems: 1 Missing supply. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + tmp006@40 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation temperature-sensor? > + compatible = "ti,tmp006"; > + reg = <0x40>; > + }; > + }; Best regards, Krzysztof