From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vivek Sahu <vivek.sahu@oss.qualcomm.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Balakrishna Godavarthi <quic_bgodavar@quicinc.com>,
Rocky Liao <quic_rjliao@quicinc.com>,
quic_mohamull@quicinc.com, quic_hbandi@quicinc.com,
janaki.thota@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
linux-bluetooth@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: bluetooth: qcom,qcc2072-bt: Split to separate schema
Date: Tue, 17 Feb 2026 09:21:03 +0100 [thread overview]
Message-ID: <fc2cfbf9-bcb8-4acc-bb7d-a724adaec7a7@kernel.org> (raw)
In-Reply-To: <ae347961-4ad4-4772-bae4-7b698a05ac8b@oss.qualcomm.com>
On 17/02/2026 09:19, Vivek Sahu wrote:
>
>
> On 2/17/2026 1:43 PM, Dmitry Baryshkov wrote:
>> On Tue, Feb 17, 2026 at 01:11:05PM +0530, Vivek Sahu wrote:
>>>
>>>
>>> On 2/17/2026 12:04 PM, Dmitry Baryshkov wrote:
>>>> On Tue, Feb 17, 2026 at 11:17:30AM +0530, Vivek Sahu wrote:
>>>>> One big Qualcomm Bluetooth schema is hardly manageable: it lists all
>>>>> possible properties (19 supplies). Split qcom,qcc2072-bt to separate
>>>>> bindings, so device schema will be easier to read/maintain and list only
>>>>> relevant properties.
>>>>
>>>> How is it relevant to the commit? You are not splitting anything. You
>>>> are adding bindings for the new hardware.
>>> This commit is added on top of split schema where for each chip set there is
>>> separate binding yaml file instead of following up traditional
>>> method of updating qualcomm-bluetooth.yaml
>>
>> What does your commit message describe? What are you splitting?
>>
> The commit is about adding a binding for new chipset QCC2072 which is a
> WiFi/BT connectivity chip. It requires different firmware, so document
> it as a new compatible string.
> Seems like slit to separate schema is confusing sentence for this
> commit. I'll correct it in new patch set.
No, it is not confusing. It is just false, a lie. You are not doing what
your commit message said.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-17 8:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 5:47 [PATCH v4 0/2] Cover letter QCC2072 enablement Vivek Sahu
2026-02-17 5:47 ` [PATCH v4 1/2] dt-bindings: bluetooth: qcom,qcc2072-bt: Split to separate schema Vivek Sahu
2026-02-17 6:34 ` Dmitry Baryshkov
2026-02-17 7:41 ` Vivek Sahu
2026-02-17 8:13 ` Dmitry Baryshkov
2026-02-17 8:19 ` Vivek Sahu
2026-02-17 8:21 ` Krzysztof Kozlowski [this message]
2026-02-17 7:51 ` Krzysztof Kozlowski
2026-02-17 8:08 ` Vivek Sahu
2026-02-17 5:47 ` [PATCH v4 2/2] Bluetooth: qca: add QCC2072 support Vivek Sahu
2026-02-17 6:36 ` Dmitry Baryshkov
2026-02-17 7:47 ` Vivek Sahu
2026-02-17 7:53 ` Krzysztof Kozlowski
2026-02-17 12:51 ` Vivek Sahu
2026-02-17 13:01 ` Dmitry Baryshkov
2026-02-18 11:39 ` Vivek Sahu
2026-02-18 11:51 ` Vivek Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc2cfbf9-bcb8-4acc-bb7d-a724adaec7a7@kernel.org \
--to=krzk@kernel.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=janaki.thota@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=quic_bgodavar@quicinc.com \
--cc=quic_hbandi@quicinc.com \
--cc=quic_mohamull@quicinc.com \
--cc=quic_rjliao@quicinc.com \
--cc=robh@kernel.org \
--cc=vivek.sahu@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox