From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74666C77B6C for ; Thu, 13 Apr 2023 10:42:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229805AbjDMKmw (ORCPT ); Thu, 13 Apr 2023 06:42:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229792AbjDMKms (ORCPT ); Thu, 13 Apr 2023 06:42:48 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9813A198; Thu, 13 Apr 2023 03:42:37 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 6A80224E2AE; Thu, 13 Apr 2023 18:42:30 +0800 (CST) Received: from EXMBX171.cuchost.com (172.16.6.91) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 13 Apr 2023 18:42:30 +0800 Received: from [192.168.125.108] (183.27.97.249) by EXMBX171.cuchost.com (172.16.6.91) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 13 Apr 2023 18:42:29 +0800 Message-ID: Date: Thu, 13 Apr 2023 18:42:28 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v4 5/7] dt-bindings: usb: Add StarFive JH7110 USB Bindings YAML schemas Content-Language: en-US To: Krzysztof Kozlowski , Emil Renner Berthing , Conor Dooley , "Vinod Koul" , Kishon Vijay Abraham I , "Rob Herring" , Krzysztof Kozlowski , Pawel Laszczak , Greg Kroah-Hartman , Peter Chen , Roger Quadros , Philipp Zabel CC: , , , , , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Mason Huo" References: <20230406015216.27034-1-minda.chen@starfivetech.com> <20230406015216.27034-6-minda.chen@starfivetech.com> From: Minda Chen In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.97.249] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX171.cuchost.com (172.16.6.91) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/4/12 16:32, Krzysztof Kozlowski wrote: > On 06/04/2023 03:52, Minda Chen wrote: >> StarFive JH7110 platforms USB have a wrapper module around >> the Cadence USBSS-DRD controller. Add binding information doc >> for that. > > That's one of the most redundant subjects I saw. You basically used four > words for one meaning. These are not exactly synonyms, but they all are > either imprecise or meaning the same. > > Subject: drop second/last, redundant "Bindings YAML schemas". The > "dt-bindings" prefix is already stating that these are bindings. > > ok > >> >> Signed-off-by: Minda Chen >> Reviewed-by: Peter Chen >> --- >> .../bindings/usb/starfive,jh7110-usb.yaml | 136 ++++++++++++++++++ >> 1 file changed, 136 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/usb/starfive,jh7110-usb.yaml >> >> diff --git a/Documentation/devicetree/bindings/usb/starfive,jh7110-usb.yaml b/Documentation/devicetree/bindings/usb/starfive,jh7110-usb.yaml >> new file mode 100644 >> index 000000000000..c8b30b583854 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/usb/starfive,jh7110-usb.yaml >> @@ -0,0 +1,136 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/usb/starfive,jh7110-usb.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH7110 wrapper module for the Cadence USBSS-DRD controller > > What do you wrap here? Are you sure this is a wrapper? I think this is > just USB controller? > Since the previous version is wrapper module. I forgot change this. I will change to "StarFive JH7110 Cadence USBSS-DRD SoC controller" >> + >> +maintainers: >> + - Minda Chen >> + >> +properties: >> + compatible: >> + const: starfive,jh7110-usb >> + >> + reg: >> + items: >> + - description: OTG controller registers >> + - description: XHCI Host controller registers >> + - description: DEVICE controller registers >> + >> + reg-names: >> + items: >> + - const: otg >> + - const: xhci >> + - const: dev >> + >> + interrupts: >> + items: >> + - description: XHCI host controller interrupt >> + - description: Device controller interrupt >> + - description: OTG/DRD controller interrupt >> + >> + interrupt-names: >> + items: >> + - const: host >> + - const: peripheral >> + - const: otg >> + >> + clocks: >> + items: >> + - description: lpm clock >> + - description: stb clock >> + - description: apb clock >> + - description: axi clock >> + - description: utmi apb clock >> + >> + clock-names: >> + items: >> + - const: lpm >> + - const: stb >> + - const: apb >> + - const: axi >> + - const: utmi_apb >> + >> + resets: >> + items: >> + - description: PWRUP reset >> + - description: APB clock reset >> + - description: AXI clock reset >> + - description: UTMI_APB clock reset >> + >> + reset-names: >> + items: >> + - const: pwrup >> + - const: apb >> + - const: axi >> + - const: utmi >> + >> + starfive,stg-syscon: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + items: >> + items: > > Same problem as for other patches. > I am sorry about this. I should change this in this version. PCIe PHY dt-binding doc will be also changed. >> + - description: phandle to System Register Controller stg_syscon node. >> + - description: register offset of STG_SYSCONSAIF__SYSCFG register for USB. >> + description: >> + The phandle to System Register Controller syscon node and the offset >> + of STG_SYSCONSAIF__SYSCFG register for USB. >> + > > > Best regards, > Krzysztof >