public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 RESEND] ARM: dts: nuvoton: wpcm450: Add missing aliases for serial0/serial1
@ 2022-06-06 12:35 Jonathan Neuschäfer
  2022-06-06 12:54 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Neuschäfer @ 2022-06-06 12:35 UTC (permalink / raw)
  To: openbmc
  Cc: Jonathan Neuschäfer, Rob Herring, Krzysztof Kozlowski,
	devicetree, linux-kernel

Without these, /chosen/stdout-path = "serial0:115200n8", as done in
nuvoton-wpcm450-supermicro-x9sci-ln4f.dts, does not work.

Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---

v2:
- mention WPCM450 in the summary
---
 arch/arm/boot/dts/nuvoton-wpcm450.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
index 93595850a4c3c..57943bf5aa4a9 100644
--- a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
+++ b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
@@ -17,6 +17,8 @@ aliases {
 		gpio5 = &gpio5;
 		gpio6 = &gpio6;
 		gpio7 = &gpio7;
+		serial0 = &serial0;
+		serial1 = &serial1;
 	};

 	cpus {
--
2.35.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 RESEND] ARM: dts: nuvoton: wpcm450: Add missing aliases for serial0/serial1
  2022-06-06 12:35 [PATCH v2 RESEND] ARM: dts: nuvoton: wpcm450: Add missing aliases for serial0/serial1 Jonathan Neuschäfer
@ 2022-06-06 12:54 ` Krzysztof Kozlowski
  2022-06-06 12:57   ` Jonathan Neuschäfer
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-06 12:54 UTC (permalink / raw)
  To: Jonathan Neuschäfer, openbmc
  Cc: Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel

On 06/06/2022 14:35, Jonathan Neuschäfer wrote:
> Without these, /chosen/stdout-path = "serial0:115200n8", as done in
> nuvoton-wpcm450-supermicro-x9sci-ln4f.dts, does not work.
> 
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
> 
> v2:
> - mention WPCM450 in the summary
> ---
>  arch/arm/boot/dts/nuvoton-wpcm450.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> index 93595850a4c3c..57943bf5aa4a9 100644
> --- a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> +++ b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> @@ -17,6 +17,8 @@ aliases {
>  		gpio5 = &gpio5;
>  		gpio6 = &gpio6;
>  		gpio7 = &gpio7;
> +		serial0 = &serial0;
> +		serial1 = &serial1;

Serial aliases might be wired differently per board, so this should go
to board DTS instead.


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 RESEND] ARM: dts: nuvoton: wpcm450: Add missing aliases for serial0/serial1
  2022-06-06 12:54 ` Krzysztof Kozlowski
@ 2022-06-06 12:57   ` Jonathan Neuschäfer
  0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Neuschäfer @ 2022-06-06 12:57 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Jonathan Neuschäfer, openbmc, Rob Herring,
	Krzysztof Kozlowski, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

On Mon, Jun 06, 2022 at 02:54:21PM +0200, Krzysztof Kozlowski wrote:
> On 06/06/2022 14:35, Jonathan Neuschäfer wrote:
> > Without these, /chosen/stdout-path = "serial0:115200n8", as done in
> > nuvoton-wpcm450-supermicro-x9sci-ln4f.dts, does not work.
> > 
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> > ---
> > 
> > v2:
> > - mention WPCM450 in the summary
> > ---
> >  arch/arm/boot/dts/nuvoton-wpcm450.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> > index 93595850a4c3c..57943bf5aa4a9 100644
> > --- a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> > +++ b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> > @@ -17,6 +17,8 @@ aliases {
> >  		gpio5 = &gpio5;
> >  		gpio6 = &gpio6;
> >  		gpio7 = &gpio7;
> > +		serial0 = &serial0;
> > +		serial1 = &serial1;
> 
> Serial aliases might be wired differently per board, so this should go
> to board DTS instead.

Ok, I'll do that.


Jonathan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-06-06 12:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-06 12:35 [PATCH v2 RESEND] ARM: dts: nuvoton: wpcm450: Add missing aliases for serial0/serial1 Jonathan Neuschäfer
2022-06-06 12:54 ` Krzysztof Kozlowski
2022-06-06 12:57   ` Jonathan Neuschäfer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox