From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8084BC433F5 for ; Sat, 12 Mar 2022 14:20:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229791AbiCLOVf (ORCPT ); Sat, 12 Mar 2022 09:21:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229509AbiCLOVf (ORCPT ); Sat, 12 Mar 2022 09:21:35 -0500 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDD9260A9E; Sat, 12 Mar 2022 06:20:28 -0800 (PST) X-UUID: 3f792280c01248ee9e0fd8e9dcc7048b-20220312 X-UUID: 3f792280c01248ee9e0fd8e9dcc7048b-20220312 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 891404891; Sat, 12 Mar 2022 22:20:23 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Sat, 12 Mar 2022 22:20:21 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 12 Mar 2022 22:20:21 +0800 Message-ID: Subject: Re: [PATCH 5/5] dt-bindings: mediatek: mt8195: add mt8195-mt6359-max98390-rt5682 document From: Trevor Wu To: Rob Herring CC: , , , , , , , , , Date: Sat, 12 Mar 2022 22:20:21 +0800 In-Reply-To: References: <20220308072435.22460-1-trevor.wu@mediatek.com> <20220308072435.22460-6-trevor.wu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 2022-03-10 at 16:18 -0600, Rob Herring wrote: > On Tue, Mar 08, 2022 at 03:24:35PM +0800, Trevor Wu wrote: > > This patch adds document for mt8195 board with mt6359, max98390 and > > rt5682. > > > > Signed-off-by: Trevor Wu > > --- > > .../sound/mt8195-mt6359-max98390-rt5682.yaml | 61 > > +++++++++++++++++++ > > 1 file changed, 61 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/mt8195- > > mt6359-max98390-rt5682.yaml > > > > diff --git a/Documentation/devicetree/bindings/sound/mt8195-mt6359- > > max98390-rt5682.yaml > > b/Documentation/devicetree/bindings/sound/mt8195-mt6359-max98390- > > rt5682.yaml > > new file mode 100644 > > index 000000000000..7ec14d61b109 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/mt8195-mt6359- > > max98390-rt5682.yaml > > @@ -0,0 +1,61 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > > https://urldefense.com/v3/__http://devicetree.org/schemas/sound/mt8195-mt6359-max98390-rt5682.yaml*__;Iw!!CTRNKA9wMg0ARbw!zb7eaqdAQfuyPpP5m31L3Q5pdCulclJgnygkkMgYh2M6segUZedd-cYz51-5Q2XDCA$ > > > > +$schema: > > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!zb7eaqdAQfuyPpP5m31L3Q5pdCulclJgnygkkMgYh2M6segUZedd-cYz5187C1ArQA$ > > > > + > > +title: Mediatek MT8195 with MT6359, MAX98390 and RT5682 ASoC sound > > card driver > > + > > +maintainers: > > + - Trevor Wu > > + > > +description: > > + This binding describes the MT8195 sound card. > > + > > +properties: > > + compatible: > > + const: mediatek,mt8195_mt6359_max98390_rt5682 > > You have nodes for each of these components, why do we need new > compatible string for each combination. You can figure out the > combination by looking at each of those nodes. > > Second, why does each combination need a new schema doc? > > Rob Hi Rob, I'm not sure whether I can reuse the old schema doc because of the doc name and compatible string seems to be specifically for the codec combination. If I want to reuse the old schema doc, should I change the doc name or compatible string? Make the naming more general. Thanks, Trevor