From: David Lechner <dlechner@baylibre.com>
To: Sheng Kun Chang <nothingchang@mirrorstack.ai>, jic23@kernel.org
Cc: lars@metafoo.de, Michael.Hennerich@analog.com,
nuno.sa@analog.com, andy@kernel.org, gregkh@linuxfoundation.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Move adis16203 inclinometer driver out of staging
Date: Sat, 4 Apr 2026 11:29:28 -0500 [thread overview]
Message-ID: <fc46eb9c-abe0-49af-9f19-fa06f6cf2847@baylibre.com> (raw)
In-Reply-To: <20260401162458.88110-1-nothingchang@mirrorstack.ai>
On 4/1/26 11:24 AM, Sheng Kun Chang wrote:
> This series moves the ADIS16203 Programmable 360 Degrees Inclinometer
> driver out of staging and into drivers/iio/accel/.
>
> The driver already uses standard IIO channel interfaces and devm
> managed APIs. The only missing piece was devicetree binding
> documentation, which is added in patch 1.
>
> Patch 1: Add devicetree binding documentation
> Patch 2: Fix MODULE_LICENSE to match SPDX identifier
> Patch 3: Move the driver from staging to drivers/iio/accel/
>
> Sheng Kun Chang (3):
> dt-bindings: iio: accel: add binding for adi,adis16203
> staging: iio: adis16203: align MODULE_LICENSE with SPDX identifier
> iio: accel: move adis16203 out of staging
>
> .../bindings/iio/accel/adi,adis16203.yaml | 52 +++++++++++++++++++
> drivers/iio/accel/Kconfig | 12 +++++
> drivers/iio/accel/Makefile | 1 +
> drivers/{staging => }/iio/accel/adis16203.c | 2 +-
> drivers/staging/iio/Kconfig | 1 -
> drivers/staging/iio/Makefile | 1 -
> drivers/staging/iio/accel/Kconfig | 19 -------
> drivers/staging/iio/accel/Makefile | 6 ---
> 8 files changed, 66 insertions(+), 28 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml
> rename drivers/{staging => }/iio/accel/adis16203.c (99%)
> delete mode 100644 drivers/staging/iio/accel/Kconfig
> delete mode 100644 drivers/staging/iio/accel/Makefile
>
Quite a few people have attempted this already [1]. It is likely not as simple
as renaming the file. Please review and give a summary of all of the previous
attempts so that all of us reviewers don't have to go read all of those messages.
[1]: https://lore.kernel.org/linux-iio/?q=adis16203
And when reading those messages, you should find that the rename patch needs
to have the full diff (I think this is the --no-renames option to git
format-patch). This way we can review the driver in it's current state one
more time to make sure we didn't miss any cleanups that are needed first.
prev parent reply other threads:[~2026-04-04 16:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 16:24 [PATCH 0/3] Move adis16203 inclinometer driver out of staging Sheng Kun Chang
2026-04-01 16:24 ` [PATCH 1/3] dt-bindings: iio: accel: add binding for adi,adis16203 Sheng Kun Chang
2026-04-02 8:45 ` Krzysztof Kozlowski
2026-04-01 16:24 ` [PATCH 2/3] staging: iio: adis16203: align MODULE_LICENSE with SPDX identifier Sheng Kun Chang
2026-04-02 8:41 ` Andy Shevchenko
2026-04-02 11:27 ` Greg KH
2026-04-01 16:24 ` [PATCH 3/3] iio: accel: move adis16203 out of staging Sheng Kun Chang
2026-04-02 8:43 ` [PATCH 0/3] Move adis16203 inclinometer driver " Andy Shevchenko
2026-04-04 16:29 ` David Lechner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc46eb9c-abe0-49af-9f19-fa06f6cf2847@baylibre.com \
--to=dlechner@baylibre.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nothingchang@mirrorstack.ai \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox