From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 4/4] dt-bindings: watchdog: samsung-wdt: Split if:then: and constrain more
Date: Tue, 2 Sep 2025 12:06:48 -0700 [thread overview]
Message-ID: <fc652345-1dcd-4adf-a472-907c9692de89@roeck-us.net> (raw)
In-Reply-To: <20250830-watchdog-s3c-cleanup-v1-4-837ae94a21b5@linaro.org>
On Sat, Aug 30, 2025 at 12:19:00PM +0200, Krzysztof Kozlowski wrote:
> Binding defined two if:then: blocks covering different conditions but
> not fully constraining the properties per each variant:
> 1. "if:" to require samsung,syscon-phandle,
> 2. "if:" with "else:" to narrow number of clocks and require or disallow
> samsung,cluster-index.
>
> This still did not cover following cases:
> 1. Disallow samsung,syscon-phandle when not applicable,
> 2. Narrow samsung,cluster-index to [0, 1], for SoCs with only two
> clusters.
>
> Solving this in current format would lead to spaghetti code, so re-write
> entire "if:then:" approach into mutually exclusive cases so each SoC
> appears only in one "if:" block. This allows to forbid
> samsung,syscon-phandle for S3C6410, and narrow samsung,cluster-index
> to [0, 1].
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Guenter Roeck <linux@roeck-us.net>
prev parent reply other threads:[~2025-09-02 19:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 10:18 [PATCH 0/4] watchdog: s3c2410_wdt: Simplify, cleanup and drop S3C2410 Krzysztof Kozlowski
2025-08-30 10:18 ` [PATCH 1/4] dt-bindings: watchdog: samsung-wdt: Define cluster constraints top-level Krzysztof Kozlowski
2025-09-01 20:10 ` Rob Herring (Arm)
2025-09-02 19:05 ` Guenter Roeck
2025-08-30 10:18 ` [PATCH 2/4] watchdog: s3c2410_wdt: Drop S3C2410 support Krzysztof Kozlowski
2025-09-02 19:06 ` Guenter Roeck
2025-08-30 10:18 ` [PATCH 3/4] dt-bindings: watchdog: samsung-wdt: Drop S3C2410 Krzysztof Kozlowski
2025-09-01 20:10 ` Rob Herring (Arm)
2025-09-02 19:06 ` Guenter Roeck
2025-08-30 10:19 ` [PATCH 4/4] dt-bindings: watchdog: samsung-wdt: Split if:then: and constrain more Krzysztof Kozlowski
2025-09-01 14:29 ` Alim Akhtar
2025-09-01 20:13 ` Rob Herring (Arm)
2025-09-02 19:06 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc652345-1dcd-4adf-a472-907c9692de89@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).