devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: Harald Geyer <harald@ccbib.org>
Cc: devicetree@vger.kernel.org,
	Marek Vasut <marek.vasut+renesas@gmail.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] regulator: gpio: Reword the binding document
Date: Sat, 2 Mar 2019 15:55:53 +0100	[thread overview]
Message-ID: <fc83b1ce-52e5-b197-4679-69b576233726@gmail.com> (raw)
In-Reply-To: <E1gw2Ll-0000MN-40@stardust.g4.wien.funkfeuer.at>

On 2/19/19 11:10 AM, Harald Geyer wrote:
> Marek Vasut writes:
>> On 2/18/19 11:18 PM, Harald Geyer wrote:
>>> From the explanations provided by Mark it is clear that this property
>>> is an artifact of the implementation in linux. I think we should document
>>> is as such. How about:
>>>
>>> gpios-states : On operating systems, that don't support reading back gpio
>>> 	       values in output mode (most notably linux), this array
>>> 	       provides the state of GPIO pins set when requesting them
>>> 	       from the gpio controller.
>>
>> That's good.
>>
>>> Systems, that are capable of
>>> 	       preserving state when requesting the lines, are free to
>>> 	       ignore this property.
>>
>> Are they ?
> 
> I think so. Also this seems to be what Mark wrote yesterday:
> 
> | With the GPIO API as it stands it is unfortunately not possible to
> | preserve the state, if the API were fixed we'd preserve state.
> 
>> I think there are systems which depend on preconfiguring the
>> GPIO according to this property.
> 
> These systems need to preconfigure the GPIOs in firmware anyway, so
> they should be fine so long as the driver preserves state.
> 
> Since the original wording doesn't give any guarantees, I think the
> new wording doesn't change anything. It just makes it clearer, that
> there are no guarantees and that some drivers will happily overwrite
> state when this property is absent.

OK, so how can we move forward with this ? We discussed a lot, but I
don't know what we should do about the patch.

-- 
Best regards,
Marek Vasut

  reply	other threads:[~2019-03-02 14:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-16 17:48 [PATCH] regulator: gpio: Reword the binding document marek.vasut
2019-02-16 20:20 ` Harald Geyer
2019-02-16 21:37   ` Marek Vasut
2019-02-17 14:26     ` Harald Geyer
2019-02-17 14:45       ` Marek Vasut
2019-02-17 20:00         ` Harald Geyer
2019-02-17 21:57           ` Marek Vasut
2019-02-18 10:04             ` Harald Geyer
2019-02-18 18:58               ` Marek Vasut
2019-02-18 22:18                 ` Harald Geyer
2019-02-19  2:51                   ` Marek Vasut
2019-02-19 10:10                     ` Harald Geyer
2019-03-02 14:55                       ` Marek Vasut [this message]
2019-03-03 16:07                         ` Harald Geyer
2019-03-03 16:08                           ` Marek Vasut
2019-02-18 18:01             ` Mark Brown
2019-02-18 17:56       ` Mark Brown
2019-02-18 17:54     ` Mark Brown
2019-02-18  9:30 ` Geert Uytterhoeven
2019-02-18 18:36   ` Marek Vasut
2019-02-18 19:21     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc83b1ce-52e5-b197-4679-69b576233726@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=harald@ccbib.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=marek.vasut+renesas@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).