* [PATCH v1 0/1] ARM: dts: aspeed: system1: IBM System1 BMC update @ 2024-07-31 21:47 Ninad Palsule 2024-07-31 21:47 ` [PATCH v1 1/1] " Ninad Palsule 2024-08-01 15:29 ` [PATCH v1 0/1] " Rob Herring (Arm) 0 siblings, 2 replies; 7+ messages in thread From: Ninad Palsule @ 2024-07-31 21:47 UTC (permalink / raw) To: robh+dt, krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel, eajames Cc: Ninad Palsule Hello, This patch only applies to openbmc/linux. The max31785 pmbus driver changes are not available in the upstream yet. I will try to send those changes upstream. Ninad Palsule (1): ARM: dts: aspeed: system1: IBM System1 BMC update .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 96 +++++++++++++++++++ 1 file changed, 96 insertions(+) -- 2.43.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v1 1/1] ARM: dts: aspeed: system1: IBM System1 BMC update 2024-07-31 21:47 [PATCH v1 0/1] ARM: dts: aspeed: system1: IBM System1 BMC update Ninad Palsule @ 2024-07-31 21:47 ` Ninad Palsule 2024-07-31 21:57 ` Eddie James 2024-08-01 15:29 ` [PATCH v1 0/1] " Rob Herring (Arm) 1 sibling, 1 reply; 7+ messages in thread From: Ninad Palsule @ 2024-07-31 21:47 UTC (permalink / raw) To: robh+dt, krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel, eajames Cc: Ninad Palsule Updated MAX31785a pmbus based fans in the device tree. Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> --- .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 96 +++++++++++++++++++ 1 file changed, 96 insertions(+) diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts index f3efecc7eb8d0..f96b299d743ba 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts @@ -764,17 +764,113 @@ regulator@43 { }; }; + &i2c6 { status = "okay"; fan-controller@52 { compatible = "maxim,max31785a"; reg = <0x52>; + #address-cells = <1>; + #size-cells = <0>; + + fan0: fan@0 { + compatible = "pmbus-fan"; + reg = <0>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; + + fan1: fan@1 { + compatible = "pmbus-fan"; + reg = <1>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; + + fan2: fan@2 { + compatible = "pmbus-fan"; + reg = <2>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; + + fan3: fan@3 { + compatible = "pmbus-fan"; + reg = <3>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; + + fan4: fan@4 { + compatible = "pmbus-fan"; + reg = <4>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; }; fan-controller@54 { compatible = "maxim,max31785a"; reg = <0x54>; + #address-cells = <1>; + #size-cells = <0>; + + fan5: fan@0 { + compatible = "pmbus-fan"; + reg = <0>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; + + fan6: fan@1 { + compatible = "pmbus-fan"; + reg = <1>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; }; eeprom@55 { -- 2.43.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v1 1/1] ARM: dts: aspeed: system1: IBM System1 BMC update 2024-07-31 21:47 ` [PATCH v1 1/1] " Ninad Palsule @ 2024-07-31 21:57 ` Eddie James 0 siblings, 0 replies; 7+ messages in thread From: Eddie James @ 2024-07-31 21:57 UTC (permalink / raw) To: Ninad Palsule, robh+dt, krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On 7/31/24 16:47, Ninad Palsule wrote: > Updated MAX31785a pmbus based fans in the device tree. > > Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> > --- > .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 96 +++++++++++++++++++ > 1 file changed, 96 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts > index f3efecc7eb8d0..f96b299d743ba 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts > @@ -764,17 +764,113 @@ regulator@43 { > }; > }; > > + Don't really need the white space here, but no worries. Reviewed-by: Eddie James <eajames@linux.ibm.com> > &i2c6 { > status = "okay"; > > fan-controller@52 { > compatible = "maxim,max31785a"; > reg = <0x52>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + fan0: fan@0 { > + compatible = "pmbus-fan"; > + reg = <0>; > + tach-pulses = <2>; > + maxim,fan-rotor-input = "tach"; > + maxim,fan-pwm-freq = <25000>; > + maxim,fan-dual-tach; > + maxim,fan-no-watchdog; > + maxim,fan-no-fault-ramp; > + maxim,fan-ramp = <2>; > + maxim,fan-fault-pin-mon; > + }; > + > + fan1: fan@1 { > + compatible = "pmbus-fan"; > + reg = <1>; > + tach-pulses = <2>; > + maxim,fan-rotor-input = "tach"; > + maxim,fan-pwm-freq = <25000>; > + maxim,fan-dual-tach; > + maxim,fan-no-watchdog; > + maxim,fan-no-fault-ramp; > + maxim,fan-ramp = <2>; > + maxim,fan-fault-pin-mon; > + }; > + > + fan2: fan@2 { > + compatible = "pmbus-fan"; > + reg = <2>; > + tach-pulses = <2>; > + maxim,fan-rotor-input = "tach"; > + maxim,fan-pwm-freq = <25000>; > + maxim,fan-dual-tach; > + maxim,fan-no-watchdog; > + maxim,fan-no-fault-ramp; > + maxim,fan-ramp = <2>; > + maxim,fan-fault-pin-mon; > + }; > + > + fan3: fan@3 { > + compatible = "pmbus-fan"; > + reg = <3>; > + tach-pulses = <2>; > + maxim,fan-rotor-input = "tach"; > + maxim,fan-pwm-freq = <25000>; > + maxim,fan-dual-tach; > + maxim,fan-no-watchdog; > + maxim,fan-no-fault-ramp; > + maxim,fan-ramp = <2>; > + maxim,fan-fault-pin-mon; > + }; > + > + fan4: fan@4 { > + compatible = "pmbus-fan"; > + reg = <4>; > + tach-pulses = <2>; > + maxim,fan-rotor-input = "tach"; > + maxim,fan-pwm-freq = <25000>; > + maxim,fan-dual-tach; > + maxim,fan-no-watchdog; > + maxim,fan-no-fault-ramp; > + maxim,fan-ramp = <2>; > + maxim,fan-fault-pin-mon; > + }; > }; > > fan-controller@54 { > compatible = "maxim,max31785a"; > reg = <0x54>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + fan5: fan@0 { > + compatible = "pmbus-fan"; > + reg = <0>; > + tach-pulses = <2>; > + maxim,fan-rotor-input = "tach"; > + maxim,fan-pwm-freq = <25000>; > + maxim,fan-dual-tach; > + maxim,fan-no-watchdog; > + maxim,fan-no-fault-ramp; > + maxim,fan-ramp = <2>; > + maxim,fan-fault-pin-mon; > + }; > + > + fan6: fan@1 { > + compatible = "pmbus-fan"; > + reg = <1>; > + tach-pulses = <2>; > + maxim,fan-rotor-input = "tach"; > + maxim,fan-pwm-freq = <25000>; > + maxim,fan-dual-tach; > + maxim,fan-no-watchdog; > + maxim,fan-no-fault-ramp; > + maxim,fan-ramp = <2>; > + maxim,fan-fault-pin-mon; > + }; > }; > > eeprom@55 { ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 0/1] ARM: dts: aspeed: system1: IBM System1 BMC update 2024-07-31 21:47 [PATCH v1 0/1] ARM: dts: aspeed: system1: IBM System1 BMC update Ninad Palsule 2024-07-31 21:47 ` [PATCH v1 1/1] " Ninad Palsule @ 2024-08-01 15:29 ` Rob Herring (Arm) 2024-08-01 16:24 ` Ninad Palsule 1 sibling, 1 reply; 7+ messages in thread From: Rob Herring (Arm) @ 2024-08-01 15:29 UTC (permalink / raw) To: Ninad Palsule Cc: andrew, conor+dt, eajames, robh+dt, linux-kernel, krzysztof.kozlowski+dt, linux-arm-kernel, joel, devicetree, linux-aspeed On Wed, 31 Jul 2024 16:47:28 -0500, Ninad Palsule wrote: > Hello, > > This patch only applies to openbmc/linux. The max31785 pmbus driver > changes are not available in the upstream yet. I will try to send those > changes upstream. > > Ninad Palsule (1): > ARM: dts: aspeed: system1: IBM System1 BMC update > > .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 96 +++++++++++++++++++ > 1 file changed, 96 insertions(+) > > -- > 2.43.0 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-ibm-system1.dtb' for 20240731214737.986010-1-ninad@linux.ibm.com: arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@0: failed to match any schema with compatible: ['pmbus-fan'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@1: failed to match any schema with compatible: ['pmbus-fan'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@2: failed to match any schema with compatible: ['pmbus-fan'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@3: failed to match any schema with compatible: ['pmbus-fan'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@4: failed to match any schema with compatible: ['pmbus-fan'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@54/fan@0: failed to match any schema with compatible: ['pmbus-fan'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@54/fan@1: failed to match any schema with compatible: ['pmbus-fan'] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 0/1] ARM: dts: aspeed: system1: IBM System1 BMC update 2024-08-01 15:29 ` [PATCH v1 0/1] " Rob Herring (Arm) @ 2024-08-01 16:24 ` Ninad Palsule 2024-08-01 17:36 ` Rob Herring 0 siblings, 1 reply; 7+ messages in thread From: Ninad Palsule @ 2024-08-01 16:24 UTC (permalink / raw) To: Rob Herring (Arm) Cc: andrew, eajames, robh+dt, joel, devicetree, linux-aspeed Hi Rob, On 8/1/24 10:29, Rob Herring (Arm) wrote: > On Wed, 31 Jul 2024 16:47:28 -0500, Ninad Palsule wrote: >> Hello, >> >> This patch only applies to openbmc/linux. The max31785 pmbus driver >> changes are not available in the upstream yet. I will try to send those >> changes upstream. >> >> Ninad Palsule (1): >> ARM: dts: aspeed: system1: IBM System1 BMC update >> >> .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 96 +++++++++++++++++++ >> 1 file changed, 96 insertions(+) >> >> -- >> 2.43.0 >> >> >> > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-ibm-system1.dtb' for 20240731214737.986010-1-ninad@linux.ibm.com: > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@0: failed to match any schema with compatible: ['pmbus-fan'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@1: failed to match any schema with compatible: ['pmbus-fan'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@2: failed to match any schema with compatible: ['pmbus-fan'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@3: failed to match any schema with compatible: ['pmbus-fan'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@4: failed to match any schema with compatible: ['pmbus-fan'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@54/fan@0: failed to match any schema with compatible: ['pmbus-fan'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@54/fan@1: failed to match any schema with compatible: ['pmbus-fan'] > I have seen these warning. I am not sure how to fix them as it is already documented in the following file. Documentation/devicetree/bindings/hwmon/pmbus/max31785.txt May be because its not converted to YAML yet? Thanks & Rehads, Ninad Palsule ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 0/1] ARM: dts: aspeed: system1: IBM System1 BMC update 2024-08-01 16:24 ` Ninad Palsule @ 2024-08-01 17:36 ` Rob Herring 2024-08-01 18:50 ` Ninad Palsule 0 siblings, 1 reply; 7+ messages in thread From: Rob Herring @ 2024-08-01 17:36 UTC (permalink / raw) To: Ninad Palsule; +Cc: andrew, eajames, joel, devicetree, linux-aspeed On Thu, Aug 1, 2024 at 10:25 AM Ninad Palsule <ninad@linux.ibm.com> wrote: > > Hi Rob, > > On 8/1/24 10:29, Rob Herring (Arm) wrote: > > On Wed, 31 Jul 2024 16:47:28 -0500, Ninad Palsule wrote: > >> Hello, > >> > >> This patch only applies to openbmc/linux. The max31785 pmbus driver > >> changes are not available in the upstream yet. I will try to send those > >> changes upstream. > >> > >> Ninad Palsule (1): > >> ARM: dts: aspeed: system1: IBM System1 BMC update > >> > >> .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 96 +++++++++++++++++++ > >> 1 file changed, 96 insertions(+) > >> > >> -- > >> 2.43.0 > >> > >> > >> > > > > My bot found new DTB warnings on the .dts files added or changed in this > > series. > > > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > > are fixed by another series. Ultimately, it is up to the platform > > maintainer whether these warnings are acceptable or not. No need to reply > > unless the platform maintainer has comments. > > > > If you already ran DT checks and didn't see these error(s), then > > make sure dt-schema is up to date: > > > > pip3 install dtschema --upgrade > > > > > > New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-ibm-system1.dtb' for 20240731214737.986010-1-ninad@linux.ibm.com: > > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@0: failed to match any schema with compatible: ['pmbus-fan'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@1: failed to match any schema with compatible: ['pmbus-fan'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@2: failed to match any schema with compatible: ['pmbus-fan'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@3: failed to match any schema with compatible: ['pmbus-fan'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@4: failed to match any schema with compatible: ['pmbus-fan'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@54/fan@0: failed to match any schema with compatible: ['pmbus-fan'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@54/fan@1: failed to match any schema with compatible: ['pmbus-fan'] > > > I have seen these warning. I am not sure how to fix them as it is > already documented in the following file. > > Documentation/devicetree/bindings/hwmon/pmbus/max31785.txt $ git log -- Documentation/devicetree/bindings/hwmon/pmbus/max31785.txt (END) Did you mean Documentation/devicetree/bindings/hwmon/max31785.txt? If so, there is no 'pmbus-fan' in it or anywhere else except aspeed dts files. The state of the aspeed dts files is really quite sad. This is a count of warnings. The first number is total warnings. The second number is unique warnings (stripping the dtb name so we don't have N warnings for N boards). The 2nd list is undocumented (by schema) compatibles. The number of warnings vs. Linus's tree is higher already and we just started the cycle. That's the wrong direction and in general I see very little if any effort reducing the warnings for aspeed. This is all run daily here: https://gitlab.com/robherring/linux-dt/-/jobs arch/arm/boot/dts/aspeed:3682:635 184 sbefifo@2400: '#address-cells', '#size-cells' do not match any of the regexes: 'pinctrl-[0-9]+' 160 i2cr@20: #address-cells: 1 was expected 88 eeprom@0: 'size' is a required property 88 eeprom@0: 'pagesize' is a required property 88 eeprom@0: 'address-width' is a required property 70 lpc@1e789000: reg-io-width: 4 is not of type 'object' 62 kcs@2c: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' 62 kcs@28: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' 62 kcs@24: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' 62 kcs@114: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' 45 sram@1e720000: 'ranges' is a required property 45 sram@1e720000: '#size-cells' is a required property 45 sram@1e720000: '#address-cells' is a required property 45 lpc@1e789000: lpc-snoop@90: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' 25 timer: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' 25 syscon@1e6e2000: 'smp-memram@180' does not match any of the regexes: '^interrupt-controller@[0-9a-f]+$', '^p2a-control@[0-9a-f]+$', '^pinctrl(@[0-9a-f]+)?$', '^silicon-id@[0-9a-f]+$', 'pinctrl-[0-9]+' 25 lpc@1e789000: lpc-snoop@80: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' 25 ftgmac@1e690000: $nodename:0: 'ftgmac@1e690000' does not match '^ethernet(@.*)?$' 25 ftgmac@1e680000: $nodename:0: 'ftgmac@1e680000' does not match '^ethernet(@.*)?$' 25 ftgmac@1e670000: $nodename:0: 'ftgmac@1e670000' does not match '^ethernet(@.*)?$' 25 ftgmac@1e660000: $nodename:0: 'ftgmac@1e660000' does not match '^ethernet(@.*)?$' 25 fsi@1e79b100: compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] is too long 25 fsi@1e79b000: compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] is too long 25 crypto@1e6fa000: 'aspeed,ahbc' does not match any of the regexes: 'pinctrl-[0-9]+' 25 bus@1e600000: compatible: ['aspeed,ast2600-ahbc', 'syscon'] is too long 24 sdc@1e740000: sdhci@1e740200:compatible: ['aspeed,ast2600-sdhci', 'sdhci'] is too long 24 sdc@1e740000: sdhci@1e740100:compatible: ['aspeed,ast2600-sdhci', 'sdhci'] is too long 22 spi@60: 'eeprom@0' does not match any of the regexes: '^spi@[0-9a-f]+$', 'pinctrl-[0-9]+' 22 spi@40: 'eeprom@0' does not match any of the regexes: '^spi@[0-9a-f]+$', 'pinctrl-[0-9]+' 22 sbefifo@2400: occ: 'occ-hwmon', 'reg' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/aspeed:68 ['adi, adm1272'] ['adm1272'] ['adm1275'] ['aspeed,ast2400-cf-fsi-master', 'fsi-master'] ['aspeed,ast2400-cvic', 'aspeed-cvic'] ['aspeed,ast2400-i2c-ic'] ['aspeed,ast2400-ibt-bmc'] ['aspeed,ast2400-lhc'] ['aspeed,ast2400-p2a-ctrl'] ['aspeed,ast2400-pwm-tacho'] ['aspeed,ast2400-timer'] ['aspeed,ast2400-vic'] ['aspeed,ast2400-video-engine'] ['aspeed,ast2500-cf-fsi-master', 'fsi-master'] ['aspeed,ast2500-cvic', 'aspeed-cvic'] ['aspeed,ast2500-gfx', 'syscon'] ['aspeed,ast2500-i2c-ic'] ['aspeed,ast2500-ibt-bmc'] ['aspeed,ast2500-lhc'] ['aspeed,ast2500-p2a-ctrl'] ['aspeed,ast2500-pwm-tacho'] ['aspeed,ast2500-scu-ic'] ['aspeed,ast2500-sdram-edac'] ['aspeed,ast2500-video-engine'] ['aspeed,ast2500-xdma'] ['aspeed,ast2600-fsi-master', 'fsi-master'] ['aspeed,ast2600-gfx', 'syscon'] ['aspeed,ast2600-ibt-bmc'] ['aspeed,ast2600-lhc'] ['aspeed,ast2600-scu-ic0'] ['aspeed,ast2600-scu-ic1'] ['aspeed,ast2600-sdhci', 'sdhci'] ['aspeed,ast2600-sdram-edac', 'syscon'] ['aspeed,ast2600-smpmem'] ['aspeed,ast2600-timer'] ['aspeed,ast2600-udma'] ['aspeed,ast2600-video-engine'] ['aspeed,ast2600-xdma'] ['atmel,at30tse004a'] ['dallas,ds3231'] ['delta,dps800'] ['dps650ab'] ['fsi-master-gpio', 'fsi-master'] ['fsi-master-hub'] ['ibm,bonnell-bmc', 'aspeed,ast2600'] ['ibm,fsi-i2c-master'] ['ibm,fsi-master-hub'] ['ibm,fsi2pib'] ['ibm,pca9552'] ['infineon,ir35221'] ['infineon,pxe1610'] ['ipmb-dev'] ['isil,isl69260'] ['isil,raa229004'] ['lm75'] ['max31790'] ['maxim,max31785a'] ['microchip,emc1413'] ['mps,mp5023'] ['nuvoton,w83795g'] ['nvt210'] ['nxp,pca9551'] ['nxp,pca9552'] ['nxp,pca9641'] ['pmbus'] ['pmbus-fan'] ['si,si7021a20'] ['ti,ucd90160'] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 0/1] ARM: dts: aspeed: system1: IBM System1 BMC update 2024-08-01 17:36 ` Rob Herring @ 2024-08-01 18:50 ` Ninad Palsule 0 siblings, 0 replies; 7+ messages in thread From: Ninad Palsule @ 2024-08-01 18:50 UTC (permalink / raw) To: Rob Herring; +Cc: andrew, eajames, joel, devicetree, linux-aspeed Hi Rob, On 8/1/24 12:36, Rob Herring wrote: > On Thu, Aug 1, 2024 at 10:25 AM Ninad Palsule <ninad@linux.ibm.com> wrote: >> I have seen these warning. I am not sure how to fix them as it is >> already documented in the following file. >> >> Documentation/devicetree/bindings/hwmon/pmbus/max31785.txt > $ git log -- Documentation/devicetree/bindings/hwmon/pmbus/max31785.txt > (END) Yes, This file only exist in the www.github.com/openbmc/linux. I will try to upstream it along with driver changes later. Sorry I was not suppose to send this patch to upstream. So please ignore the patch. Thanks & Regards, Ninad Palsule > > Did you mean Documentation/devicetree/bindings/hwmon/max31785.txt? If > so, there is no 'pmbus-fan' in it or anywhere else except aspeed dts > files. > > The state of the aspeed dts files is really quite sad. This is a count > of warnings. The first number is total warnings. The second number is > unique warnings (stripping the dtb name so we don't have N warnings > for N boards). The 2nd list is undocumented (by schema) compatibles. > > The number of warnings vs. Linus's tree is higher already and we just > started the cycle. That's the wrong direction and in general I see > very little if any effort reducing the warnings for aspeed. > > This is all run daily here: https://gitlab.com/robherring/linux-dt/-/jobs > > arch/arm/boot/dts/aspeed:3682:635 > 184 sbefifo@2400: '#address-cells', '#size-cells' do not match > any of the regexes: 'pinctrl-[0-9]+' > 160 i2cr@20: #address-cells: 1 was expected > 88 eeprom@0: 'size' is a required property > 88 eeprom@0: 'pagesize' is a required property > 88 eeprom@0: 'address-width' is a required property > 70 lpc@1e789000: reg-io-width: 4 is not of type 'object' > 62 kcs@2c: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' > 62 kcs@28: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' > 62 kcs@24: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' > 62 kcs@114: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' > 45 sram@1e720000: 'ranges' is a required property > 45 sram@1e720000: '#size-cells' is a required property > 45 sram@1e720000: '#address-cells' is a required property > 45 lpc@1e789000: lpc-snoop@90: 'clocks' does not match any of > the regexes: 'pinctrl-[0-9]+' > 25 timer: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' > 25 syscon@1e6e2000: 'smp-memram@180' does not match any of the > regexes: '^interrupt-controller@[0-9a-f]+$', > '^p2a-control@[0-9a-f]+$', '^pinctrl(@[0-9a-f]+)?$', > '^silicon-id@[0-9a-f]+$', 'pinctrl-[0-9]+' > 25 lpc@1e789000: lpc-snoop@80: 'clocks' does not match any of > the regexes: 'pinctrl-[0-9]+' > 25 ftgmac@1e690000: $nodename:0: 'ftgmac@1e690000' does not > match '^ethernet(@.*)?$' > 25 ftgmac@1e680000: $nodename:0: 'ftgmac@1e680000' does not > match '^ethernet(@.*)?$' > 25 ftgmac@1e670000: $nodename:0: 'ftgmac@1e670000' does not > match '^ethernet(@.*)?$' > 25 ftgmac@1e660000: $nodename:0: 'ftgmac@1e660000' does not > match '^ethernet(@.*)?$' > 25 fsi@1e79b100: compatible: ['aspeed,ast2600-fsi-master', > 'fsi-master'] is too long > 25 fsi@1e79b000: compatible: ['aspeed,ast2600-fsi-master', > 'fsi-master'] is too long > 25 crypto@1e6fa000: 'aspeed,ahbc' does not match any of the > regexes: 'pinctrl-[0-9]+' > 25 bus@1e600000: compatible: ['aspeed,ast2600-ahbc', 'syscon'] is too long > 24 sdc@1e740000: sdhci@1e740200:compatible: > ['aspeed,ast2600-sdhci', 'sdhci'] is too long > 24 sdc@1e740000: sdhci@1e740100:compatible: > ['aspeed,ast2600-sdhci', 'sdhci'] is too long > 22 spi@60: 'eeprom@0' does not match any of the regexes: > '^spi@[0-9a-f]+$', 'pinctrl-[0-9]+' > 22 spi@40: 'eeprom@0' does not match any of the regexes: > '^spi@[0-9a-f]+$', 'pinctrl-[0-9]+' > 22 sbefifo@2400: occ: 'occ-hwmon', 'reg' do not match any of the > regexes: 'pinctrl-[0-9]+' > > arch/arm/boot/dts/aspeed:68 > ['adi, adm1272'] > ['adm1272'] > ['adm1275'] > ['aspeed,ast2400-cf-fsi-master', 'fsi-master'] > ['aspeed,ast2400-cvic', 'aspeed-cvic'] > ['aspeed,ast2400-i2c-ic'] > ['aspeed,ast2400-ibt-bmc'] > ['aspeed,ast2400-lhc'] > ['aspeed,ast2400-p2a-ctrl'] > ['aspeed,ast2400-pwm-tacho'] > ['aspeed,ast2400-timer'] > ['aspeed,ast2400-vic'] > ['aspeed,ast2400-video-engine'] > ['aspeed,ast2500-cf-fsi-master', 'fsi-master'] > ['aspeed,ast2500-cvic', 'aspeed-cvic'] > ['aspeed,ast2500-gfx', 'syscon'] > ['aspeed,ast2500-i2c-ic'] > ['aspeed,ast2500-ibt-bmc'] > ['aspeed,ast2500-lhc'] > ['aspeed,ast2500-p2a-ctrl'] > ['aspeed,ast2500-pwm-tacho'] > ['aspeed,ast2500-scu-ic'] > ['aspeed,ast2500-sdram-edac'] > ['aspeed,ast2500-video-engine'] > ['aspeed,ast2500-xdma'] > ['aspeed,ast2600-fsi-master', 'fsi-master'] > ['aspeed,ast2600-gfx', 'syscon'] > ['aspeed,ast2600-ibt-bmc'] > ['aspeed,ast2600-lhc'] > ['aspeed,ast2600-scu-ic0'] > ['aspeed,ast2600-scu-ic1'] > ['aspeed,ast2600-sdhci', 'sdhci'] > ['aspeed,ast2600-sdram-edac', 'syscon'] > ['aspeed,ast2600-smpmem'] > ['aspeed,ast2600-timer'] > ['aspeed,ast2600-udma'] > ['aspeed,ast2600-video-engine'] > ['aspeed,ast2600-xdma'] > ['atmel,at30tse004a'] > ['dallas,ds3231'] > ['delta,dps800'] > ['dps650ab'] > ['fsi-master-gpio', 'fsi-master'] > ['fsi-master-hub'] > ['ibm,bonnell-bmc', 'aspeed,ast2600'] > ['ibm,fsi-i2c-master'] > ['ibm,fsi-master-hub'] > ['ibm,fsi2pib'] > ['ibm,pca9552'] > ['infineon,ir35221'] > ['infineon,pxe1610'] > ['ipmb-dev'] > ['isil,isl69260'] > ['isil,raa229004'] > ['lm75'] > ['max31790'] > ['maxim,max31785a'] > ['microchip,emc1413'] > ['mps,mp5023'] > ['nuvoton,w83795g'] > ['nvt210'] > ['nxp,pca9551'] > ['nxp,pca9552'] > ['nxp,pca9641'] > ['pmbus'] > ['pmbus-fan'] > ['si,si7021a20'] > ['ti,ucd90160'] ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-08-01 18:50 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-07-31 21:47 [PATCH v1 0/1] ARM: dts: aspeed: system1: IBM System1 BMC update Ninad Palsule 2024-07-31 21:47 ` [PATCH v1 1/1] " Ninad Palsule 2024-07-31 21:57 ` Eddie James 2024-08-01 15:29 ` [PATCH v1 0/1] " Rob Herring (Arm) 2024-08-01 16:24 ` Ninad Palsule 2024-08-01 17:36 ` Rob Herring 2024-08-01 18:50 ` Ninad Palsule
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).